fixup! use rule identifiers

Author: TomasVotruba

src/PHPStan/Rules/Doctrine/NoParentRepositoryRule.php

@@ -51,10 +51,10 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $ruleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
+        $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
             ->identifier(RuleIdentifier::DOCTRINE_NO_PARENT_REPOSITORY)
             ->build();
 
-        return [$ruleError];
+        return [$identifierRuleError];
     }
 }

src/PHPStan/Rules/Doctrine/NoRepositoryCallInDataFixtureRule.php

@@ -55,11 +55,11 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $ruleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
+        $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
             ->identifier(RuleIdentifier::DOCTRINE_NO_REPOSITORY_CALL_IN_DATA_FIXTURES)
             ->build();
 
-        return [$ruleError];
+        return [$identifierRuleError];
     }
 
     private function isDataFixtureClass(Scope $scope): bool

src/Rules/Complexity/NoConstructorOverrideRule.php

@@ -68,10 +68,10 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $ruleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
+        $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
             ->identifier(RuleIdentifier::NO_CONSTRUCTOR_OVERRIDE)
             ->build();
 
-        return [$ruleError];
+        return [$identifierRuleError];
     }
 }

src/Rules/NoDynamicNameRule.php

@@ -24,15 +24,15 @@
  *
  * @implements Rule<Node>
  */
-final class NoDynamicNameRule implements Rule
+final readonly class NoDynamicNameRule implements Rule
 {
     /**
      * @var string
      */
     public const ERROR_MESSAGE = 'Use explicit names over dynamic ones';
 
     public function __construct(
-        private readonly CallableTypeAnalyzer $callableTypeAnalyzer,
+        private CallableTypeAnalyzer $callableTypeAnalyzer,
     ) {
     }
 

src/Rules/NoReferenceRule.php

@@ -24,17 +24,17 @@
 /**
  * @see \Symplify\PHPStanRules\Tests\Rules\NoReferenceRule\NoReferenceRuleTest
  *
- * @implements Rule<\PhpParser\Node>
+ * @implements Rule<Node>
  */
-final class NoReferenceRule implements Rule
+final readonly class NoReferenceRule implements Rule
 {
     /**
      * @var string
      */
     public const ERROR_MESSAGE = 'Use explicit return value over magic &reference';
 
     public function __construct(
-        private readonly ParentClassMethodNodeResolver $parentClassMethodNodeResolver,
+        private ParentClassMethodNodeResolver $parentClassMethodNodeResolver,
     ) {
     }
 

src/Rules/PHPUnit/NoMockOnlyTestRule.php

@@ -4,6 +4,7 @@
 
 namespace Symplify\PHPStanRules\Rules\PHPUnit;
 
+use Symplify\PHPStanRules\Testing\PHPUnitTestAnalyser;
 use PhpParser\Node;
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\Class_;
@@ -40,7 +41,7 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if (! \Symplify\PHPStanRules\Testing\PHPUnitTestAnalyser::isTestClass($scope)) {
+        if (! PHPUnitTestAnalyser::isTestClass($scope)) {
             return [];
         }
 
@@ -71,10 +72,10 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $ruleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
+        $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
             ->identifier(RuleIdentifier::PHPUNIT_NO_MOCK_ONLY)
             ->build();
 
-        return [$ruleError];
+        return [$identifierRuleError];
     }
 }

src/Rules/PHPUnit/PublicStaticDataProviderRule.php

@@ -4,6 +4,7 @@
 
 namespace Symplify\PHPStanRules\Rules\PHPUnit;
 
+use Symplify\PHPStanRules\Testing\PHPUnitTestAnalyser;
 use PhpParser\Node;
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Analyser\Scope;
@@ -42,15 +43,15 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if (! \Symplify\PHPStanRules\Testing\PHPUnitTestAnalyser::isTestClass($scope)) {
+        if (! PHPUnitTestAnalyser::isTestClass($scope)) {
             return [];
         }
 
         $ruleErrors = [];
 
         $classLike = $node->getOriginalNode();
         foreach ($classLike->getMethods() as $classMethod) {
-            if (! \Symplify\PHPStanRules\Testing\PHPUnitTestAnalyser::class::isTestClassMethod($classMethod)) {
+            if (! PHPUnitTestAnalyser::class::isTestClassMethod($classMethod)) {
                 continue;
             }
 

src/Rules/PreferredClassRule.php

@@ -24,7 +24,7 @@
  *
  * @implements Rule<Node>
  */
-final class PreferredClassRule implements Rule
+final readonly class PreferredClassRule implements Rule
 {
     /**
      * @var string
@@ -35,7 +35,7 @@ final class PreferredClassRule implements Rule
      * @param string[] $oldToPreferredClasses
      */
     public function __construct(
-        private readonly array $oldToPreferredClasses
+        private array $oldToPreferredClasses
     ) {
     }
 

src/Rules/Symfony/NoAbstractControllerConstructorRule.php

@@ -54,10 +54,10 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $ruleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
+        $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
             ->identifier(RuleIdentifier::SYMFONY_NO_ABSTRACT_CONTROLLER_CONSTRUCTOR)
             ->build();
 
-        return [$ruleError];
+        return [$identifierRuleError];
     }
 }

src/Rules/Symfony/NoListenerWithoutContractRule.php

@@ -44,19 +44,19 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $class = $node->getOriginalNode();
-        if (! $class instanceof Class_) {
+        $classLike = $node->getOriginalNode();
+        if (! $classLike instanceof Class_) {
             return [];
         }
 
-        if ($class->implements !== []) {
+        if ($classLike->implements !== []) {
             return [];
         }
 
-        $ruleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
+        $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
             ->identifier(RuleIdentifier::NO_LISTENER_WITHOUT_CONTRACT)
             ->build();
 
-        return [$ruleError];
+        return [$identifierRuleError];
     }
 }