[symfony] Skip invokable listeners (#197)

Author: TomasVotruba

src/Rules/Symfony/NoListenerWithoutContractRule.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Analyser\Scope;
 use PHPStan\Node\InClassNode;
 use PHPStan\Rules\Rule;
@@ -78,6 +79,11 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        // is invokable listeners?
+        if ($classLike->getMethod('__invoke') instanceof ClassMethod) {
+            return [];
+        }
+
         if ($this->isDoctrineListener($classLike)) {
             return [];
         }

tests/Rules/Symfony/NoListenerWithoutContractRule/Fixture/SkipInvokableListener.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Symplify\PHPStanRules\Tests\Rules\Symfony\NoListenerWithoutContractRule\Fixture;
+
+use Symfony\Component\HttpKernel\Event\RequestEvent;
+
+final class SkipInvokableListener
+{
+    public function __invoke(RequestEvent $event)
+    {
+    }
+}

tests/Rules/Symfony/NoListenerWithoutContractRule/NoListenerWithoutContractRuleTest.php

@@ -21,6 +21,9 @@ public function testRule(array $filePaths, array $expectedErrorsWithLines): void
 
     public static function provideData(): Iterator
     {
+        // @see https://symfony.com/blog/new-in-symfony-4-1-invokable-event-listeners
+        yield [[__DIR__ . '/Fixture/SkipInvokableListener.php'], []];
+
         yield [[__DIR__ . '/Fixture/SkipSecurityListener.php'], []];
         yield [[__DIR__ . '/Fixture/SkipAnotherSecurityListener.php'], []];
         yield [[__DIR__ . '/Fixture/SkipFormListener.php'], []];