skip custom functions in NoBareAndSecurityIsGrantedContentsRule (#220)

Author: TomasVotruba

src/Rules/Symfony/NoBareAndSecurityIsGrantedContentsRule.php

@@ -51,10 +51,37 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        if ($this->usesCustomFunctios($attributeExpr)) {
+            return [];
+        }
+
         $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
             ->identifier(SymfonyRuleIdentifier::REQUIRED_IS_GRANTED_ENUM)
             ->build();
 
         return [$identifierRuleError];
     }
+
+    private function usesCustomFunctios(String_ $string): bool
+    {
+        $joinedItems = preg_split('# (and|&&|or) #', $string->value, -1, PREG_SPLIT_NO_EMPTY);
+
+        if ($joinedItems === false) {
+            return false;
+        }
+
+        foreach ($joinedItems as $joinedItem) {
+            if (str_contains($joinedItem, 'is_granted')) {
+                continue;
+            }
+
+            if (str_contains($joinedItem, 'has_role')) {
+                continue;
+            }
+
+            return true;
+        }
+
+        return false;
+    }
 }

tests/Rules/Symfony/NoBareAndSecurityIsGrantedContentsRule/Fixture/SkipCustomFunction.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\Symfony\NoBareAndSecurityIsGrantedContentsRule\Fixture;
+
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted;
+
+#[IsGranted('custom_check("some_resource") && custom_check("another_resource")')]
+final class SkipCustomFunction
+{
+    public function run()
+    {
+    }
+}

tests/Rules/Symfony/NoBareAndSecurityIsGrantedContentsRule/NoBareAndSecurityIsGrantedContentsRuleTest.php

@@ -32,6 +32,7 @@ public static function provideData(): Iterator
         ]];
 
         yield [__DIR__ . '/Fixture/SkipInnerOr.php', []];
+        yield [__DIR__ . '/Fixture/SkipCustomFunction.php', []];
         yield [__DIR__ . '/Fixture/SkipSplitOne.php', []];
     }