[symfony] Add NoBundleResourceConfigRule (#203)

Author: TomasVotruba

README.md

@@ -1526,6 +1526,17 @@ return static function (ContainerConfigurator $configurator): void {
 
 <br>
 
+### NoBundleResourceConfigRule
+
+Avoid using configs in `*Bundle/Resources` directory. Move them to `/config` directory instead
+
+```yaml
+rules:
+    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoBundleResourceConfigRule
+```
+
+<br>
+
 ### NoRoutingPrefixRule
 
 Avoid global route prefixing. Use single place for paths in @Route/#[Route] and improve static analysis instead.

config/symfony-config-rules.neon

@@ -1,2 +1,3 @@
 rules:
     - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\ServicesExcludedDirectoryMustExistRule
+    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoBundleResourceConfigRule

src/Enum/SymfonyRuleIdentifier.php

@@ -43,4 +43,6 @@ final class SymfonyRuleIdentifier
     public const REQUIRE_ROUTE_NAME_TO_GENERATE_CONTROLLER_ROUTE = 'symfony.requireRouteNameToGenerateControllerRoute';
 
     public const SERVICES_EXCLUDED_DIRECTORY_MUST_EXIST = 'symfony.servicesExcludedDirectoryMustExist';
+
+    public const NO_BUNDLE_RESOURCE_CONFIG = 'symfony.noBundleResourceConfig';
 }

src/Rules/Symfony/ConfigClosure/NoBundleResourceConfigRule.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Rules\Symfony\ConfigClosure;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\Closure;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\IdentifierRuleError;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+use Symplify\PHPStanRules\Enum\SymfonyRuleIdentifier;
+use Symplify\PHPStanRules\Symfony\NodeAnalyzer\SymfonyClosureDetector;
+
+/**
+ * @implements Rule<Closure>
+ */
+final class NoBundleResourceConfigRule implements Rule
+{
+    /**
+     * @var string
+     */
+    private const ERROR_MESSAGE = 'Avoid using configs in Bundle/Resources directory. Move them to "/config" directory instead';
+
+    public function getNodeType(): string
+    {
+        return Closure::class;
+    }
+
+    /**
+     * @param Closure $node
+     * @return IdentifierRuleError[]
+     */
+    public function processNode(Node $node, Scope $scope): array
+    {
+        if (! SymfonyClosureDetector::detect($node)) {
+            return [];
+        }
+
+        if (! str_contains($scope->getFile(), 'Resources/config')) {
+            return [];
+        }
+
+        $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
+            ->identifier(SymfonyRuleIdentifier::NO_BUNDLE_RESOURCE_CONFIG)
+            ->build();
+
+        return [$identifierRuleError];
+    }
+}