[symfony] Skip NoListenerWithoutContractRule form listener (#196)

Author: TomasVotruba

src/Enum/SymfonyClass.php

@@ -8,6 +8,8 @@ final class SymfonyClass
 {
     public const SECURITY_LISTENER = 'Symfony\Component\Security\Http\Firewall\AbstractListener';
 
+    public const FORM_SECURITY_LISTENER = 'Symfony\Component\Security\Http\Firewall\UsernamePasswordFormAuthenticationListener';
+
     public const ROUTE_ATTRIBUTE = 'Symfony\Component\Routing\Attribute\Route';
 
     /**

src/Rules/Symfony/NoListenerWithoutContractRule.php

@@ -4,8 +4,8 @@
 
 namespace Symplify\PHPStanRules\Rules\Symfony;
 
-use PhpParser\Node\Name;
 use PhpParser\Node;
+use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\Class_;
 use PHPStan\Analyser\Scope;
 use PHPStan\Node\InClassNode;
@@ -151,6 +151,6 @@ private function isSecurityListener(Class_ $class): bool
             return false;
         }
 
-        return $class->extends->toString() === SymfonyClass::SECURITY_LISTENER;
+        return in_array($class->extends->toString(), [SymfonyClass::SECURITY_LISTENER, SymfonyClass::FORM_SECURITY_LISTENER], true);
     }
 }

tests/Rules/Symfony/NoListenerWithoutContractRule/Fixture/SkipAnotherSecurityListener.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Symplify\PHPStanRules\Tests\Rules\Symfony\NoListenerWithoutContractRule\Fixture;
+
+final class SkipAnotherSecurityListener extends
+    \Symfony\Component\Security\Http\Firewall\UsernamePasswordFormAuthenticationListener
+{
+
+}

tests/Rules/Symfony/NoListenerWithoutContractRule/NoListenerWithoutContractRuleTest.php

@@ -22,6 +22,7 @@ public function testRule(array $filePaths, array $expectedErrorsWithLines): void
     public static function provideData(): Iterator
     {
         yield [[__DIR__ . '/Fixture/SkipSecurityListener.php'], []];
+        yield [[__DIR__ . '/Fixture/SkipAnotherSecurityListener.php'], []];
         yield [[__DIR__ . '/Fixture/SkipFormListener.php'], []];
 
         yield [[__DIR__ . '/Fixture/SomeContractedListener.php'], []];