cs

Author: TomasVotruba

composer.json

@@ -40,7 +40,8 @@
             "stubs"
         ],
         "files": [
-            "vendor/symfony/dependency-injection/Loader/Configurator/ContainerConfigurator.php"
+            "vendor/symfony/dependency-injection/Loader/Configurator/ContainerConfigurator.php",
+            "tests/Rules/Rector/PhpUpgradeImplementsMinPhpVersionInterfaceRule/Fixture/SomePhpFeatureRector.php"
         ]
     },
     "config": {

phpstan.neon

@@ -33,9 +33,6 @@ parameters:
         - '#Method Symplify\\PHPStanRules\\(.*?)\:\:getRule\(\) return type with generic interface PHPStan\\Rules\\Rule does not specify its types\: TNodeType#'
         - '#Parameter \#2 \$expectedErrors of method PHPStan\\Testing\\RuleTestCase<PHPStan\\Rules\\Rule>\:\:analyse\(\) expects list<array\{0\: string, 1\: int, 2\?\: string\|null\}>, (.*?) given#'
 
-        # part of public contract
-        - '#Method Symplify\\PHPStanRules\\Tests\\Rules\\(.*?)\\(.*?)Test\:\:testRule\(\) has parameter \$(expectedError(.*?)|expectedErrors) with no value type specified in iterable type array#'
-
         # useful to have IDE know the types
         - identifier: phpstanApi.instanceofType
 
@@ -47,6 +44,10 @@ parameters:
         # used in tests
         - '#Public constant "Symplify\\PHPStanRules\\(.*?)Rule\:\:ERROR_MESSAGE" is never used#'
 
+        -
+            message: '#Generator expects value type array<string, mixed>, list<bool\|float\|int\|list<string>\|PHPStan\\TrinaryLogic\|string\|null> given#'
+            path: tests/ReturnTypeExtension/NodeGetAttributeTypeExtension/NodeGetAttributeTypeExtensionTest.php
+
         - '#Although PHPStan\\Node\\InClassNode is covered by backward compatibility promise, this instanceof assumption might break because (.*?) not guaranteed to always stay the same#'
         - '#PHPStan\\DependencyInjection\\NeonAdapter#'
 

src/Rules/NoGlobalConstRule.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Const_;
 use PHPStan\Analyser\Scope;
+use PHPStan\Rules\IdentifierRuleError;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Enum\RuleIdentifier;
@@ -29,6 +30,7 @@ public function getNodeType(): string
 
     /**
      * @param Const_ $node
+     * @return IdentifierRuleError[]
      */
     public function processNode(Node $node, Scope $scope): array
     {

src/Rules/Symfony/RequiredOnlyInAbstractRule.php

@@ -12,6 +12,7 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use Symplify\PHPStanRules\Enum\DoctrineClass;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\SymfonyRuleIdentifier;
 use Symplify\PHPStanRules\NodeAnalyzer\SymfonyRequiredMethodAnalyzer;
 
@@ -34,7 +35,7 @@ final class RequiredOnlyInAbstractRule implements Rule
      * @var string[]
      */
     private const SKIPPED_PARENT_TYPES = [
-        'Doctrine\ODM\MongoDB\Repository\DocumentRepository',
+        DoctrineClass::DOCUMENT_REPOSITORY,
     ];
 
     public function getNodeType(): string

tests/ReturnTypeExtension/NodeGetAttributeTypeExtension/NodeGetAttributeTypeExtensionTest.php

@@ -20,7 +20,7 @@ public function testAsserts(string $assertType, string $file, mixed ...$args): v
     }
 
     /**
-     * @return Iterator<array<string, array<array<mixed>, mixed>>>
+     * @return Iterator<array<string, mixed>>
      */
     public static function dataAsserts(): Iterator
     {

tests/Rules/Rector/PhpUpgradeImplementsMinPhpVersionInterfaceRule/PhpUpgradeImplementsMinPhpVersionInterfaceRuleTest.php

@@ -4,11 +4,11 @@
 
 namespace Symplify\PHPStanRules\Tests\Rules\Rector\PhpUpgradeImplementsMinPhpVersionInterfaceRule;
 
-use Rector\Php80\Rector\Class_\SomePhpFeatureRector;
 use Iterator;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Php80\Rector\Class_\SomePhpFeatureRector;
 use Symplify\PHPStanRules\Rules\Rector\PhpUpgradeImplementsMinPhpVersionInterfaceRule;
 
 final class PhpUpgradeImplementsMinPhpVersionInterfaceRuleTest extends RuleTestCase