misc

Author: TomasVotruba

composer.json

@@ -17,7 +17,8 @@
         "tomasvotruba/class-leak": "^2.0",
         "rector/rector": "^2.0",
         "phpstan/extension-installer": "^1.4",
-        "symplify/phpstan-extensions": "^12.0"
+        "symplify/phpstan-extensions": "^12.0",
+        "tomasvotruba/unused-public": "^2.0"
     },
     "autoload": {
         "psr-4": {
@@ -30,17 +31,8 @@
         },
         "classmap": [
             "stubs"
-        ],
-        "files": [
         ]
     },
-    "extra": {
-        "phpstan": {
-            "includes": [
-                "config/services/services.neon"
-            ]
-        }
-    },
     "config": {
         "platform-check": false,
         "allow-plugins": {
@@ -52,5 +44,12 @@
         "fix-cs": "vendor/bin/ecs check --fix --ansi",
         "phpstan": "vendor/bin/phpstan analyse --ansi",
         "rector": "vendor/bin/rector process --dry-run --ansi"
+    },
+    "extra": {
+        "phpstan": {
+            "includes": [
+                "config/services/services.neon"
+            ]
+        }
     }
 }

phpstan.neon

@@ -23,10 +23,10 @@ parameters:
         - */Fixture/*
 
     # https://github.com/TomasVotruba/unused-public
-    # unused_public:
-    #     methods: true
-    #     properties: true
-    #     constants: true
+    unused_public:
+        methods: true
+        properties: true
+        constants: true
 
     # type_coverage:
     #     return: 99
@@ -70,3 +70,6 @@ parameters:
 
         # handle next
         - '#Method Symplify\\PHPStanRules\\Rules\\AbstractSymplifyRule\:\:processNode\(\) should return list<PHPStan\\Rules\\IdentifierRuleError> but returns array<PHPStan\\Rules\\RuleError\|string>#'
+
+        # used in tests
+        - '#Public constant "Symplify\\PHPStanRules\\(.*?)Rule\:\:ERROR_MESSAGE" is never used#'

src/Composer/Psr4PathValidator.php

@@ -30,7 +30,7 @@ public function isClassNamespaceCorrect(
 
         // @todo put into value object
         $namespaceSuffixByNamespaceBeforeClass = rtrim(
-            Strings::substring(
+            substr(
                 $classNamespaceAndDirectory->getNamespaceBeforeClass(),
                 strlen($classNamespaceAndDirectory->getNamespace())
             ),

src/Enum/ClassName.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Enum;
+
+final class ClassName
+{
+    /**
+     * @var string
+     */
+    public const ROUTE_ATTRIBUTE = 'Symfony\Component\Routing\Annotation\Route';
+
+    /**
+     * @var string
+     */
+    public const NETTE_STRINGS = 'Nette\Utils\Strings';
+}

src/Enum/RuleIdentifier.php

@@ -170,4 +170,9 @@ final class RuleIdentifier
      * @var string
      */
     public const REQUIRED_INTERFACE_CONTRACT_NAMESPACE = 'symplify.requiredInterfaceContractNamespace';
+
+    /**
+     * @var string
+     */
+    public const SYMFONY_REQUIRE_INVOKABLE_CONTROLLER = 'symfony.requireInvokableController';
 }

src/Naming/ClassToSuffixResolver.php

@@ -32,15 +32,15 @@ public function resolveFromClass(string $parentClass): string
     private function removeAbstractInterfacePrefixSuffix(string $parentType): string
     {
         if (\str_ends_with($parentType, 'Interface')) {
-            $parentType = Strings::substring($parentType, 0, -strlen('Interface'));
+            $parentType = substr($parentType, 0, -strlen('Interface'));
         }
 
         if (\str_ends_with($parentType, 'Abstract')) {
-            $parentType = Strings::substring($parentType, 0, -strlen('Abstract'));
+            $parentType = substr($parentType, 0, -strlen('Abstract'));
         }
 
         if (\str_starts_with($parentType, 'Abstract')) {
-            return Strings::substring($parentType, strlen('Abstract'));
+            return substr($parentType, (int) strlen('Abstract'));
         }
 
         return $parentType;

src/NodeAnalyzer/RegexStaticCallAnalyzer.php

@@ -4,10 +4,10 @@
 
 namespace Symplify\PHPStanRules\NodeAnalyzer;
 
-use Nette\Utils\Strings;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
+use Symplify\PHPStanRules\Enum\ClassName;
 
 final class RegexStaticCallAnalyzer
 {
@@ -22,7 +22,7 @@ public function isRegexStaticCall(StaticCall $staticCall): bool
             return false;
         }
 
-        if ($staticCall->class->toString() !== Strings::class) {
+        if ($staticCall->class->toString() !== ClassName::NETTE_STRINGS) {
             return false;
         }
 

src/Rules/AnnotateRegexClassConstWithRegexLinkRule.php

@@ -73,7 +73,7 @@ public function processNode(Node $node, Scope $scope): array
     private function isNonSingleCharRegexPattern(string $value): bool
     {
         // skip 1-char regexs
-        if (Strings::length($value) < 4) {
+        if (strlen($value) < 4) {
             return false;
         }
 
@@ -85,7 +85,7 @@ private function isNonSingleCharRegexPattern(string $value): bool
 
         $patternWithoutModifiers = rtrim($value, self::ALL_MODIFIERS);
 
-        if (Strings::length($patternWithoutModifiers) < 1) {
+        if (strlen($patternWithoutModifiers) < 1) {
             return false;
         }
 

src/Rules/NoInlineStringRegexRule.php

@@ -4,7 +4,6 @@
 
 namespace Symplify\PHPStanRules\Rules;
 
-use Nette\Utils\Strings;
 use PhpParser\Node;
 use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\FuncCall;
@@ -96,7 +95,7 @@ private function processRegexStaticCall(StaticCall $staticCall): array
 
         $regexValue = $secondArgValue->value;
 
-        if (Strings::length($regexValue) <= 7) {
+        if (strlen($regexValue) <= 7) {
             return [];
         }
 

src/Rules/UppercaseConstantRule.php

@@ -13,6 +13,7 @@
 
 /**
  * @implements Rule<ClassConst>
+ *
  * @see \Symplify\PHPStanRules\Tests\Rules\UppercaseConstantRule\UppercaseConstantRuleTest
  */
 final class UppercaseConstantRule implements Rule