[dev] remove rule definitions, to make easier to add new rule and make them easier to work with (#148)

* [dev] remove rule definitions, to make easier to add new rule and make them less complex

* static fixes for PHPStan 2

* Remove RequireAssertConfigureValueObjectRectorRule as depends on context and common sense

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -44,7 +44,7 @@ jobs:
             # see https://github.com/shivammathur/setup-php
             -   uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.1
+                    php-version: 8.2
                     coverage: none
 
             # composer install cache - https://github.com/ramsey/composer-install

.github/workflows/downgraded_release.yaml

@@ -20,7 +20,7 @@ jobs:
             -
                 uses: "shivammathur/setup-php@v2"
                 with:
-                    php-version: 8.1
+                    php-version: 8.2
                     coverage: none
 
             # invoke patches

build/rector-downgrade-php-74.php

@@ -4,20 +4,11 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Removing\Rector\Class_\RemoveInterfacesRector;
-use Rector\Set\ValueObject\DowngradeLevelSetList;
 use Symplify\RuleDocGenerator\Contract\ConfigurableRuleInterface;
-use Symplify\RuleDocGenerator\Contract\DocumentedRuleInterface;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->parallel();
-
-    $rectorConfig->sets([DowngradeLevelSetList::DOWN_TO_PHP_74]);
-
-    $rectorConfig->ruleWithConfiguration(RemoveInterfacesRector::class, [
-        DocumentedRuleInterface::class,
+return RectorConfig::configure()
+    ->withDowngradeSets(php74: true)
+    ->withConfiguredRule(RemoveInterfacesRector::class, [
         ConfigurableRuleInterface::class,
-    ]);
-
-    $rectorConfig->skip(['*/Tests/*', '*/tests/*', __DIR__ . '/../../tests']);
-};
-
+    ])
+    ->withSkip(['*/Tests/*', '*/tests/*', __DIR__ . '/../../tests']);

composer.json

@@ -4,21 +4,20 @@
     "description": "Set of Symplify rules for PHPStan",
     "license": "MIT",
     "require": {
-        "php": ">=8.1",
-        "nette/utils": "^3.2.9 || ^4.0",
+        "php": ">=8.2",
+        "nette/utils": "^4.0",
         "webmozart/assert": "^1.11",
-        "phpstan/phpstan": "^2.0",
-        "symplify/rule-doc-generator-contracts": "^11.2"
+        "phpstan/phpstan": "^2.0"
     },
     "require-dev": {
-        "nikic/php-parser": "^5.0",
-        "symplify/rule-doc-generator": "^12.2",
-        "phpunit/phpunit": "^10.5",
+        "nikic/php-parser": "^5.3",
+        "phpunit/phpunit": "^11.5",
         "symfony/framework-bundle": "6.1.*",
-        "symplify/easy-coding-standard": "^12.3",
+        "symplify/easy-coding-standard": "^12.5",
         "tomasvotruba/class-leak": "^1.2",
         "rector/rector": "^2.0",
-        "phpstan/extension-installer": "^1.4"
+        "phpstan/extension-installer": "^1.4",
+        "symplify/phpstan-extensions": "^12.0"
     },
     "autoload": {
         "psr-4": {
@@ -52,7 +51,6 @@
         "check-cs": "vendor/bin/ecs check --ansi",
         "fix-cs": "vendor/bin/ecs check --fix --ansi",
         "phpstan": "vendor/bin/phpstan analyse --ansi",
-        "rector": "vendor/bin/rector process --dry-run --ansi",
-        "docs": "vendor/bin/rule-doc-generator generate src --readme --ansi"
+        "rector": "vendor/bin/rector process --dry-run --ansi"
     }
 }

config/rector-rules.neon

@@ -1,7 +1,6 @@
 rules:
     - Symplify\PHPStanRules\Rules\Rector\PhpUpgradeDowngradeRegisteredInSetRule
     - Symplify\PHPStanRules\Rules\Rector\PhpUpgradeImplementsMinPhpVersionInterfaceRule
-    - Symplify\PHPStanRules\Rules\Rector\RequireAssertConfigureValueObjectRectorRule
     - Symplify\PHPStanRules\Rules\Rector\NoInstanceOfStaticReflectionRule
     - Symplify\PHPStanRules\Rules\Rector\NoLeadingBackslashInNameRule
     - Symplify\PHPStanRules\Rules\Rector\NoClassReflectionStaticReflectionRule