Replace feedback_type String with FeedbackType enum

- Add FeedbackType enum with Comment and CompleteReview variants
- Update UserFeedback struct to use enum instead of string
- Update format_user_feedback_message to match on enum variants
- Update IPC message handler to convert string to enum
- Improves type safety and prevents invalid feedback types

Better type safety for user feedback handling in blocking pattern.

Author: nikomatsakis

server/src/ipc.rs

@@ -401,7 +401,7 @@ impl IPCCommunicator {
             // Return mock feedback for testing
             return Ok(crate::synthetic_pr::UserFeedback {
                 review_id: Some(review_id.to_string()),
-                feedback_type: "comment".to_string(),
+                feedback_type: crate::synthetic_pr::FeedbackType::Comment,
                 file_path: Some("test.rs".to_string()),
                 line_number: Some(42),
                 comment_text: Some("This is a test comment".to_string()),
@@ -816,7 +816,10 @@ impl IPCCommunicator {
                 // Convert to UserFeedback struct
                 let user_feedback = crate::synthetic_pr::UserFeedback {
                     review_id: Some(feedback_payload.review_id.clone()),
-                    feedback_type: feedback_payload.feedback_type,
+                    feedback_type: match feedback_payload.feedback_type.as_str() {
+                        "complete_review" => crate::synthetic_pr::FeedbackType::CompleteReview,
+                        _ => crate::synthetic_pr::FeedbackType::Comment,
+                    },
                     file_path: feedback_payload.file_path,
                     line_number: feedback_payload.line_number,
                     comment_text: feedback_payload.comment_text,

server/src/server.rs

@@ -86,8 +86,8 @@ impl DialecticServer {
 
     /// Format user feedback into clear instructions for the LLM
     fn format_user_feedback_message(&self, feedback: &UserFeedback) -> String {
-        match feedback.feedback_type.as_str() {
-            "comment" => {
+        match feedback.feedback_type {
+            crate::synthetic_pr::FeedbackType::Comment => {
                 let file_path = feedback.file_path.as_deref().unwrap_or("unknown file");
                 let line_number = feedback.line_number.unwrap_or(0);
                 let comment_text = feedback.comment_text.as_deref().unwrap_or("(no comment)");
@@ -111,7 +111,7 @@ impl DialecticServer {
                     file_path, line_number, comment_text, context, feedback.review_id.as_deref().unwrap_or("unknown")
                 )
             }
-            "complete_review" => {
+            crate::synthetic_pr::FeedbackType::CompleteReview => {
                 let action = feedback.completion_action.as_deref().unwrap_or("return");
                 let notes = feedback.additional_notes.as_deref().unwrap_or("");
 
@@ -142,7 +142,6 @@ impl DialecticServer {
                     )
                 }
             }
-            _ => format!("User provided feedback: {:?}", feedback)
         }
     }
 

server/src/synthetic_pr/mcp_tools.rs

@@ -17,12 +17,20 @@ pub struct RequestReviewParams {
     pub repo_path: Option<String>,
 }
 
+/// User feedback type from VSCode extension
+#[derive(Debug, Serialize, Deserialize, JsonSchema, Clone)]
+#[serde(rename_all = "snake_case")]
+pub enum FeedbackType {
+    Comment,
+    CompleteReview,
+}
+
 /// User feedback data from blocking MCP tools
 // ANCHOR: user_feedback
 #[derive(Debug, Serialize, Deserialize, JsonSchema)]
 pub struct UserFeedback {
     pub review_id: Option<String>,
-    pub feedback_type: String, // "comment" or "complete_review"
+    pub feedback_type: FeedbackType,
     pub file_path: Option<String>,
     pub line_number: Option<u32>,
     pub comment_text: Option<String>,