Fix UUID determinism in tests by making UUID generation a service

- Add generate_uuid() method to IpcClient trait
- MockIpcClient returns 'DUMMY_UUID' for deterministic tests
- IPCCommunicator generates real UUIDs in production
- Add user_data() getter to DialectInterpreter for accessing IpcClient
- Update Comment function to use IpcClient for UUID generation
- Update test expectation to use deterministic UUID

All 36 tests now pass! 🎉

Co-authored-by: Claude <[email protected]>

Author: nikomatsakis

server/src/dialect.rs

@@ -26,6 +26,10 @@ impl<U: Send> DialectInterpreter<U> {
         }
     }
 
+    pub fn user_data(&self) -> &U {
+        &self.userdata
+    }
+
     pub fn add_function<F>(&mut self)
     where
         F: DialectFunction<U>,

server/src/ide.rs

@@ -12,6 +12,7 @@ mod test;
 pub trait IpcClient: Send {
     async fn resolve_symbol_by_name(&mut self, name: &str) -> anyhow::Result<Vec<SymbolDef>>;
     async fn find_all_references(&mut self, symbol: &SymbolDef) -> anyhow::Result<Vec<FileRange>>;
+    fn generate_uuid(&self) -> String;
 }
 
 /// The "symbols" file is used as the expected argument
@@ -355,7 +356,7 @@ impl<U: IpcClient> DialectFunction<U> for Comment {
         }
 
         Ok(ResolvedComment {
-            id: uuid::Uuid::new_v4().to_string(),
+            id: interpreter.user_data().generate_uuid(),
             locations,
             icon: self.icon,
             comment: resolved_content,

server/src/ide/test.rs

@@ -100,6 +100,10 @@ impl IpcClient for MockIpcClient {
             .cloned()
             .unwrap_or_default())
     }
+
+    fn generate_uuid(&self) -> String {
+        "DUMMY_UUID".to_string()
+    }
 }
 
 // IDE Function Tests
@@ -700,7 +704,7 @@ async fn test_comment_function_with_symbol_def() {
                     String("This function needs better error handling"),
                 ],
                 "icon": String("warning"),
-                "id": String("1a67e922-b26f-4175-93d8-a0d6d5c5598d"),
+                "id": String("DUMMY_UUID"),
                 "locations": Array [
                     Object {
                         "content": String("fn validateToken(token: &str) -> bool {"),

server/src/ipc.rs

@@ -1066,6 +1066,10 @@ impl crate::ide::IpcClient for IPCCommunicator {
 
         Ok(locations)
     }
+
+    fn generate_uuid(&self) -> String {
+        uuid::Uuid::new_v4().to_string()
+    }
 }
 
 #[cfg(test)]