Refactor sendToActiveTerminal to use mandatory options object

- Change second parameter from optional boolean to mandatory options object
- Require explicit { includeNewline: boolean } in all calls
- Makes the API more explicit and extensible for future options
- Ask Socratic Shell uses { includeNewline: false }
- Walkthrough uses { includeNewline: true }

Co-authored-by: Claude <[email protected]>

Author: nikomatsakis

extension/src/bus.ts

@@ -121,7 +121,7 @@ export class Bus {
      * Send reference data to active terminal with consolidated logic
      * Handles terminal finding, reference creation, and XML generation
      */
-    async sendToActiveTerminal(referenceData: any, includeNewline: boolean = true): Promise<void> {
+    async sendToActiveTerminal(referenceData: any, options: { includeNewline: boolean }): Promise<void> {
         const selectedTerminal = await this.selectActiveTerminal();
         if (!selectedTerminal) return;
 
@@ -134,7 +134,7 @@ export class Bus {
         }
 
         // Generate <ssref id="..."/> XML (using current format)
-        const xmlMessage = `<ssref id="${referenceId}"/>` + (includeNewline ? '\n\n' : '');
+        const xmlMessage = `<ssref id="${referenceId}"/>` + (options.includeNewline ? '\n\n' : '');
 
         // Send XML to terminal
         selectedTerminal.terminal.sendText(xmlMessage, false); // false = don't execute, just insert text

extension/src/extension.ts

@@ -1076,7 +1076,7 @@ function setupSelectionDetection(bus: Bus): void {
                     selectedText: selectedText,
                 };
 
-                await bus.sendToActiveTerminal(referenceData, false);
+                await bus.sendToActiveTerminal(referenceData, { includeNewline: false });
                 outputChannel.appendLine(`Compact reference sent for ${relativePath}:${startLine}`);
             } catch (error) {
                 outputChannel.appendLine(`Failed to send reference: ${error}`);

extension/src/walkthroughWebview.ts

@@ -767,7 +767,7 @@ export class WalkthroughWebviewProvider implements vscode.WebviewViewProvider {
                 user_comment: text
             };
 
-            await this.bus.sendToActiveTerminal(referenceData);
+            await this.bus.sendToActiveTerminal(referenceData, { includeNewline: true });
             this.bus.outputChannel.appendLine(`Comment reply sent as compact reference for ${filePath}:${lineNumber}`);
         } catch (error) {
             console.error('[WALKTHROUGH] Error sending comment to shell:', error);