Skip to content

Commit cd2751e

Browse files
author
pipeline
committed
v19.1.63 is released
1 parent c54aa8a commit cd2751e

File tree

5 files changed

+134
-14
lines changed

5 files changed

+134
-14
lines changed

ReadMe.md

Lines changed: 124 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,129 @@ Note: Here, `'*'` Specifies that install the latest published package form the o
7676
7777
```
7878

79+
# Using the samples
80+
81+
## Installing
82+
83+
Before npm installation check `@syncfusion:registry=http://nexus.syncfusion.com/repository/ej2-production/` is available in npmrc file. Then use the below command to install all dependent packages.
84+
85+
```
86+
npm install
87+
```
88+
## Build
89+
90+
Use `npm run build` command to compile the source files. It calls the following tasks synchronously,
91+
92+
1. SEO changes
93+
2. Build
94+
3. Styles ship
95+
4. Site-map generate.
96+
97+
### SEO changes
98+
99+
It will set meta data and description for the h1 tag to show our components first in search engine. Use the below command to run it individual.
100+
101+
```
102+
gulp SEO-changes
103+
```
104+
### Build
105+
106+
Use the below command to generate scripts, styles, locale and sample lists.
107+
108+
```
109+
gulp build
110+
```
111+
It runs the following tasks syncronously,
112+
113+
1. Scripts
114+
2. Styles
115+
116+
#### Scripts
117+
118+
It compiles the Typescript files and use the below command to run this task.
119+
120+
```
121+
gulp scripts
122+
```
123+
124+
#### Styles
125+
126+
`gulp styles` command is used to compile default themes. It calls the following two tasks synchronously.
127+
128+
1. Default theme
129+
2. Compile styles
130+
131+
#### Default theme
132+
133+
Use the below command to generate default theme files.
134+
135+
```
136+
gulp default-theme
137+
```
138+
139+
#### Compile Styles
140+
It compiles the scss file to css file. To run this task use the below command,
141+
142+
```
143+
gulp compile-styles
144+
```
145+
146+
### Styles Shipping
147+
148+
It copies css files for themes from node_modules. Use the below command to run it individual.
149+
150+
```
151+
gulp styles-ship
152+
```
153+
154+
### Site map generation
155+
156+
The below command combines sample of all components and store it in sitemap-demos.xml file to index our components, samples, documents in search engine.
157+
158+
```
159+
gulp sitemap-generate
160+
```
161+
162+
## Testing
163+
164+
Use the following command to test lint errors in all files. It calls lint task synchronously,
165+
166+
```
167+
npm run test
168+
```
169+
170+
### Lint
171+
172+
Use `gulp lint` command to run this task. It calls the below tasks synchronously,
173+
174+
1. SASS Lint
175+
2. TS Lint
176+
3. File Checker
177+
178+
#### SASS Lint
179+
180+
It is used to test all SASS files whether it have any lint errors. The following command used to run this task,
181+
182+
```
183+
gulp sass-lint
184+
```
185+
186+
#### TS Lint
187+
188+
It check lint errors in all typescript files. Use the below command to run this task,
189+
190+
```
191+
gulp ts-lint
192+
```
193+
194+
#### File checker
195+
196+
A valid sample name and components name not have any numbers and symbols. The file checker task is used to check all file names are valid or not. Use the below command to run file checker task,
197+
198+
```
199+
gulp file-checker
200+
```
201+
79202
## Run the sample browser
80203

81204
We can run the sample browser with two commands
@@ -84,10 +207,9 @@ We can run the sample browser with two commands
84207
2. **gulp _watch_** – run the sample browser and monitor typescript as well. This will help at development time. If any changes detect means it will automatically compile and browser will reloaded.
85208

86209
```
87-
D:\dev\typescript\source\ej2-sample-browser>gulp serve
210+
gulp serve
88211
```
89212

90-
91213
**Access URLs:**
92214

93215
Local URL is works only in your machine.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@syncfusion/ej2-samples",
3-
"version": "19.1.54",
3+
"version": "19.1.63",
44
"description": "Samples for Syncfusion Essential JS 2",
55
"author": "Syncfusion Inc.",
66
"license": "SEE LICENSE IN license",

src/common/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -927,7 +927,6 @@ function loadTheme(theme: string): void {
927927
}
928928
(elasticlunr as any).clearStopWords();
929929
searchInstance = (elasticlunr as any).Index.load(searchJson);
930-
//
931930
hasher.initialized.add(parseHash);
932931
hasher.changed.add(parseHash);
933932
hasher.init();

src/file-manager/locale.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
"Filter-Empty": "No results found",
8181
"Filter-Key": "Try with different filter",
8282
"Sub-Folder-Error": "The destination folder is the subfolder of the source folder.",
83+
"Same-Folder-Error": "The destination folder is the same as the source folder.",
8384
"Access-Denied": "Access Denied",
8485
"Access-Details": "You don't have permission to access this folder.",
8586
"Header-Retry": "File Already Exists",
@@ -175,6 +176,7 @@
175176
"Filter-Empty": "keine Ergebnisse gefunden",
176177
"Filter-Key": "Versuchen Sie es mit einem anderen Filter",
177178
"Sub-Folder-Error": "Der Zielordner ist der Unterordner des Quellordners.",
179+
"Same-Folder-Error": "Der Zielordner ist derselbe wie der Quellordner.",
178180
"Access-Denied": "Zugriff verweigert",
179181
"Access-Details": "Sie haben keine Berechtigung, auf diesen Ordner zuzugreifen.",
180182
"Header-Retry": "Die Datei existiert bereits",
@@ -270,6 +272,7 @@
270272
"Filter-Empty": "Aucun résultat trouvé",
271273
"Filter-Key": "Essayez avec un filtre différent",
272274
"Sub-Folder-Error": "Le dossier de destination est le sous-dossier du dossier source.",
275+
"Same-Folder-Error": "Le dossier de destination est le même que le dossier source.",
273276
"Access-Denied": "Accès refusé",
274277
"Access-Details": "Vous n'avez pas la permission d'accéder à ce dossier.",
275278
"Header-Retry": "Le fichier existe déjà",
@@ -365,6 +368,7 @@
365368
"Filter-Empty": "لم يتم العثور على نتائج",
366369
"Filter-Key": "حاول مع مرشح مختلف",
367370
"Sub-Folder-Error": "المجلد الوجهة هو المجلد الفرعي للمجلد المصدر.",
371+
"Same-Folder-Error": "المجلد الوجهة هو نفس المجلد المصدر.",
368372
"Access-Denied": "تم الرفض",
369373
"Access-Details": "ليس لديك إذن للوصول إلى هذا المجلد.",
370374
"Header-Retry": "الملف موجود بالفعل",
@@ -460,6 +464,7 @@
460464
"Filter-Empty": "未找到結果",
461465
"Filter-Key": "嘗試使用其他過濾器",
462466
"Sub-Folder-Error": "目标文件夹是源文件夹的子文件夹。",
467+
"Same-Folder-Error": "目标文件夹与源文件夹相同。",
463468
"Access-Denied": "拒绝访问",
464469
"Access-Details": "您无权访问此文件夹。",
465470
"Header-Retry": "文件已存在",

src/tab/drag-and-drop.ts

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { loadCultureFiles } from '../common/culture-loader';
33
* Tab drag and drop sample
44
*/
55
import { Tab, DragEventArgs, TreeView, DragAndDropEventArgs, SelectEventArgs, TabItemModel } from '@syncfusion/ej2-navigations';
6-
import { isNullOrUndefined, createElement, Browser } from '@syncfusion/ej2-base';
6+
import { isNullOrUndefined, createElement } from '@syncfusion/ej2-base';
77
import { Chart, LineSeries, Category } from '@syncfusion/ej2-charts';
88
import { Schedule, Day, Week, WorkWeek, Month, Agenda } from '@syncfusion/ej2-schedule';
99
import { Grid } from '@syncfusion/ej2-grids';
@@ -110,8 +110,8 @@ function renderComponents(): void {
110110
let dropElement: HTMLElement = <HTMLElement>args.target.closest('#draggableTab .e-toolbar-item');
111111
if (dropElement != null) {
112112
let tabElement: HTMLElement = document.querySelector('#draggableTab');
113-
let itemPosition: number = (args.event.clientX < dropElement.getBoundingClientRect().left +
114-
dropElement.offsetWidth / 2) ? 0 : 1;
113+
let itemPosition: number = (((args.event.type.indexOf('touch') > -1) ? args.event.changedTouches[0].clientX
114+
: args.event.clientX) < dropElement.getBoundingClientRect().left + dropElement.offsetWidth / 2) ? 0 : 1;
115115
let dropItemIndex: number = [].slice.call(tabElement.querySelectorAll('.e-toolbar-item')).indexOf(dropElement) + itemPosition;
116116
let tabContent: HTMLElement;
117117
let content: string = '';
@@ -182,13 +182,8 @@ function renderComponents(): void {
182182
}];
183183
tabObj.addTab(newTabItem, dropItemIndex);
184184
treeViewObj.removeNodes([args.draggedNode]);
185-
args.cancel = true;
186-
} else {
187-
let dropNode: HTMLElement = <HTMLElement>args.target.closest('#ListView .e-list-item ');
188-
if (!isNullOrUndefined(dropNode) && args.dropIndicator === 'e-drop-in') {
189-
args.cancel = true;
190-
}
191185
}
186+
args.cancel = true;
192187
}
193188
function onNodeDrag(args: DragAndDropEventArgs): void {
194189
if (!isNullOrUndefined(args.target.closest('.tab-content'))) {
@@ -251,7 +246,6 @@ function renderChart(): void {
251246
primaryXAxis: {
252247
valueType: 'Category'
253248
},
254-
width: Browser.isDevice ? '100%' : '60%',
255249
series: [{
256250
dataSource: chartData,
257251
xName: 'month',

0 commit comments

Comments
 (0)