Skip to content

Commit a53ac8e

Browse files
committed
* Code optimization is done.
* OnBoarding MoverToNextPage method calling issue is fixed.
1 parent ca5ec45 commit a53ac8e

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

EssentialUIKit/Converters/IntToThicknessConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
2626
{
2727
int itemCount;
2828
int.TryParse(value.ToString(), out itemCount);
29-
if (itemCount == 0 && itemCount > 0)
29+
if (itemCount >= 0)
3030
return margin = new Thickness(0, -15, 0, 0);
3131
}
3232
return margin;

EssentialUIKit/Models/Ecommerce/Product.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public List<string> PreviewImages
6262
{
6363
for (var i = 0; i < previewImages.Count; i++)
6464
{
65-
previewImages[i] = !previewImages[i].Contains(App.BaseImageUrl) ? App.BaseImageUrl + previewImages[i] : previewImages[i];
65+
previewImages[i] = previewImages[i].Contains(App.BaseImageUrl) ? previewImages[i] : App.BaseImageUrl + previewImages[i];
6666
}
6767

6868
return previewImages;

EssentialUIKit/Models/Ecommerce/Review.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public List<string> Images
4242
{
4343
for (var i = 0; i < images.Count; i++)
4444
{
45-
images[i] = !images[i].Contains(App.BaseImageUrl) ? App.BaseImageUrl + images[i] : images[i];
45+
images[i] = images[i].Contains(App.BaseImageUrl) ? images[i] : App.BaseImageUrl + images[i];
4646
}
4747

4848
return images;

EssentialUIKit/ViewModels/OnBoarding/OnBoardingGradientViewModel.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,7 @@ private void Next(object obj)
204204
{
205205
if (ValidateAndUpdateSelectedIndex())
206206
{
207-
Application.Current.MainPage.Navigation.PopAsync();
208-
}
209-
else
210-
{
207+
Application.Current.MainPage.Navigation.PopAsync();
211208
MoveToNextPage();
212209
}
213210
}

0 commit comments

Comments
 (0)