Skip to content

Commit 8802715

Browse files
Merge pull request #253 from aruljenithberkmans/main
I249- Fix AreaSeries Y-Axis Rendering Issue in .NET MAUI Chart.
2 parents e636140 + 985f4f0 commit 8802715

File tree

6 files changed

+5
-15
lines changed

6 files changed

+5
-15
lines changed

maui/src/Charts/Segment/AreaSegment.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,6 @@ internal override void SetData(IList xValues, IList yValues)
184184

185185
var yMin = YValues.Min();
186186
yMin = double.IsNaN(yMin) ? YValues.Length > 0 ? YValues.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : yMin;
187-
var start = series.ActualYAxis.VisibleRange.Start;
188-
yMin = yMin == 0 ? (double.IsNaN(start) ? yMin : start) : yMin;
189187

190188
Empty = double.IsNaN(yMin);
191189

maui/src/Charts/Segment/PolarAreaSegment.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ internal override void SetData(IList xDatas, IList yDatas)
7575
yDatas.CopyTo(_yValues, 0);
7676
var yMin = _yValues.Min();
7777
yMin = double.IsNaN(yMin) ? _yValues.Length > 0 ? _yValues.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : yMin;
78-
var start = series.ActualYAxis.VisibleRange.Start;
79-
yMin = yMin == 0 ? (double.IsNaN(start) ? yMin : start) : yMin;
8078
series.XRange += new DoubleRange(_xValues.Min(), _xValues.Max());
8179
series.YRange += new DoubleRange(yMin, _yValues.Max());
8280
}

maui/src/Charts/Segment/SplineAreaSegment.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,6 @@ void UpdateRange()
137137
{
138138
_minY = YVal.Min();
139139
_minY = double.IsNaN(_minY) ? YVal.Length > 0 ? YVal.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : _minY;
140-
var start = series.ActualYAxis.VisibleRange.Start;
141-
_minY = _minY == 0 ? (double.IsNaN(start) ? _minY : start) : _minY;
142140
_maxY = YVal.Max();
143141

144142
double startControlMin = ControlStartY.Min();

maui/src/Charts/Segment/SplineRangeAreaSegment.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,6 @@ void UpdateRange()
266266
{
267267
_min = HighVal.Min();
268268
_min = double.IsNaN(_min) ? HighVal.Length > 0 ? HighVal.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : _min;
269-
var start = series.ActualYAxis.VisibleRange.Start;
270-
_min = _min == 0 ? (double.IsNaN(start) ? _min : start) : _min;
271269
_max = HighVal.Max();
272270

273271
if (HighControlStartY != null && HighControlEndY != null)

maui/src/Charts/Segment/StackingAreaSegment.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ internal void SetData(IList xValues, IList yEnds, IList yStarts)
4444

4545
var yMin = TopValues.Min();
4646
yMin = double.IsNaN(yMin) ? TopValues.Length > 0 ? TopValues.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : yMin;
47-
var start = series.ActualYAxis.VisibleRange.Start;
48-
yMin = yMin == 0 ? (double.IsNaN(start) ? yMin : start) : yMin;
4947

5048
Series.XRange += new DoubleRange(XValues.Min(), XValues.Max());
5149
Series.YRange += new DoubleRange(yMin, TopValues.Max());

maui/tests/Syncfusion.Maui.Toolkit.UnitTest/Chart/Features/ChartFeatureAxisUnitTest.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1534,7 +1534,7 @@ public void AddSmallTicksPoint_ShouldAddCorrectNumberOfSmallTicks()
15341534
}
15351535

15361536
[Theory]
1537-
[InlineData(0, 100, 1)]
1537+
[InlineData(0, 100, 20)]
15381538
[InlineData(0, 365, 2)]
15391539
public void CalculateNiceInterval_ShouldReturnCorrectInterval(double start, double end, double expectedInterval)
15401540
{
@@ -1604,7 +1604,7 @@ public void OnMinMaxChanged_ShouldUpdateActualRangeWithMinMaxValues_WhenMinMaxAr
16041604
[InlineData(DateTimeIntervalType.Years, 0.1)]
16051605
[InlineData(DateTimeIntervalType.Months, 1)]
16061606
[InlineData(DateTimeIntervalType.Days, 50)]
1607-
[InlineData(DateTimeIntervalType.Hours, 1000)]
1607+
[InlineData(DateTimeIntervalType.Hours, 500)]
16081608
[InlineData(DateTimeIntervalType.Minutes, 50000)]
16091609
[InlineData(DateTimeIntervalType.Seconds, 2000000)]
16101610
public void CalculateDateTimeIntervalType_ShouldReturnCorrectInterval_ForGivenIntervalType(DateTimeIntervalType intervalType, double expectedInterval)
@@ -2062,8 +2062,8 @@ public void CalculateActualRange_ReturnsExpectedRange(double defaultMin, double
20622062
}
20632063

20642064
[Theory]
2065-
[InlineData(double.NaN, 10)]
2066-
[InlineData(0, 10)]
2065+
[InlineData(double.NaN, 5)]
2066+
[InlineData(0, 5)]
20672067
[InlineData(5, 5)]
20682068
public void CalculateActualInterval_ReturnsExpectedInterval(double axisInterval, double expected)
20692069
{
@@ -2081,7 +2081,7 @@ public void CalculateActualInterval_ReturnsExpectedInterval(double axisInterval,
20812081
}
20822082

20832083
[Theory]
2084-
[InlineData(1, 10, 100, 10)]
2084+
[InlineData(1, 10, 100, 5)]
20852085
[InlineData(1, 1000, 100, 1000)]
20862086
[InlineData(1, 1000, 10, 1000)]
20872087
public void CalculateNiceInterval_ReturnsExpectedInterval(double rangeStart, double rangeEnd, int availableWidth, double expected)

0 commit comments

Comments
 (0)