Skip to content

Commit fe5edac

Browse files
committed
Added Comments for Popup not opening second time issue fix.
1 parent 160ca6b commit fe5edac

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

maui/src/Popup/SfPopup/SfPopup.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3155,7 +3155,11 @@ void SetParent()
31553155
{
31563156
_popupOverlayContainer.Parent = page;
31573157

3158-
// Due to framework change in 9.0.50, popupView visibility was becoming false while setting parent. Framework PR URL(https://github.com/dotnet/maui/pull/20154).
3158+
// The issue occurs due to framework changes in version 9.0.50 [https://github.com/dotnet/maui/pull/20154].
3159+
// We will set _popupOverlayContainer visibility to false after dismissing the popup.
3160+
// We will set _popupOverlayContainer as the parent to popupView on display.
3161+
// Due to the framework changes, the IsVisible property of _popupView is set to false when reopening with the same instance of the popup, since _popupOverlayContainer visibility will now be false.
3162+
// We will set the visibility of _popupOverlayContainer to true in a later section and _popupViewvisibility will still remains false.
31593163
_popupOverlayContainer.IsVisible = true;
31603164
_popupView.Parent = _popupOverlayContainer;
31613165
}

0 commit comments

Comments
 (0)