Fix crash when archive folder setting is cleared to null

The Setting model's getValueAttribute accessor requires a string, but
clearing the field in the admin UI saves null. Replaced (array) cast
of Settings (which triggers all accessors at once) with individual
property access wrapped in try/catch for the archive_folder setting.
Bump version to 2.2.3.

Author: damianharouff

README.md

@@ -9,6 +9,9 @@ The Abuse package retrieves abuse reports via IMAP from an email account and dis
 
 ## Changelog
 
+### v2.2.3
+- Fix crash when archive folder setting is cleared (null value triggers Setting accessor TypeError)
+
 ### v2.2.2
 - Add archive folder setting label and auto-detect description to admin UI
 

app/Email/EmailFetcher.php

@@ -55,32 +55,29 @@ private function connect() {
       return $this->connection;
     }
 
-    $settings = (array) app('Settings');
+    $s = app('Settings');
+
+    $host = (string) ($s->{'pkg.abuse.auth.host'} ?? '');
+    $user = (string) ($s->{'pkg.abuse.auth.user'} ?? '');
+    $pass = (string) ($s->{'pkg.abuse.auth.pass'} ?? '');
 
     // if any of the settings are empty then the Fetcher should do nothing.
-    if (
-      empty($settings['pkg.abuse.auth.host']) ||
-      empty($settings['pkg.abuse.auth.user']) ||
-      empty($settings['pkg.abuse.auth.pass'])
-    ) {
+    if (empty($host) || empty($user) || empty($pass)) {
       return;
     }
 
-    $server = new Server(
-      $settings['pkg.abuse.auth.host'],
-      '993',
-      '/imap/ssl/novalidate-cert'
-    );
-
-    $this->connection = $server->authenticate(
-      $settings['pkg.abuse.auth.user'],
-      $settings['pkg.abuse.auth.pass']
-    );
-
-    $this->archiveFolder = $this->resolveArchiveFolder(
-      $settings['pkg.abuse.auth.archive_folder'] ?? '',
-      $settings['pkg.abuse.auth.host'] ?? ''
-    );
+    $server = new Server($host, '993', '/imap/ssl/novalidate-cert');
+
+    $this->connection = $server->authenticate($user, $pass);
+
+    $archiveSetting = '';
+    try {
+      $archiveSetting = (string) ($s->{'pkg.abuse.auth.archive_folder'} ?? '');
+    } catch (\Throwable $exc) {
+      // Setting value is null — treat as empty for auto-detection.
+    }
+
+    $this->archiveFolder = $this->resolveArchiveFolder($archiveSetting, $host);
 
     return $this->connection;
   }

scp-package.json

@@ -3,11 +3,11 @@
     "slug": "abuse",
     "name": "Abuse Reports",
     "description": "The Abuse package retrieves abuse reports via IMAP from an email account and distributes the reports to the appropriate server tenants based on server IP. It adds a frontend to SynergyCP that allows Clients and Administrators to see and comment on reports.",
-    "semver": "2.2.2",
+    "semver": "2.2.3",
     "download_url": "https://distribution.synergycp.com/packages/synergycp/abuse/download.tar.gz",
     "release_date_unix": 1774699200,
     "changelog": [
-      "Add archive folder setting label and description to admin UI"
+      "Fix crash when archive folder setting is cleared to null"
     ]
   }
 }