chore: lint

Author: ovitrif

app/detekt-baseline.xml

@@ -33,10 +33,8 @@
     <ID>EnumNaming:BlocktankNotificationType.kt$BlocktankNotificationType$orderPaymentConfirmed</ID>
     <ID>EnumNaming:BlocktankNotificationType.kt$BlocktankNotificationType$wakeToTimeout</ID>
     <ID>ForbiddenComment:ActivityDetailScreen.kt$/* TODO: Implement assign functionality */</ID>
-    <ID>ForbiddenComment:ActivityRow.kt$// TODO: calculate confirmsIn text</ID>
     <ID>ForbiddenComment:BoostTransactionViewModel.kt$BoostTransactionUiState$// TODO: Implement dynamic time estimation</ID>
     <ID>ForbiddenComment:ContentView.kt$// TODO: display as sheet</ID>
-    <ID>ForbiddenComment:Env.kt$Env$// TODO: remove this to load from BT API instead</ID>
     <ID>ForbiddenComment:ExternalNodeViewModel.kt$ExternalNodeViewModel$// TODO: pass customFeeRate to ldk-node when supported</ID>
     <ID>ForbiddenComment:LightningConnectionsViewModel.kt$LightningConnectionsViewModel$// TODO: sort channels to get consistent index; node.listChannels returns a list in random order</ID>
     <ID>ForbiddenComment:LightningService.kt$LightningService$// TODO: cleanup sensitive data after implementing a `SecureString` value holder for Keychain return values</ID>
@@ -60,15 +58,12 @@
     <ID>LongParameterList:CoreService.kt$OnchainService$( mnemonicPhrase: String, derivationPathStr: String?, network: Network?, bip39Passphrase: String?, isChange: Boolean?, startIndex: UInt?, count: UInt?, )</ID>
     <ID>LongParameterList:WidgetsRepo.kt$WidgetsRepo$( @BgDispatcher private val bgDispatcher: CoroutineDispatcher, private val newsService: NewsService, private val factsService: FactsService, private val blocksService: BlocksService, private val weatherService: WeatherService, private val priceService: PriceService, private val widgetsStore: WidgetsStore, private val settingsStore: SettingsStore, )</ID>
     <ID>LoopWithTooManyJumpStatements:MonetaryVisualTransformation.kt$MonetaryVisualTransformation.&lt;no name provided&gt;$for</ID>
-    <ID>MagicNumber:ActivityDetailScreen.kt$40</ID>
-    <ID>MagicNumber:ActivityExploreScreen.kt$40</ID>
     <ID>MagicNumber:ActivityListViewModel.kt$ActivityListViewModel$300</ID>
     <ID>MagicNumber:AddressViewerScreen.kt$1500000L</ID>
     <ID>MagicNumber:AddressViewerScreen.kt$250000L</ID>
     <ID>MagicNumber:AddressViewerViewModel.kt$AddressViewerViewModel$300</ID>
     <ID>MagicNumber:AppStatus.kt$0.4f</ID>
     <ID>MagicNumber:ArticleModel.kt$24</ID>
-    <ID>MagicNumber:ArticleModel.kt$30</ID>
     <ID>MagicNumber:ArticleModel.kt$60</ID>
     <ID>MagicNumber:BackupNavSheetViewModel.kt$BackupNavSheetViewModel$200</ID>
     <ID>MagicNumber:ChannelDetailScreen.kt$1.5f</ID>
@@ -97,7 +92,6 @@
     <ID>MagicNumber:ShowMnemonicScreen.kt$12</ID>
     <ID>MagicNumber:ShowMnemonicScreen.kt$24</ID>
     <ID>MagicNumber:ShowMnemonicScreen.kt$300</ID>
-    <ID>MagicNumber:Slider.kt$20</ID>
     <ID>MagicNumber:SpendingConfirmScreen.kt$300</ID>
     <ID>MagicNumber:SwipeToConfirm.kt$1500</ID>
     <ID>MatchingDeclarationName:AddressType.kt$AddressTypeInfo</ID>
@@ -118,7 +112,6 @@
     <ID>MaxLineLength:HeadlineCard.kt$headline = "How Bitcoin changed El Salvador in more ways a big headline to test the text overflooooooow"</ID>
     <ID>MaxLineLength:LightningBalance.kt$is LightningBalance.ClaimableAwaitingConfirmations -&gt; "Claimable Awaiting Confirmations (Height: $confirmationHeight)"</ID>
     <ID>MaxLineLength:LightningConnectionsScreen.kt$if (showClosed) R.string.lightning__conn_closed_hide else R.string.lightning__conn_closed_show</ID>
-    <ID>MaxLineLength:LightningRepo.kt$LightningRepo$"Cannot execute $operationName: Node is ${_lightningState.value.nodeLifecycleState} and not starting"</ID>
     <ID>MaxLineLength:LightningRepo.kt$LightningRepo$"accelerateByCpfp error originalTxId: $originalTxId, satsPerVByte: $satsPerVByte destinationAddress: $destinationAddress"</ID>
     <ID>MaxLineLength:LightningRepo.kt$LightningRepo$"accelerateByCpfp success, newDestinationTxId: $newDestinationTxId originalTxId: $originalTxId, satsPerVByte: $satsPerVByte destinationAddress: $destinationAddress"</ID>
     <ID>MaxLineLength:LightningRepo.kt$LightningRepo$"bumpFeeByRbf success, replacementTxId: $replacementTxId originalTxId: $originalTxId, satsPerVByte: $satsPerVByte"</ID>
@@ -144,14 +137,11 @@
     <ID>MaximumLineLength:SettingsScreen.kt$ </ID>
     <ID>MaximumLineLength:WeatherService.kt$WeatherService$ </ID>
     <ID>MayBeConst:Env.kt$Env$val walletSyncIntervalSecs = 10_uL // TODO review</ID>
-    <ID>MayBeConst:Env.kt$Env.TransactionDefaults$/** * Minimum value in sats for an output. Outputs below the dust limit may not be processed because the fees * required to include them in a block would be greater than the value of the transaction itself. * */ val dustLimit = 546u</ID>
-    <ID>MayBeConst:Env.kt$Env.TransactionDefaults$/** Total recommended tx base fee in sats */ val recommendedBaseFee = 256u</ID>
     <ID>MemberNameEqualsClassName:Keychain.kt$Keychain$private val keychain = context.keychainDataStore</ID>
     <ID>NestedBlockDepth:Context.kt$fun Context.copyAssetToStorage(asset: String, dest: String)</ID>
     <ID>NestedBlockDepth:LogsRepo.kt$LogsRepo$private fun createZipBase64(logFiles: List&lt;LogFile&gt;): String</ID>
     <ID>NestedBlockDepth:MonetaryVisualTransformation.kt$MonetaryVisualTransformation$private fun createOffsetMapping(original: String, transformed: String): OffsetMapping</ID>
     <ID>NestedBlockDepth:ShopWebViewInterface.kt$ShopWebViewInterface$@JavascriptInterface fun postMessage(message: String)</ID>
-    <ID>NoUnusedImports:ActivityDetailScreen.kt$to.bitkit.ui.screens.wallets.activity.ActivityDetailScreen.kt</ID>
     <ID>NoWildcardImports:LightningChannel.kt$import androidx.compose.foundation.layout.*</ID>
     <ID>PrintStackTrace:ShareSheet.kt$e</ID>
     <ID>ReturnCount:AppViewModel.kt$AppViewModel$private suspend fun handleSanityChecks(amountSats: ULong)</ID>

app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@@ -119,26 +119,25 @@ class LightningRepo @Inject constructor(
     ): Result<T> = withContext(bgDispatcher) {
         Logger.verbose("Operation called: $operationName", context = TAG)
 
-        if (_lightningState.value.nodeLifecycleState.isRunning()) {
+        val nodeLifecycleState = _lightningState.value.nodeLifecycleState
+        if (nodeLifecycleState.isRunning()) {
             return@withContext executeOperation(operationName, operation)
         }
 
         // If node is not in a state that can become running, fail fast
-        if (!_lightningState.value.nodeLifecycleState.canRun()) {
+        if (!nodeLifecycleState.canRun()) {
             return@withContext Result.failure(
-                Exception(
-                    "Cannot execute '$operationName': Node is ${_lightningState.value.nodeLifecycleState} and not starting"
-                )
+                Exception("Cannot execute '$operationName': node is '$nodeLifecycleState' and not starting")
             )
         }
 
         val nodeRunning = withTimeoutOrNull(waitTimeout) {
-            if (_lightningState.value.nodeLifecycleState.isRunning()) {
+            if (nodeLifecycleState.isRunning()) {
                 return@withTimeoutOrNull true
             }
 
             // Otherwise, wait for it to transition to running state
-            Logger.verbose("Waiting for node runs to execute '$operationName'", context = TAG)
+            Logger.verbose("Waiting for node to run before executing '$operationName'", context = TAG)
             _lightningState.first { it.nodeLifecycleState.isRunning() }
             Logger.debug("Operation executed: '$operationName'", context = TAG)
             true