test: fix syncActivities success flow test

Author: ovitrif

app/src/test/java/to/bitkit/repositories/ActivityRepoTest.kt

@@ -12,7 +12,6 @@ import org.junit.Test
 import org.lightningdevkit.ldknode.PaymentDetails
 import org.mockito.kotlin.any
 import org.mockito.kotlin.doReturn
-import org.mockito.kotlin.eq
 import org.mockito.kotlin.mock
 import org.mockito.kotlin.never
 import org.mockito.kotlin.verify
@@ -32,12 +31,13 @@ import kotlin.test.assertTrue
 
 class ActivityRepoTest : BaseUnitTest() {
 
-    private val coreService: CoreService = mock()
-    private val lightningRepo: LightningRepo = mock()
-    private val cacheStore: CacheStore = mock()
-    private val addressChecker: AddressChecker = mock()
-    private val db: AppDb = mock()
-    private val clock: Clock = mock()
+    private val coreService = mock<CoreService>()
+    private val lightningRepo = mock<LightningRepo>()
+    private val transferRepo = mock<TransferRepo>()
+    private val cacheStore = mock<CacheStore>()
+    private val addressChecker = mock<AddressChecker>()
+    private val db = mock<AppDb>()
+    private val clock = mock<Clock>()
 
     private lateinit var sut: ActivityRepo
 
@@ -66,7 +66,7 @@ class ActivityRepoTest : BaseUnitTest() {
             cacheStore = cacheStore,
             addressChecker = addressChecker,
             db = db,
-            transferRepo = mock(),
+            transferRepo = transferRepo,
             clock = clock,
         )
     }
@@ -76,13 +76,15 @@ class ActivityRepoTest : BaseUnitTest() {
         val payments = listOf(testPaymentDetails)
         wheneverBlocking { lightningRepo.getPayments() }.thenReturn(Result.success(payments))
         wheneverBlocking { coreService.activity.getActivity(any()) }.thenReturn(null)
-        wheneverBlocking { coreService.activity.syncLdkNodePaymentsToActivities(any(), eq(false)) }.thenReturn(Unit)
+        wheneverBlocking { coreService.activity.syncLdkNodePaymentsToActivities(payments) }.thenReturn(Unit)
+        wheneverBlocking { transferRepo.syncTransferStates() }.thenReturn(Result.success(Unit))
+        wheneverBlocking { coreService.activity.allPossibleTags() }.thenReturn(emptyList())
 
         val result = sut.syncActivities()
 
         assertTrue(result.isSuccess)
         verify(lightningRepo).getPayments()
-        verify(coreService.activity).syncLdkNodePaymentsToActivities(payments, forceUpdate = false)
+        verify(coreService.activity).syncLdkNodePaymentsToActivities(payments)
         assertFalse(sut.isSyncingLdkNodePayments.value)
     }
 

app/src/test/java/to/bitkit/usecases/WipeWalletUseCaseTest.kt

@@ -21,8 +21,6 @@ import kotlin.test.assertTrue
 
 class WipeWalletUseCaseTest : BaseUnitTest() {
 
-    private lateinit var sut: WipeWalletUseCase
-
     private val backupRepo = mock<BackupRepo>()
     private val keychain = mock<Keychain>()
     private val coreService = mock<CoreService>()
@@ -33,6 +31,8 @@ class WipeWalletUseCaseTest : BaseUnitTest() {
     private val activityRepo = mock<ActivityRepo>()
     private val lightningRepo = mock<LightningRepo>()
 
+    private lateinit var sut: WipeWalletUseCase
+
     private var onWipeCalled = false
     private var onSetWalletExistsStateCalled = false
 

app/src/test/java/to/bitkit/viewmodels/RestoreWalletViewModelTest.kt

@@ -17,10 +17,10 @@ import kotlin.test.assertTrue
 @OptIn(ExperimentalCoroutinesApi::class)
 class RestoreWalletViewModelTest : BaseUnitTest() {
 
-    private lateinit var viewModel: RestoreWalletViewModel
-
     private val bip39Service = mock<Bip39Service>()
 
+    private lateinit var viewModel: RestoreWalletViewModel
+
     @Before
     fun setup() = runBlocking {
         whenever(bip39Service.isValidWord(any())).thenReturn(true)