refactor: Avoid unneeded currency conversion in money components

Author: ovitrif

app/src/main/java/to/bitkit/ui/components/Money.kt

@@ -1,6 +1,7 @@
 package to.bitkit.ui.components
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.remember
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.platform.LocalInspectionMode
@@ -17,74 +18,77 @@ fun MoneyDisplay(
     sats: Long,
     onClick: (() -> Unit)? = null,
 ) {
-    val isPreview = LocalInspectionMode.current
-    if (isPreview) {
-        val displayText = "<accent>₿</accent> ${sats.formatToModernDisplay()}"
-        Display(text = displayText.withAccent(accentColor = Colors.White64))
-        return
-    }
-
-    val currency = currencyViewModel ?: return
-    val currencies = LocalCurrencies.current
-
-    currency.convert(sats)?.let { converted ->
-        val displayText = if (currencies.primaryDisplay == PrimaryDisplay.BITCOIN) {
-            val btcComponents = converted.bitcoinDisplay(currencies.displayUnit)
-            "<accent>${btcComponents.symbol}</accent> ${btcComponents.value}"
-        } else {
-            "<accent>${converted.symbol}</accent> ${converted.formatted}"
-        }
-
+    rememberMoneyText(sats)?.let { text ->
         Display(
-            text = displayText.withAccent(accentColor = Colors.White64),
+            text = text.withAccent(accentColor = Colors.White64),
             modifier = Modifier.clickableAlpha(onClick = onClick)
         )
     }
 }
 
 @Composable
 fun MoneySSB(sats: Long) {
+    rememberMoneyText(sats)?.let { text ->
+        BodySSB(text = text.withAccent(accentColor = Colors.White64))
+    }
+}
+
+@Composable
+fun MoneyCaptionB(
+    sats: Long,
+    color: Color,
+) {
     val isPreview = LocalInspectionMode.current
     if (isPreview) {
-        val displayText = "<accent>₿</accent> ${sats.formatToModernDisplay()}"
-        BodySSB(text = displayText.withAccent(accentColor = Colors.White64))
+        CaptionB(text = sats.formatToModernDisplay(), color = color)
         return
     }
 
     val currency = currencyViewModel ?: return
     val currencies = LocalCurrencies.current
 
-    currency.convert(sats)?.let { converted ->
-        val displayText = if (currencies.primaryDisplay == PrimaryDisplay.BITCOIN) {
+    val displayText = remember(currencies, sats) {
+        currency.convert(sats)?.let { converted ->
             val btcComponents = converted.bitcoinDisplay(currencies.displayUnit)
-            "<accent>${btcComponents.symbol}</accent> ${btcComponents.value}"
-        } else {
-            "<accent>${converted.symbol}</accent> ${converted.formatted}"
+            btcComponents.value
         }
+    }
 
-        BodySSB(text = displayText.withAccent(accentColor = Colors.White64))
+    displayText?.let { text ->
+        CaptionB(
+            text = text,
+            color = color,
+        )
     }
 }
 
+/**
+ * Generates a formatted representation of a monetary value based on the provided amount in satoshis
+ * and the current currency display settings. Can be either in bitcoin or fiat.
+ *
+ * @param sats The amount in satoshis to be formatted and displayed.
+ * @return A formatted string representation of the monetary value, or null if it cannot be generated.
+ */
 @Composable
-fun MoneyCaptionB(
+fun rememberMoneyText(
     sats: Long,
-    color: Color,
-) {
+): String? {
     val isPreview = LocalInspectionMode.current
     if (isPreview) {
-        CaptionB(text = sats.formatToModernDisplay(), color = color)
-        return
+        return "<accent>₿</accent> ${sats.formatToModernDisplay()}"
     }
 
-    val currency = currencyViewModel ?: return
+    val currency = currencyViewModel ?: return null
     val currencies = LocalCurrencies.current
 
-    currency.convert(sats)?.let { converted ->
-        val btcComponents = converted.bitcoinDisplay(currencies.displayUnit)
-        CaptionB(
-            text = btcComponents.value,
-            color = color,
-        )
+    return remember(currencies, sats) {
+        val converted = currency.convert(sats) ?: return@remember null
+
+        if (currencies.primaryDisplay == PrimaryDisplay.BITCOIN) {
+            val btcComponents = converted.bitcoinDisplay(currencies.displayUnit)
+            "<accent>${btcComponents.symbol}</accent> ${btcComponents.value}"
+        } else {
+            "<accent>${converted.symbol}</accent> ${converted.formatted}"
+        }
     }
 }