chore(lint): loosen MagicNumber checks

Author: ovitrif

app/src/main/java/to/bitkit/ui/screens/transfer/SpendingAmountScreen.kt

@@ -99,9 +99,9 @@ fun SpendingAmountScreen(
                         .replace("{amount}", "$max"),
                 )
             }
-            val quarterAmount = min(quarter, max)
-            viewModel.updateLimits(quarterAmount)
-            amountInputViewModel.setSats(quarterAmount, currencies)
+            val cappedQuarter = min(quarter, max)
+            viewModel.updateLimits(cappedQuarter)
+            amountInputViewModel.setSats(cappedQuarter, currencies)
         },
         onClickMaxAmount = {
             val newAmountSats = uiState.maxAllowedToSend
@@ -165,7 +165,6 @@ private fun SpendingAmountNodeRunning(
         modifier = Modifier
             .padding(horizontal = 16.dp)
             .fillMaxSize()
-            .imePadding()
             .testTag("SpendingAmount")
     ) {
         val amountUiState by amountInputViewModel.uiState.collectAsStateWithLifecycle()
@@ -225,15 +224,11 @@ private fun SpendingAmountNodeRunning(
                 modifier = Modifier.testTag("SpendingAmountMax")
             )
         }
-        HorizontalDivider()
 
+        HorizontalDivider()
         VerticalSpacer(16.dp)
-        NumberPad(
-            viewModel = amountInputViewModel,
-            modifier = Modifier.fillMaxWidth()
-        )
 
-        VerticalSpacer(8.dp)
+        NumberPad(viewModel = amountInputViewModel)
 
         PrimaryButton(
             text = stringResource(R.string.common__continue),
@@ -247,13 +242,13 @@ private fun SpendingAmountNodeRunning(
     }
 }
 
-@Preview(showBackground = true)
+@Preview(showSystemUi = true)
 @Composable
 private fun Preview() {
     AppThemeSurface {
         Content(
             isNodeRunning = true,
-            uiState = TransferToSpendingUiState(),
+            uiState = TransferToSpendingUiState(maxAllowedToSend = 158_234, balanceAfterFee = 158_234),
             amountInputViewModel = previewAmountInputViewModel(),
             currencies = CurrencyState(),
             onBackClick = {},
@@ -265,13 +260,13 @@ private fun Preview() {
     }
 }
 
-@Preview(showBackground = true, device = NEXUS_5)
+@Preview(showSystemUi = true, device = NEXUS_5)
 @Composable
 private fun PreviewSmall() {
     AppThemeSurface {
         Content(
             isNodeRunning = true,
-            uiState = TransferToSpendingUiState(),
+            uiState = TransferToSpendingUiState(maxAllowedToSend = 158_234, balanceAfterFee = 158_234),
             amountInputViewModel = previewAmountInputViewModel(),
             currencies = CurrencyState(),
             onBackClick = {},
@@ -283,7 +278,7 @@ private fun PreviewSmall() {
     }
 }
 
-@Preview(showBackground = true, device = NEXUS_5)
+@Preview(showSystemUi = true, device = NEXUS_5)
 @Composable
 private fun PreviewInitializing() {
     AppThemeSurface {

app/src/main/java/to/bitkit/viewmodels/TransferViewModel.kt

@@ -49,7 +49,6 @@ import kotlin.time.Duration.Companion.seconds
 const val RETRY_INTERVAL_MS = 1 * 60 * 1000L // 1 minutes in ms
 const val GIVE_UP_MS = 30 * 60 * 1000L // 30 minutes in ms
 private const val EUR_CURRENCY = "EUR"
-private const val QUARTER = 0.25
 
 @HiltViewModel
 class TransferViewModel @Inject constructor(
@@ -494,7 +493,7 @@ data class TransferToSpendingUiState(
     val balanceAfterFee: Long = 0,
     val isLoading: Boolean = false,
 ) {
-    fun balanceAfterFeeQuarter() = (balanceAfterFee.toDouble() * QUARTER).roundToLong()
+    fun balanceAfterFeeQuarter() = (balanceAfterFee.toDouble() * 0.25).roundToLong()
 }
 
 data class TransferValues(

config/detekt/detekt.yml

@@ -631,14 +631,16 @@ style:
     ignoreNumbers:
       - '-1'
       - '0'
+      - '0.25'
+      - '0.5'
       - '1'
       - '2'
     ignoreHashCodeFunction: true
     ignorePropertyDeclaration: true
-    ignoreLocalVariableDeclaration: false
+    ignoreLocalVariableDeclaration: true
     ignoreConstantDeclaration: true
     ignoreCompanionObjectPropertyDeclaration: true
-    ignoreAnnotation: false
+    ignoreAnnotation: true
     ignoreNamedArgument: true
     ignoreEnums: true
     ignoreRanges: true