refactor: call addTagsToTransaction

Author: jvsena42

app/src/main/java/to/bitkit/repositories/ActivityRepo.kt

@@ -451,7 +451,7 @@ class ActivityRepo @Inject constructor(
     suspend fun addTagsToTransaction(
         paymentHashOrTxId: String,
         type: ActivityFilter,
-        txType: PaymentType,
+        txType: PaymentType?,
         tags: List<String>,
     ): Result<Unit> = withContext(bgDispatcher) {
         if (tags.isEmpty()) return@withContext Result.failure(IllegalArgumentException("No tags selected"))
@@ -460,7 +460,7 @@ class ActivityRepo @Inject constructor(
             type = type,
             txType = txType
         ).onSuccess { activity ->
-            return@withContext addTagsToActivity(activity.rawId(), tags = tags)
+            addTagsToActivity(activity.rawId(), tags = tags)
         }.onFailure { e ->
             return@withContext Result.failure(e)
         }.map { Unit }

app/src/main/java/to/bitkit/viewmodels/ActivityListViewModel.kt

@@ -15,7 +15,6 @@ import kotlinx.coroutines.flow.debounce
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 import to.bitkit.di.BgDispatcher
-import to.bitkit.ext.rawId
 import to.bitkit.repositories.ActivityRepo
 import to.bitkit.repositories.WalletRepo
 import to.bitkit.services.CoreService
@@ -250,17 +249,13 @@ class ActivityListViewModel @Inject constructor(
         viewModelScope.launch {
             walletRepo.getAllInvoiceTags().onSuccess { invoiceTags ->
                 invoiceTags.forEach { tagEntity ->
-                    activityRepo.findActivityByPaymentId(
+                    activityRepo.addTagsToTransaction(
                         paymentHashOrTxId = tagEntity.paymentHash,
                         type = ActivityFilter.ALL,
-                        txType = null
-                    ).onSuccess { activity ->
-                        activityRepo.addTagsToActivity(
-                            activityId = activity.rawId(),
-                            tags = tagEntity.tags
-                        ).onSuccess {
-                            walletRepo.deleteInvoice(tagEntity.paymentHash)
-                        }
+                        txType = null,
+                        tags = tagEntity.tags
+                    ).onSuccess {
+                        walletRepo.deleteInvoice(tagEntity.paymentHash)
                     }
                 }
             }