Skip to content

Commit 563ec07

Browse files
committed
fix: use core service instance instead of calling high-level function
1 parent 07931ba commit 563ec07

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

app/src/main/java/to/bitkit/repositories/ActivityRepo.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import com.synonym.bitkitcore.Activity.Onchain
55
import com.synonym.bitkitcore.ActivityFilter
66
import com.synonym.bitkitcore.PaymentType
77
import com.synonym.bitkitcore.SortDirection
8-
import com.synonym.bitkitcore.getTags
98
import kotlinx.coroutines.CoroutineDispatcher
109
import kotlinx.coroutines.TimeoutCancellationException
1110
import kotlinx.coroutines.async
@@ -248,7 +247,7 @@ class ActivityRepo @Inject constructor(
248247
context = TAG
249248
)
250249

251-
val tags = getTags(activityIdToDelete)
250+
val tags = coreService.activity.tags(activityIdToDelete)
252251
addTagsToActivity(activityId = id, tags = tags)
253252

254253
deleteActivity(activityIdToDelete).onFailure { e ->

app/src/test/java/to/bitkit/repositories/ActivityRepoTest.kt

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,27 @@ class ActivityRepoTest : BaseUnitTest() {
228228
verify(coreService.activity).update(activityId, testActivity)
229229
}
230230

231+
@Test
232+
fun `replaceActivity updates and deletes successfully`() = test {
233+
val activityId = "activity123"
234+
val activityToDeleteId = "activity456"
235+
val tagsMock = listOf("tag1", "tag2")
236+
val cacheData = AppCacheData(deletedActivities = emptyList())
237+
whenever(cacheStore.data).thenReturn(flowOf(cacheData))
238+
239+
wheneverBlocking { coreService.activity.update(activityId, testActivity) }.thenReturn(Unit)
240+
wheneverBlocking { coreService.activity.delete(activityToDeleteId) }.thenReturn(true)
241+
wheneverBlocking { cacheStore.addActivityToDeletedList(activityToDeleteId) }.thenReturn(Unit)
242+
243+
whenever(coreService.activity.tags(activityId)).thenAnswer { tagsMock }
244+
245+
val result = sut.replaceActivity(activityId, activityToDeleteId, testActivity)
246+
247+
assertTrue(result.isSuccess)
248+
verify(coreService.activity).update(activityId, testActivity)
249+
verify(coreService.activity).delete(activityToDeleteId)
250+
}
251+
231252
@Test
232253
fun `deleteActivity deletes successfully`() = test {
233254
val activityId = "activity123"

0 commit comments

Comments
 (0)