refactor: replace hasChannelsReady with canReceive

Author: ovitrif

app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@@ -708,10 +708,9 @@ class LightningRepo @Inject constructor(
     fun getChannels(): List<ChannelDetails>? =
         if (_lightningState.value.nodeLifecycleState.isRunning()) lightningService.channels else null
 
-    fun hasChannelsReady(): Boolean {
+    fun canReceive(): Boolean {
         val isRunning = _lightningState.value.nodeLifecycleState.isRunning()
-        val hasChannelsReady = lightningService.channels?.any { it.isChannelReady } == true
-        return isRunning && hasChannelsReady
+        return isRunning && lightningService.canReceive()
     }
 
     suspend fun registerForNotifications(token: String? = null) = executeWhenNodeRunning("registerForNotifications") {

app/src/main/java/to/bitkit/repositories/WalletRepo.kt

@@ -382,8 +382,8 @@ class WalletRepo @Inject constructor(
             updateBip21AmountSats(amountSats)
             updateBip21Description(description)
 
-            val hasChannelsReady = lightningRepo.hasChannelsReady()
-            if (hasChannelsReady && _walletState.value.receiveOnSpendingBalance) {
+            val canReceive = lightningRepo.canReceive()
+            if (canReceive && _walletState.value.receiveOnSpendingBalance) {
                 lightningRepo.createInvoice(
                     amountSats = _walletState.value.bip21AmountSats,
                     description = _walletState.value.bip21Description,

app/src/test/java/to/bitkit/repositories/LightningRepoTest.kt

@@ -254,25 +254,24 @@ class LightningRepoTest : BaseUnitTest() {
     }
 
     @Test
-    fun `hasChannelsReady should return false when node is not running`() = test {
-        assertFalse(sut.hasChannelsReady())
+    fun `canReceive should return false when node is not running`() = test {
+        assertFalse(sut.canReceive())
     }
 
     @Test
-    fun `hasChannelsReady should return false when having non-ready channels`() = test {
+    fun `canReceive should return false when node is running but cannot receive`() = test {
         startNodeForTesting()
-        whenever(lightningService.channels).thenReturn(listOf(mock()))
+        whenever(lightningService.canReceive()).thenReturn(false)
 
-        assertFalse(sut.hasChannelsReady())
+        assertFalse(sut.canReceive())
     }
 
     @Test
-    fun `hasChannelsReady should return true when having channels ready`() = test {
+    fun `canReceive should return true when node can receive`() = test {
         startNodeForTesting()
-        val channelReady = mock<ChannelDetails> { on { isChannelReady } doReturn true }
-        whenever(lightningService.channels).thenReturn(listOf(channelReady))
+        whenever(lightningService.canReceive()).thenReturn(true)
 
-        assertTrue(sut.hasChannelsReady())
+        assertTrue(sut.canReceive())
     }
 
     @Test

app/src/test/java/to/bitkit/repositories/WalletRepoTest.kt

@@ -258,9 +258,9 @@ class WalletRepoTest : BaseUnitTest() {
     }
 
     @Test
-    fun `updateBip21Invoice should create bolt11 when having channels ready`() = test {
+    fun `updateBip21Invoice should create bolt11 when node can receive`() = test {
         val testInvoice = "testInvoice"
-        whenever(lightningRepo.hasChannelsReady()).thenReturn(true)
+        whenever(lightningRepo.canReceive()).thenReturn(true)
         whenever(lightningRepo.createInvoice(anyOrNull(), any(), any())).thenReturn(Result.success(testInvoice))
 
         sut.updateBip21Invoice(amountSats = 1000uL, description = "test").let { result ->
@@ -270,8 +270,7 @@ class WalletRepoTest : BaseUnitTest() {
     }
 
     @Test
-    fun `updateBip21Invoice should not create bolt11 when no channels exist`() = test {
-        whenever(lightningRepo.hasChannelsReady()).thenReturn(false)
+    fun `updateBip21Invoice should not create bolt11 when node cannot receive`() = test {
         sut.updateBip21Invoice(amountSats = 1000uL, description = "test").let { result ->
             assertTrue(result.isSuccess)
             assertEquals("", sut.walletState.value.bolt11)
@@ -282,7 +281,6 @@ class WalletRepoTest : BaseUnitTest() {
     fun `updateBip21Invoice should build correct BIP21 URL`() = test {
         val testAddress = "testAddress"
         whenever(cacheStore.data).thenReturn(flowOf(AppCacheData(onchainAddress = testAddress)))
-        whenever(lightningRepo.hasChannelsReady()).thenReturn(false)
         whenever(lightningRepo.createInvoice(anyOrNull(), any(), any())).thenReturn(Result.success("testInvoice"))
         sut = createSut()