refactor: remove duration

Author: jvsena42

app/src/main/java/to/bitkit/models/Suggestion.kt

@@ -5,24 +5,22 @@ import androidx.annotation.StringRes
 import androidx.compose.ui.graphics.Color
 import to.bitkit.R
 import to.bitkit.ui.theme.Colors
-import kotlin.time.Duration
-import kotlin.time.Duration.Companion.seconds
 
 enum class Suggestion(
     @StringRes val title: Int,
     @StringRes val description: Int,
     @DrawableRes val icon: Int,
     val color: Color,
     val dismissible: Boolean = true,
-    val duration: Duration? = null,
 ) {
     BUY(
         title = R.string.cards__buyBitcoin__title,
         description = R.string.cards__buyBitcoin__description,
         color = Colors.Brand24,
         icon = R.drawable.b_emboss,
     ),
-    LIGHTNING( // Lightning ready from RN
+    LIGHTNING(
+        // Lightning ready from RN
         title = R.string.cards__lightning__title,
         description = R.string.cards__lightning__description,
         color = Colors.Purple24,
@@ -103,7 +101,6 @@ enum class Suggestion(
         color = Colors.Purple24,
         icon = R.drawable.transfer,
         dismissible = false,
-        duration = 5.seconds
     ),
 }
 

app/src/main/java/to/bitkit/repositories/ActivityRepo.kt

@@ -325,10 +325,13 @@ class ActivityRepo @Inject constructor(
         cacheStore.data.first().inProgressTransfers.forEach { transfer ->
             getActivity(transfer.activityId).onSuccess { activity ->
                 (activity as? Onchain)?.let { onChain ->
+                    Logger.debug("Transfer found! confirmed:${onChain.v1.confirmed} $onChain", context = TAG)
                     if (onChain.v1.confirmed) {
                         cacheStore.removeInProgressTransfer(transfer)
                     }
                 }
+            }.onFailure { e ->
+                Logger.debug("Couldn't find activity ${transfer.activityId}, ${e.stackTraceToString()}", context = TAG)
             }
         }
     }

app/src/main/java/to/bitkit/ui/components/SuggestionCard.kt

@@ -23,7 +23,6 @@ import androidx.compose.material3.Icon
 import androidx.compose.material3.IconButton
 import androidx.compose.material3.ShapeDefaults
 import androidx.compose.runtime.Composable
-import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
@@ -35,15 +34,12 @@ import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.AnnotatedString
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
-import kotlinx.coroutines.delay
 import to.bitkit.R
 import to.bitkit.models.Suggestion
 import to.bitkit.ui.shared.util.clickableAlpha
 import to.bitkit.ui.shared.util.gradientLinearBackground
 import to.bitkit.ui.shared.util.gradientRadialBackground
 import to.bitkit.ui.theme.Colors
-import kotlin.time.Duration
-import kotlin.time.Duration.Companion.seconds
 
 private const val GLOW_ANIMATION_MILLIS = 1100
 private const val MIN_ALPHA_GRADIENT = 0.24f
@@ -57,19 +53,11 @@ fun SuggestionCard(
     description: String,
     @DrawableRes icon: Int,
     onClose: (() -> Unit)? = null,
-    duration: Duration? = null,
     size: Int = 152,
     disableGlow: Boolean = false,
     captionColor: Color = Colors.White64,
     onClick: () -> Unit,
 ) {
-    LaunchedEffect(Unit) {
-        duration?.let {
-            delay(it)
-            onClose?.invoke()
-        }
-    }
-
     val isDismissible = onClose != null
 
     // Glow animation for non-dismissible cards
@@ -138,7 +126,7 @@ fun SuggestionCard(
                     modifier = Modifier.weight(1f)
                 )
 
-                if (duration == null && onClose != null) {
+                if (onClose != null) {
                     IconButton(
                         onClick = onClose,
                         modifier = Modifier
@@ -184,7 +172,6 @@ private fun Preview() {
                 icon = item.icon,
                 onClose = {},
                 onClick = {}, // All cards are clickable
-                duration = 5.seconds.takeIf { item == Suggestion.LIGHTNING_READY }
             )
         }
     }

app/src/main/java/to/bitkit/ui/screens/wallets/HomeScreen.kt

@@ -390,7 +390,6 @@ private fun Content(
                                         icon = item.icon,
                                         onClose = { onRemoveSuggestion(item) }.takeIf { item.dismissible },
                                         onClick = { onClickSuggestion(item) },
-                                        duration = item.duration,
                                         modifier = Modifier.testTag("Suggestion-${item.name.lowercase()}")
                                     )
                                 }