Skip to content

Commit 739bbd3

Browse files
committed
chore: update ldk-node to v0.7.0-rc.1
1 parent d70150e commit 739bbd3

File tree

2 files changed

+14
-26
lines changed

2 files changed

+14
-26
lines changed

app/src/main/java/to/bitkit/services/LightningService.kt

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import org.lightningdevkit.ldknode.ElectrumSyncConfig
2424
import org.lightningdevkit.ldknode.Event
2525
import org.lightningdevkit.ldknode.FeeRate
2626
import org.lightningdevkit.ldknode.Node
27-
import org.lightningdevkit.ldknode.NodeEntropy
2827
import org.lightningdevkit.ldknode.NodeException
2928
import org.lightningdevkit.ldknode.NodeStatus
3029
import org.lightningdevkit.ldknode.PaymentDetails
@@ -118,43 +117,32 @@ class LightningService @Inject constructor(
118117
customRgsServerUrl: String?,
119118
config: Config,
120119
): Node = ServiceQueue.LDK.background {
121-
val nodeEntropy = NodeEntropy.fromBip39Mnemonic(
122-
mnemonic = keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name) ?: throw ServiceError.MnemonicNotFound,
123-
passphrase = keychain.loadString(Keychain.Key.BIP39_PASSPHRASE.name),
124-
)
125-
126120
val builder = Builder.fromConfig(config).apply {
127121
setCustomLogger(LdkLogWriter())
128122
configureChainSource(customServerUrl)
129123
configureGossipSource(customRgsServerUrl)
124+
setEntropyBip39Mnemonic(
125+
mnemonic = keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name) ?: throw ServiceError.MnemonicNotFound,
126+
passphrase = keychain.loadString(Keychain.Key.BIP39_PASSPHRASE.name),
127+
)
130128
}
131129
try {
132130
val vssStoreId = vssStoreIdProvider.getVssStoreId(walletIndex)
133-
val lnurlAuthServerUrl = Env.lnurlAuthServerUrl
134131
val vssUrl = Env.vssServerUrl
135-
Logger.verbose("Building ldk-node with vssUrl: '$vssUrl'")
136-
Logger.verbose("Building ldk-node with lnurlAuthServerUrl: '$lnurlAuthServerUrl'")
132+
val lnurlAuthServerUrl = Env.lnurlAuthServerUrl
133+
val fixedHeaders = emptyMap<String, String>()
134+
Logger.verbose(
135+
"Building ldk-node with \n\t vssUrl: '$vssUrl'\n\t lnurlAuthServerUrl: '$lnurlAuthServerUrl'"
136+
)
137137
if (lnurlAuthServerUrl.isNotEmpty()) {
138-
builder.buildWithVssStore(
139-
vssUrl = vssUrl,
140-
storeId = vssStoreId,
141-
lnurlAuthServerUrl = lnurlAuthServerUrl,
142-
fixedHeaders = emptyMap(),
143-
nodeEntropy = nodeEntropy,
144-
)
138+
builder.buildWithVssStore(vssUrl, vssStoreId, lnurlAuthServerUrl, fixedHeaders)
145139
} else {
146-
builder.buildWithVssStoreAndFixedHeaders(
147-
vssUrl = vssUrl,
148-
storeId = vssStoreId,
149-
fixedHeaders = emptyMap(),
150-
nodeEntropy = nodeEntropy,
151-
)
140+
builder.buildWithVssStoreAndFixedHeaders(vssUrl, vssStoreId, fixedHeaders)
152141
}
153142
} catch (e: BuildException) {
154143
throw LdkError(e)
155144
} finally {
156-
// cleanup sensitive data
157-
nodeEntropy.destroy()
145+
// TODO: cleanup sensitive data after implementing a `SecureString` value holder for Keychain return values
158146
}
159147
}
160148

gradle/libs.versions.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ ktor-client-logging = { module = "io.ktor:ktor-client-logging", version.ref = "k
5858
ktor-client-okhttp = { module = "io.ktor:ktor-client-okhttp", version.ref = "ktor" }
5959
ktor-serialization-kotlinx-json = { module = "io.ktor:ktor-serialization-kotlinx-json", version.ref = "ktor" }
6060
#ldk-node-android = { module = "org.lightningdevkit:ldk-node-android", version = "0.7.0" } # upstream
61-
#ldk-node-android = { module = "org.lightningdevkit:ldk-node-android", version = "0.7.0" } # local
62-
ldk-node-android = { module = "com.github.synonymdev:ldk-node", version = "v0.7.0" } # fork
61+
#ldk-node-android = { module = "org.lightningdevkit:ldk-node-android", version = "0.7.0-rc.1" } # local
62+
ldk-node-android = { module = "com.github.synonymdev:ldk-node", version = "v0.7.0-rc.1" } # fork
6363
lifecycle-process = { group = "androidx.lifecycle", name = "lifecycle-process", version.ref = "lifecycle" }
6464
lifecycle-runtime-compose = { module = "androidx.lifecycle:lifecycle-runtime-compose", version.ref = "lifecycle" }
6565
lifecycle-runtime-ktx = { module = "androidx.lifecycle:lifecycle-runtime-ktx", version.ref = "lifecycle" }

0 commit comments

Comments
 (0)