chore: review & lint

Author: ovitrif

app/src/main/java/to/bitkit/env/Env.kt

@@ -25,7 +25,6 @@ internal object Env {
 
     val ldkLogLevel = LogLevel.TRACE
 
-    // TODO: remove this to load from BT API instead
     val trustedLnPeers
         get() = when (network) {
             Network.BITCOIN -> listOf(Peers.mainnetLnd1, Peers.mainnetLnd3, Peers.mainnetLnd4)
@@ -191,15 +190,16 @@ internal object Env {
     // endregion
 }
 
+@Suppress("ConstPropertyName")
 object TransactionDefaults {
     /** Total recommended tx base fee in sats */
-    val recommendedBaseFee = 256u
+    const val recommendedBaseFee = 256u
 
     /**
      * Minimum value in sats for an output. Outputs below the dust limit may not be processed because the fees
      * required to include them in a block would be greater than the value of the transaction itself.
      * */
-    val dustLimit = 546u
+    const val dustLimit = 546u
 }
 
 object Peers {

app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@@ -37,7 +37,6 @@ import org.lightningdevkit.ldknode.PaymentDetails
 import org.lightningdevkit.ldknode.PaymentId
 import org.lightningdevkit.ldknode.PeerDetails
 import org.lightningdevkit.ldknode.SpendableUtxo
-import org.lightningdevkit.ldknode.TransactionDetails
 import org.lightningdevkit.ldknode.Txid
 import to.bitkit.data.CacheStore
 import to.bitkit.data.SettingsStore
@@ -95,7 +94,7 @@ class LightningRepo @Inject constructor(
 
     private val scope = CoroutineScope(bgDispatcher + SupervisorJob())
 
-    private val _eventHandlers = mutableSetOf<NodeEventHandler>()
+    private val _eventHandlers = ConcurrentHashMap.newKeySet<NodeEventHandler>()
     private val _isRecoveryMode = MutableStateFlow(false)
     val isRecoveryMode = _isRecoveryMode.asStateFlow()
 

app/src/main/java/to/bitkit/services/LightningService.kt

@@ -31,7 +31,6 @@ import org.lightningdevkit.ldknode.PaymentDetails
 import org.lightningdevkit.ldknode.PaymentId
 import org.lightningdevkit.ldknode.PeerDetails
 import org.lightningdevkit.ldknode.SpendableUtxo
-import org.lightningdevkit.ldknode.TransactionDetails
 import org.lightningdevkit.ldknode.Txid
 import org.lightningdevkit.ldknode.defaultConfig
 import to.bitkit.async.BaseCoroutineScope

app/src/main/java/to/bitkit/ui/screens/settings/LdkDebugScreen.kt

@@ -32,6 +32,7 @@ import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import androidx.navigation.NavController
 import com.synonym.vssclient.KeyVersion
 import to.bitkit.R
+import to.bitkit.env.Env
 import to.bitkit.models.BackupCategory
 import to.bitkit.ui.components.ButtonSize
 import to.bitkit.ui.components.PrimaryButton
@@ -148,7 +149,7 @@ private fun LdkDebugContent(
                 enabled = !uiState.isLoading,
                 onClick = {
                     onExportNetworkGraph { file ->
-                        val uri = FileProvider.getUriForFile(context, "${context.packageName}.fileprovider", file)
+                        val uri = FileProvider.getUriForFile(context, Env.FILE_PROVIDER_AUTHORITY, file)
                         context.shareFile(uri, "text/plain")
                     }
                 },

app/src/main/java/to/bitkit/ui/screens/wallets/activity/ActivityDetailScreen.kt

@@ -85,6 +85,7 @@ import to.bitkit.ui.utils.getScreenTitleRes
 import to.bitkit.viewmodels.ActivityDetailViewModel
 import to.bitkit.viewmodels.ActivityListViewModel
 
+@Suppress("CyclomaticComplexMethod")
 @Composable
 fun ActivityDetailScreen(
     listViewModel: ActivityListViewModel,