Skip to content

Commit 9ebcf8b

Browse files
committed
chore: update copilot instructions
1 parent dc3682e commit 9ebcf8b

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

.github/copilot-instructions.md

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ When performing a code review, ensure ViewModels are never injected as dependenc
88

99
When performing a code review, verify that all async operations use `viewModelScope.launch` instead of `GlobalScope.launch` in ViewModels.
1010

11-
When performing a code review, ensure Repository pattern is followed with proper data source abstraction.
11+
When performing a code review, ensure Repository pattern is followed
1212

1313
When performing a code review, verify StateFlow is used for reactive state management in ViewModels with proper `_uiState` and `uiState` pattern.
1414

@@ -18,10 +18,6 @@ When performing a code review, flag any use of the not-null assertion operator (
1818

1919
When performing a code review, ensure all coroutine operations use proper error handling with `runCatching`
2020

21-
When performing a code review, verify that all Logger calls include the TAG as context parameter, e.g., `Logger.warn("message", e = e, context = TAG)`.
22-
23-
When performing a code review, check that methods exist before they are called, especially after refactoring.
24-
2521
## UI & Compose Best Practices
2622

2723
When performing a code review, ensure all user-facing strings use `stringResource(R.string.*)` instead of hardcoded strings.
@@ -34,7 +30,7 @@ When performing a code review, ensure proper state management patterns with `Mut
3430

3531
## Code Quality & Readability
3632

37-
When performing a code review, focus on readability and avoid nested ternary operators.
33+
When performing a code review, focus on readability and avoid nested if-else, replacing with early return wherever possible.
3834

3935
When performing a code review, ensure unused code is removed after refactoring.
4036

@@ -48,11 +44,7 @@ When performing a code review, ensure services contain business logic and don't
4844

4945
## Build & Testing
5046

51-
When performing a code review, ensure proper build variant usage (dev for regtest, tnet for testnet).
52-
53-
When performing a code review, verify that unit tests follow the pattern `./gradlew testDevDebugUnitTest --tests ClassName`.
54-
55-
When performing a code review, suggest Unit Test com composable components and business logic covering the most important cases
47+
When performing a code review, suggest Unit Test for composable components and business logic covering the most important cases
5648

5749
## Lightning & Bitcoin Specific
5850

0 commit comments

Comments
 (0)