feat: e2e test tags wip

ovitrif · ovitrif · commit a014bc301ebb · 2025-08-13T22:57:12.000+02:00
diff --git a/app/src/androidTest/java/to/bitkit/ui/components/KeyboardTest.kt b/app/src/androidTest/java/to/bitkit/ui/components/KeyboardTest.kt
@@ -28,34 +28,34 @@ class KeyboardTest {
             Keyboard(onClick = {}, onClickBackspace = {})
         }
 
-        composeTestRule.onNodeWithTag("KeyboardButton_1").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_2").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_3").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_4").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_5").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_6").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_7").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_8").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_9").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_.").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_0").assertIsDisplayed()
-        composeTestRule.onNodeWithTag("KeyboardButton_backspace").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N1").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N2").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N3").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N4").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N5").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N6").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N7").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N8").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N9").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N.").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N0").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("NRemove").assertIsDisplayed()
     }
 
     @Test
     fun keyboard_tripleZero_when_not_decimal() {
         composeTestRule.setContent {
             Keyboard(onClick = {}, isDecimal = false, onClickBackspace = {})
         }
-        composeTestRule.onNodeWithTag("KeyboardButton_000").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N000").assertIsDisplayed()
     }
 
     @Test
     fun keyboard_decimal_when_decimal() {
         composeTestRule.setContent {
             Keyboard(onClick = {}, isDecimal = true, onClickBackspace = {})
         }
-        composeTestRule.onNodeWithTag("KeyboardButton_.").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("N.").assertIsDisplayed()
     }
 
     @Test
@@ -65,13 +65,13 @@ class KeyboardTest {
             Keyboard(onClick = { clickedValue = it }, onClickBackspace = {})
         }
 
-        composeTestRule.onNodeWithTag("KeyboardButton_5").performClick()
+        composeTestRule.onNodeWithTag("N5").performClick()
         assert(clickedValue == "5")
 
-        composeTestRule.onNodeWithTag("KeyboardButton_.").performClick()
+        composeTestRule.onNodeWithTag("N.").performClick()
         assert(clickedValue == ".")
 
-        composeTestRule.onNodeWithTag("KeyboardButton_0").performClick()
+        composeTestRule.onNodeWithTag("N0").performClick()
         assert(clickedValue == "0")
 
     }
@@ -83,7 +83,7 @@ class KeyboardTest {
             Keyboard(onClick = { clickedValue = it }, onClickBackspace = {}, isDecimal = false)
         }
 
-        composeTestRule.onNodeWithTag("KeyboardButton_000").performClick()
+        composeTestRule.onNodeWithTag("N000").performClick()
         assert(clickedValue == "000")
     }
 
diff --git a/app/src/androidTest/java/to/bitkit/ui/settings/quickPay/QuickPaySettingsScreenTest.kt b/app/src/androidTest/java/to/bitkit/ui/settings/quickPay/QuickPaySettingsScreenTest.kt
@@ -36,7 +36,7 @@ class QuickPaySettingsScreenTest {
             }
         }
 
-        composeTestRule.onNodeWithTag("quickpay_toggle_switch").assertIsDisplayed()
+        composeTestRule.onNodeWithTag("QuickpayToggle").assertIsDisplayed()
         composeTestRule.onNodeWithTag("quickpay_amount_slider").assertIsDisplayed()
     }
 
@@ -58,7 +58,7 @@ class QuickPaySettingsScreenTest {
             }
         }
 
-        composeTestRule.onNodeWithTag("quickpay_toggle_switch")
+        composeTestRule.onNodeWithTag("QuickpayToggle")
             .performClick()
 
         assert(toggleCalled)
diff --git a/app/src/main/java/to/bitkit/models/Suggestion.kt b/app/src/main/java/to/bitkit/models/Suggestion.kt
@@ -18,7 +18,7 @@ enum class Suggestion(
         color = Colors.Brand,
         icon = R.drawable.b_emboss
     ),
-    SPEND(
+    LIGHTNING(
         title = R.string.cards__lightning__title,
         description = R.string.cards__lightning__description,
         color = Colors.Purple,
diff --git a/app/src/main/java/to/bitkit/ui/components/BalanceHeaderView.kt b/app/src/main/java/to/bitkit/ui/components/BalanceHeaderView.kt
@@ -183,6 +183,7 @@ fun BalanceHeader(
                             modifier = Modifier
                                 .size(24.dp)
                                 .clickableAlpha { onToggleHideBalance() }
+                                .testTag("ShowBalance")
                         )
                     }
                 }
diff --git a/app/src/main/java/to/bitkit/ui/components/Keyboard.kt b/app/src/main/java/to/bitkit/ui/components/Keyboard.kt
@@ -80,15 +80,22 @@ fun Keyboard(
             item { KeyTextButton(text = "7", onClick = onClick, buttonHeight = buttonHeight) }
             item { KeyTextButton(text = "8", onClick = onClick, buttonHeight = buttonHeight) }
             item { KeyTextButton(text = "9", onClick = onClick, buttonHeight = buttonHeight) }
-            item { KeyTextButton(text = if (isDecimal) "." else "000", onClick = onClick, buttonHeight = buttonHeight) }
+            item {
+                KeyTextButton(
+                    text = if (isDecimal) "." else "000",
+                    onClick = onClick,
+                    buttonHeight = buttonHeight,
+                    testTag = if (isDecimal) "NDecimal" else "N000",
+                )
+            }
             item { KeyTextButton(text = "0", onClick = onClick, buttonHeight = buttonHeight) }
             item {
                 KeyIconButton(
                     icon = R.drawable.ic_backspace,
                     contentDescription = stringResource(R.string.common__delete),
                     onClick = onClickBackspace,
                     buttonHeight = buttonHeight,
-                    modifier = Modifier.testTag("KeyboardButton_backspace"),
+                    modifier = Modifier.testTag("NRemove"),
                 )
             }
         }
@@ -121,11 +128,12 @@ fun KeyTextButton(
     onClick: (String) -> Unit,
     buttonHeight: Dp = idealButtonHeight,
     modifier: Modifier = Modifier,
+    testTag: String = "N$text",
 ) {
     KeyButtonBox(
         onClick = { onClick(text) },
         buttonHeight = buttonHeight,
-        modifier = modifier.testTag("KeyboardButton_$text"),
+        modifier = modifier.testTag(testTag)
     ) {
         Text(
             text = text,
diff --git a/app/src/main/java/to/bitkit/ui/components/NumberPadSimple.kt b/app/src/main/java/to/bitkit/ui/components/NumberPadSimple.kt
@@ -68,7 +68,7 @@ fun NumberPadSimple(
                 onClick = { onPress(KEY_DELETE) },
                 modifier = Modifier
                     .weight(1f)
-                    .testTag("KeyboardButton_backspace")
+                    .testTag("NRemove")
             )
         }
     }
diff --git a/app/src/main/java/to/bitkit/ui/components/SuggestionCard.kt b/app/src/main/java/to/bitkit/ui/components/SuggestionCard.kt
@@ -17,6 +17,7 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.layout.ContentScale
+import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.AnnotatedString
@@ -68,7 +69,9 @@ fun SuggestionCard(
                 onClose?.let {
                     IconButton(
                         onClick = it,
-                        modifier = Modifier.size(16.dp)
+                        modifier = Modifier
+                            .size(16.dp)
+                            .testTag("SuggestionDismiss")
                     ) {
                         Icon(
                             painter = painterResource(R.drawable.ic_x),
diff --git a/app/src/main/java/to/bitkit/ui/components/Tag.kt b/app/src/main/java/to/bitkit/ui/components/Tag.kt
@@ -13,6 +13,7 @@ import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.painter.Painter
+import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
@@ -46,14 +47,17 @@ fun TagButton(
         BodySSB(
             text = text,
             color = textColor,
+            modifier = Modifier.testTag("Tag-$text")
         )
 
         if (displayIconClose) {
             Icon(
                 painter = icon,
                 contentDescription = null,
                 tint = Colors.White64,
-                modifier = Modifier.size(16.dp)
+                modifier = Modifier
+                    .size(16.dp)
+                    .testTag("Tag-$text-delete")
             )
         }
     }
diff --git a/app/src/main/java/to/bitkit/ui/screens/transfer/external/ExternalConfirmScreen.kt b/app/src/main/java/to/bitkit/ui/screens/transfer/external/ExternalConfirmScreen.kt
@@ -26,6 +26,7 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Alignment.Companion.CenterHorizontally
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.layout.ContentScale
+import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.Preview
@@ -113,6 +114,7 @@ private fun Content(
                         .weight(1f)
                         .padding(top = 16.dp)
                         .clickableAlpha(onClick = onNetworkFeeClick)
+                        .testTag("SetCustomFee")
                 ) {
                     Caption13Up(
                         text = stringResource(R.string.lightning__spending_confirm__network_fee),
diff --git a/app/src/main/java/to/bitkit/ui/screens/wallets/HomeScreen.kt b/app/src/main/java/to/bitkit/ui/screens/wallets/HomeScreen.kt
@@ -171,7 +171,7 @@ fun HomeScreen(
                     rootNavController.navigate(Routes.BuyIntro)
                 }
 
-                Suggestion.SPEND -> {
+                Suggestion.LIGHTNING -> {
                     if (!hasSeenTransferIntro) {
                         rootNavController.navigateToTransferIntro()
                     } else {
@@ -369,10 +369,10 @@ private fun Content(
                             Text13Up(stringResource(R.string.cards__suggestions), color = Colors.White64)
                             Spacer(modifier = Modifier.height(16.dp))
                             LazyRow(
-                                modifier = Modifier.fillMaxWidth(),
                                 horizontalArrangement = Arrangement.spacedBy(16.dp),
                                 state = state,
-                                flingBehavior = snapBehavior
+                                flingBehavior = snapBehavior,
+                                modifier = Modifier.fillMaxWidth().testTag("Suggestions")
                             ) {
                                 items(homeUiState.suggestions, key = { it.name }) { item ->
                                     SuggestionCard(
@@ -382,7 +382,7 @@ private fun Content(
                                         icon = item.icon,
                                         onClose = { onRemoveSuggestion(item) },
                                         onClick = { onClickSuggestion(item) },
-                                        modifier = Modifier.testTag("SUGGESTION_${item.name}")
+                                        modifier = Modifier.testTag("Suggestion-${item.name.lowercase()}")
                                     )
                                 }
                             }
diff --git a/app/src/main/java/to/bitkit/ui/screens/wallets/HomeViewModel.kt b/app/src/main/java/to/bitkit/ui/screens/wallets/HomeViewModel.kt
@@ -273,7 +273,7 @@ class HomeViewModel @Inject constructor(
             balanceState.totalOnchainSats > 0uL -> { // Only on chain balance
                 listOfNotNull(
                     Suggestion.BACK_UP.takeIf { !settings.backupVerified },
-                    Suggestion.SPEND,
+                    Suggestion.LIGHTNING,
                     Suggestion.SECURE.takeIf { !settings.isPinEnabled },
                     Suggestion.BUY,
                     Suggestion.SUPPORT,
@@ -286,7 +286,7 @@ class HomeViewModel @Inject constructor(
             else -> { // Empty wallet
                 listOfNotNull(
                     Suggestion.BUY,
-                    Suggestion.SPEND,
+                    Suggestion.LIGHTNING,
                     Suggestion.BACK_UP.takeIf { !settings.backupVerified },
                     Suggestion.SECURE.takeIf { !settings.isPinEnabled },
                     Suggestion.SUPPORT,
diff --git a/app/src/main/java/to/bitkit/ui/screens/wallets/activity/ActivityDetailScreen.kt b/app/src/main/java/to/bitkit/ui/screens/wallets/activity/ActivityDetailScreen.kt
@@ -354,6 +354,7 @@ private fun ActivityDetailContent(
                 FlowRow(
                     horizontalArrangement = Arrangement.spacedBy(8.dp),
                     verticalArrangement = Arrangement.spacedBy(8.dp),
+                    modifier = Modifier.testTag("ActivityTags")
                 ) {
                     tags.forEach { tag ->
                         TagButton(
@@ -444,7 +445,9 @@ private fun ActivityDetailContent(
                             modifier = Modifier.size(16.dp)
                         )
                     },
-                    modifier = Modifier.weight(1f)
+                    modifier = Modifier
+                        .weight(1f)
+                        .testTag("ActivityTag")
                 )
             }
             Row(
diff --git a/app/src/main/java/to/bitkit/ui/settings/appStatus/AppStatusScreen.kt b/app/src/main/java/to/bitkit/ui/settings/appStatus/AppStatusScreen.kt
@@ -21,6 +21,7 @@ import androidx.compose.runtime.getValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.Preview
@@ -98,6 +99,7 @@ private fun Content(
 
             StatusItem(
                 statusUi = StatusUi(
+                    id = "internet",
                     title = stringResource(R.string.settings__status__internet__title),
                     subtitle = when (uiState.health.internet) {
                         HealthState.READY -> stringResource(R.string.settings__status__internet__ready)
@@ -112,6 +114,7 @@ private fun Content(
 
             StatusItem(
                 statusUi = StatusUi(
+                    id = "electrum",
                     title = stringResource(R.string.settings__status__electrum__title),
                     subtitle = when (uiState.health.electrum) {
                         HealthState.READY -> stringResource(R.string.settings__status__electrum__ready)
@@ -126,6 +129,7 @@ private fun Content(
 
             StatusItem(
                 statusUi = StatusUi(
+                    id = "lightning_node",
                     title = stringResource(R.string.settings__status__lightning_node__title),
                     subtitle = uiState.nodeSubtitle.ifEmpty {
                         when (uiState.health.node) {
@@ -142,6 +146,7 @@ private fun Content(
 
             StatusItem(
                 statusUi = StatusUi(
+                    id = "lightning_connection",
                     title = stringResource(R.string.settings__status__lightning_connection__title),
                     subtitle = when (uiState.health.channels) {
                         HealthState.READY -> stringResource(R.string.settings__status__lightning_connection__ready)
@@ -156,6 +161,7 @@ private fun Content(
 
             StatusItem(
                 statusUi = StatusUi(
+                    id = "backup",
                     title = stringResource(R.string.settings__status__backup__title),
                     subtitle = uiState.backupSubtitle.ifEmpty {
                         when (uiState.health.backups) {
@@ -200,6 +206,7 @@ private fun StatusItem(
                 .fillMaxWidth()
                 .height(72.dp)
                 .clickableAlpha { onClick() }
+                .testTag("Status-${statusUi.id}")
         ) {
             Box(
                 contentAlignment = Alignment.Center,
@@ -238,6 +245,7 @@ private fun StatusItem(
 }
 
 private data class StatusUi(
+    val id: String,
     val title: String,
     val subtitle: String,
     @DrawableRes val iconRes: Int,
diff --git a/app/src/main/java/to/bitkit/ui/settings/quickPay/QuickPaySettingsScreen.kt b/app/src/main/java/to/bitkit/ui/settings/quickPay/QuickPaySettingsScreen.kt
@@ -76,7 +76,7 @@ fun QuickPaySettingsScreenContent(
                 title = stringResource(R.string.settings__quickpay__settings__toggle),
                 isChecked = isQuickPayEnabled,
                 onClick = { onToggleQuickPay(!isQuickPayEnabled) },
-                modifier = Modifier.testTag("quickpay_toggle_switch")
+                modifier = Modifier.testTag("QuickpayToggle")
             )
 
             Spacer(modifier = Modifier.height(16.dp))
diff --git a/app/src/main/java/to/bitkit/ui/settings/transactionSpeed/TransactionSpeedSettingsScreen.kt b/app/src/main/java/to/bitkit/ui/settings/transactionSpeed/TransactionSpeedSettingsScreen.kt
diff --git a/app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt b/app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt
diff --git a/docs/e2e-test-ids.md b/docs/e2e-test-ids.md

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ class QuickPaySettingsScreenTest {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
`39`		`- composeTestRule.onNodeWithTag("quickpay_toggle_switch").assertIsDisplayed()`
	`39`	`+ composeTestRule.onNodeWithTag("QuickpayToggle").assertIsDisplayed()`
`40`	`40`	`composeTestRule.onNodeWithTag("quickpay_amount_slider").assertIsDisplayed()`
`41`	`41`	`}`
`42`	`42`
`@@ -58,7 +58,7 @@ class QuickPaySettingsScreenTest {`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`
`61`		`- composeTestRule.onNodeWithTag("quickpay_toggle_switch")`
	`61`	`+ composeTestRule.onNodeWithTag("QuickpayToggle")`
`62`	`62`	`.performClick()`
`63`	`63`
`64`	`64`	`assert(toggleCalled)`
Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ fun BalanceHeader(`
`183`	`183`	`modifier = Modifier`
`184`	`184`	`.size(24.dp)`
`185`	`185`	`.clickableAlpha { onToggleHideBalance() }`
	`186`	`+ .testTag("ShowBalance")`
`186`	`187`	`)`
`187`	`188`	`}`
`188`	`189`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ fun NumberPadSimple(`
`68`	`68`	`onClick = { onPress(KEY_DELETE) },`
`69`	`69`	`modifier = Modifier`
`70`	`70`	`.weight(1f)`
`71`		`- .testTag("KeyboardButton_backspace")`
	`71`	`+ .testTag("NRemove")`
`72`	`72`	`)`
`73`	`73`	`}`
`74`	`74`	`}`