Skip to content

Commit a2aaa0c

Browse files
committed
chore: Cleanup & fix comments
1 parent 78d3263 commit a2aaa0c

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

app/src/main/java/to/bitkit/data/SettingsStore.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,17 @@ class SettingsStore @Inject constructor(
4747
store.edit { it[SELECTED_CURRENCY_KEY] = currency }
4848
}
4949

50-
val showEmptyState: Flow<Boolean> = store.data.map { it[SHOW_EMPTY_STATE] ?: false }
50+
val showEmptyState: Flow<Boolean> = store.data.map { it[SHOW_EMPTY_STATE] == true }
5151
suspend fun setShowEmptyState(show: Boolean) {
5252
store.edit { it[SHOW_EMPTY_STATE] = show }
5353
}
5454

55-
val hasSeenSpendingIntro: Flow<Boolean> = store.data.map { it[HAS_SEEN_SPENDING_INTRO] ?: false }
55+
val hasSeenSpendingIntro: Flow<Boolean> = store.data.map { it[HAS_SEEN_SPENDING_INTRO] == true }
5656
suspend fun setHasSeenSpendingIntro(value: Boolean) {
5757
store.edit { it[HAS_SEEN_SPENDING_INTRO] = value }
5858
}
5959

60-
val hasSeenSavingsIntro: Flow<Boolean> = store.data.map { it[HAS_SEEN_SAVINGS_INTRO] ?: false }
60+
val hasSeenSavingsIntro: Flow<Boolean> = store.data.map { it[HAS_SEEN_SAVINGS_INTRO] == true }
6161
suspend fun setHasSeenSavingsIntro(value: Boolean) {
6262
store.edit { it[HAS_SEEN_SAVINGS_INTRO] = value }
6363
}
@@ -67,15 +67,12 @@ class SettingsStore @Inject constructor(
6767
store.edit { it[LIGHTNING_SETUP_STEP] = value }
6868
}
6969

70-
// TODO secure?
7170
val isPinEnabled: Flow<Boolean> = store.data.map { it[IS_PIN_ENABLED] == true }
7271
suspend fun setIsPinEnabled(value: Boolean) { store.edit { it[IS_PIN_ENABLED] = value } }
7372

74-
// TODO secure?
7573
val isPinOnLaunchEnabled: Flow<Boolean> = store.data.map { it[IS_PIN_ON_LAUNCH_ENABLED] == true }
7674
suspend fun setIsPinOnLaunchEnabled(value: Boolean) { store.edit { it[IS_PIN_ON_LAUNCH_ENABLED] = value } }
7775

78-
// TODO secure?
7976
val isBiometricEnabled: Flow<Boolean> = store.data.map { it[IS_BIOMETRIC_ENABLED] == true }
8077
suspend fun setIsBiometricEnabled(value: Boolean) { store.edit { it[IS_BIOMETRIC_ENABLED] = value } }
8178

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -790,7 +790,7 @@ class AppViewModel @Inject constructor(
790790
return keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name)
791791
}
792792

793-
// region Security
793+
// region security
794794
fun validatePin(pin: String): Boolean {
795795
val storedPin = keychain.loadString(Keychain.Key.PIN.name)
796796
val isValid = storedPin == pin
@@ -807,11 +807,10 @@ class AppViewModel @Inject constructor(
807807
keychain.upsertString(Keychain.Key.PIN_ATTEMPTS_REMAINING.name, newAttempts.toString())
808808

809809
if (newAttempts <= 0) {
810-
// TODO: wipeApp() - return to onboarding
810+
// TODO: wipeStorage() & return to onboarding
811811
toast(
812812
type = Toast.ToastType.WARNING,
813813
title = "TODO: Wipe App data",
814-
description = "Too many incorrect PIN attempts. App data has been wiped.",
815814
)
816815
}
817816
}

0 commit comments

Comments
 (0)