Skip to content

Commit ac731cd

Browse files
authored
Merge pull request #105 from synonymdev/fix/qr-code-small-screen
Adapt Receive QR code Screen to small screens
2 parents 002483a + 5980c4c commit ac731cd

File tree

2 files changed

+42
-5
lines changed

2 files changed

+42
-5
lines changed

app/src/main/java/to/bitkit/ui/components/QrCodeImage.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,18 +52,17 @@ fun QrCodeImage(
5252
Box(
5353
contentAlignment = Alignment.TopCenter,
5454
modifier = modifier
55-
.fillMaxWidth()
5655
.background(Color.White, RoundedCornerShape(8.dp))
5756
.aspectRatio(1f)
58-
.padding(16.dp)
57+
.padding(8.dp)
5958
) {
6059
val bitmap = rememberQrBitmap(content, size)
6160

6261
if (bitmap != null) {
6362
Image(
6463
painter = remember(bitmap) { BitmapPainter(bitmap.asImageBitmap()) },
6564
contentDescription = null,
66-
modifier = Modifier.fillMaxSize(),
65+
contentScale = ContentScale.Inside,
6766
)
6867
logoPainter?.let {
6968
Box(

app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt

Lines changed: 40 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import androidx.compose.ui.platform.LocalContext
3030
import androidx.compose.ui.res.painterResource
3131
import androidx.compose.ui.res.stringResource
3232
import androidx.compose.ui.text.AnnotatedString
33+
import androidx.compose.ui.tooling.preview.Devices.PIXEL_TABLET
3334
import androidx.compose.ui.tooling.preview.Preview
3435
import androidx.compose.ui.unit.dp
3536
import androidx.navigation.compose.NavHost
@@ -185,7 +186,7 @@ private fun ReceiveQrScreen(
185186
val uri = cjitInvoice.value ?: walletState.bip21
186187

187188
Column(
188-
modifier = Modifier.padding(horizontal = 16.dp)
189+
modifier = Modifier.padding(horizontal = 16.dp).weight(1f)
189190
) {
190191
Column(
191192
horizontalAlignment = Alignment.CenterHorizontally,
@@ -197,6 +198,7 @@ private fun ReceiveQrScreen(
197198
0 -> ReceiveQrSlide(
198199
uri = uri,
199200
qrLogoPainter = painterResource(qrLogoImageRes),
201+
modifier = Modifier.fillMaxWidth()
200202
)
201203

202204
1 -> CopyValuesSlide(
@@ -248,20 +250,25 @@ private fun ReceiveLightningFunds(
248250
private fun ReceiveQrSlide(
249251
uri: String,
250252
qrLogoPainter: Painter,
253+
modifier: Modifier
251254
) {
252255
val context = LocalContext.current
253256
val clipboard = LocalClipboardManager.current
257+
254258
Column(
255259
horizontalAlignment = Alignment.CenterHorizontally,
260+
modifier = modifier
256261
) {
257262
QrCodeImage(
258263
content = uri,
259264
logoPainter = qrLogoPainter,
265+
modifier = Modifier.weight(1f, fill = false)
260266
)
267+
261268
Spacer(modifier = Modifier.height(16.dp))
262269
Row(
263270
horizontalArrangement = Arrangement.spacedBy(16.dp),
264-
verticalAlignment = Alignment.CenterVertically,
271+
verticalAlignment = Alignment.Top,
265272
) {
266273
PrimaryButton(
267274
text = stringResource(R.string.common__edit),
@@ -309,6 +316,7 @@ private fun ReceiveQrSlide(
309316
}
310317
)
311318
}
319+
Spacer(modifier = Modifier.height(16.dp))
312320
}
313321
}
314322

@@ -418,6 +426,36 @@ private fun ReceiveQrScreenPreview() {
418426
}
419427
}
420428

429+
@Preview(showBackground = true, heightDp = 600)
430+
@Composable
431+
private fun ReceiveQrScreenPreviewSmallScreen() {
432+
AppThemeSurface {
433+
ReceiveQrScreen(
434+
cjitInvoice = remember { mutableStateOf(null) },
435+
cjitActive = remember { mutableStateOf(false) },
436+
walletState = MainUiState(
437+
nodeLifecycleState = Running,
438+
),
439+
onCjitToggle = { },
440+
)
441+
}
442+
}
443+
444+
@Preview(showBackground = true, device = PIXEL_TABLET)
445+
@Composable
446+
private fun ReceiveQrScreenPreviewTablet() {
447+
AppThemeSurface {
448+
ReceiveQrScreen(
449+
cjitInvoice = remember { mutableStateOf(null) },
450+
cjitActive = remember { mutableStateOf(false) },
451+
walletState = MainUiState(
452+
nodeLifecycleState = Running,
453+
),
454+
onCjitToggle = { },
455+
)
456+
}
457+
}
458+
421459
@Suppress("SpellCheckingInspection")
422460
@Preview(showBackground = true)
423461
@Composable

0 commit comments

Comments
 (0)