fix: handle node stop when service not initialized

Author: jvsena42

app/src/main/java/to/bitkit/ui/ContentView.kt

@@ -186,16 +186,21 @@ fun ContentView(
     val context = LocalContext.current
     val lifecycle = LocalLifecycleOwner.current.lifecycle
 
+    val walletUiState by walletViewModel.walletState.collectAsStateWithLifecycle()
+    val lightningState by walletViewModel.lightningState.collectAsStateWithLifecycle()
+    val nodeLifecycleState = lightningState.nodeLifecycleState
+
+    val isRecoveryMode by walletViewModel.isRecoveryMode.collectAsStateWithLifecycle()
+    val notificationsGranted by settingsViewModel.notificationsGranted.collectAsStateWithLifecycle()
+    val walletExists = walletUiState.walletExists
+
     // Effects on app entering fg (ON_START) / bg (ON_STOP)
     DisposableEffect(lifecycle) {
-        // TODO ADAPT THIS LOGIC TO WORK WITH LightningNodeService
         val observer = LifecycleEventObserver { _, event ->
             when (event) {
                 Lifecycle.Event.ON_START -> {
-                    try {
+                    if (walletExists && !isRecoveryMode) {
                         walletViewModel.start()
-                    } catch (e: Throwable) {
-                        Logger.error("Failed to start wallet", e)
                     }
 
                     val pendingTransaction = NewTransactionSheetDetails.load(context)
@@ -208,6 +213,14 @@ fun ContentView(
                     blocktankViewModel.refreshOrders()
                 }
 
+                Lifecycle.Event.ON_STOP -> {
+                    if (walletExists && !isRecoveryMode && !notificationsGranted) {
+                        // App backgrounded without notification permission - stop node
+                        walletViewModel.stop()
+                    }
+                    // If notificationsGranted=true, service keeps node running
+                }
+
                 else -> Unit
             }
         }
@@ -242,9 +255,6 @@ fun ContentView(
         }
     }
 
-    val walletUiState by walletViewModel.uiState.collectAsStateWithLifecycle()
-    val nodeLifecycleState = walletUiState.nodeLifecycleState
-
     var walletIsInitializing by remember { mutableStateOf(nodeLifecycleState == NodeLifecycleState.Initializing) }
     var walletInitShouldFinish by remember { mutableStateOf(false) }
 
@@ -271,7 +281,6 @@ fun ContentView(
     var restoreRetryCount by remember { mutableIntStateOf(0) }
 
     if (walletIsInitializing) {
-        // TODO ADAPT THIS LOGIC TO WORK WITH LightningNodeService
         if (nodeLifecycleState is NodeLifecycleState.ErrorStarting) {
             WalletRestoreErrorView(
                 retryCount = restoreRetryCount,

app/src/main/java/to/bitkit/viewmodels/WalletViewModel.kt

@@ -153,6 +153,18 @@ class WalletViewModel @Inject constructor(
         }
     }
 
+    fun stop() {
+        if (!walletExists) return
+
+        viewModelScope.launch(bgDispatcher) {
+            lightningRepo.stop()
+                .onFailure { error ->
+                    Logger.error("Node stop error", error)
+                    ToastEventBus.send(error)
+                }
+        }
+    }
+
     suspend fun observeLdkWallet() {
         walletRepo.observeLdkWallet()
     }