refactor: move node start callback last

Author: ovitrif

app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@@ -166,9 +166,9 @@ class LightningRepo @Inject constructor(
         walletIndex: Int = 0,
         timeout: Duration? = null,
         shouldRetry: Boolean = true,
-        eventHandler: NodeEventHandler? = null,
         customServerUrl: String? = null,
         customRgsServerUrl: String? = null,
+        eventHandler: NodeEventHandler? = null,
     ): Result<Unit> = withContext(bgDispatcher) {
         if (_isRecoveryMode.value) {
             return@withContext Result.failure(
@@ -239,9 +239,9 @@ class LightningRepo @Inject constructor(
                     walletIndex = walletIndex,
                     timeout = timeout,
                     shouldRetry = false,
-                    eventHandler = eventHandler,
                     customServerUrl = customServerUrl,
                     customRgsServerUrl = customRgsServerUrl,
+                    eventHandler = eventHandler,
                 )
             } else {
                 Logger.error("Node start error", e, context = TAG)
@@ -337,9 +337,9 @@ class LightningRepo @Inject constructor(
         Logger.debug("Starting node with new electrum server: '$newServerUrl'")
 
         start(
-            eventHandler = cachedEventHandler,
-            customServerUrl = newServerUrl,
             shouldRetry = false,
+            customServerUrl = newServerUrl,
+            eventHandler = cachedEventHandler,
         ).onFailure { startError ->
             Logger.warn("Failed ldk-node config change, attempting recovery…")
             restartWithPreviousConfig()
@@ -364,9 +364,9 @@ class LightningRepo @Inject constructor(
         Logger.debug("Starting node with new RGS server: '$newRgsUrl'")
 
         start(
-            eventHandler = cachedEventHandler,
             shouldRetry = false,
             customRgsServerUrl = newRgsUrl,
+            eventHandler = cachedEventHandler,
         ).onFailure { startError ->
             Logger.warn("Failed ldk-node config change, attempting recovery…")
             restartWithPreviousConfig()
@@ -390,8 +390,8 @@ class LightningRepo @Inject constructor(
         Logger.debug("Starting node with previous config for recovery")
 
         start(
-            eventHandler = cachedEventHandler,
             shouldRetry = false,
+            eventHandler = cachedEventHandler,
         ).onSuccess {
             Logger.debug("Successfully started node with previous config")
         }.onFailure { e ->

app/src/main/java/to/bitkit/services/CoreService.kt

@@ -164,7 +164,7 @@ class CoreService @Inject constructor(
 // endregion
 
 // region Activity
-private const val CHUNCK_SIZE = 50
+private const val CHUNK_SIZE = 50
 
 class ActivityService(
     private val coreService: CoreService,
@@ -284,7 +284,7 @@ class ActivityService(
         ServiceQueue.CORE.background {
             val allResults = mutableListOf<Result<String>>()
 
-            payments.chunked(CHUNCK_SIZE).forEach { chunk ->
+            payments.chunked(CHUNK_SIZE).forEach { chunk ->
                 val results = chunk.map { payment ->
                     async {
                         runCatching {