feat: Send Sheet v59 redesign #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
Member
Author
|
Drafted to update the |
This comment was marked as outdated.
This comment was marked as outdated.
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the v59 redesign for the Send Sheet, transforming it from a simple list of buttons into an interactive QR code scanner with camera integration. The main changes include adding camera functionality, permission handling, and gallery image scanning capabilities.
Key changes:
- Added inline camera preview with QR code scanning in the Send Sheet
- Implemented camera permission handling with a permission denied state UI
- Refactored RectangleButton component to support simplified icon rendering with backgrounds
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/drawable/ic_camera.xml | New camera icon drawable resource used in the permission denied UI |
| app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt | Complete redesign to integrate camera preview, QR scanning, gallery image scanning, and permission handling directly into the send screen |
| app/src/main/java/to/bitkit/ui/screens/scanner/QrCodeAnalyzer.kt | Updated QR code analyzer to use cooldown-based scanning instead of single-scan approach |
| app/src/main/java/to/bitkit/ui/components/RectangleButton.kt | Refactored to simplify icon API, now accepting drawable resource IDs with automatic background styling |
| app/src/main/java/to/bitkit/ui/screens/transfer/FundingScreen.kt | Updated to use new RectangleButton API with drawable resource IDs |
| app/src/main/java/to/bitkit/ui/screens/transfer/FundingAdvancedScreen.kt | Updated to use new RectangleButton API with drawable resource IDs |
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
Will be reopened after #485 merge |
Member
Author
|
Waiting for #495 merge |
# Conflicts: # app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt
Fixed
Show fixed
Hide fixed
Member
Author
|
@piotr-iohk some tests are failing because of the camera permission dialog |
Collaborator
Adjusted. |
ovitrif
approved these changes
Dec 8, 2025
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIGMA
Description
This PR applies the v59 design on receive sheet
Preview
Screen_recording_20251205_081642.mp4
QA Notes
Tested: