Skip to content

Remove the TabBar Animation Cutoff #493

@jvsena42

Description

@jvsena42
  1. Remove the TabBar Animation Cutoff

The current TabBar (in lack of a better word, the name of the buttons at the bottom) slides back up when the sheet is dismissed, but it does it with an effect that looks more like a cut (again, slow motion is best to look at it in the recording). It shouldn't be hard to do something like iOS does when navigating to Settings, where it actually really offsets the TabBar to the bottom until it's no longer visible on the screen, then it could be removed from the composition if desired. And vice versa to bring it back.
Or simply render the sheet above the TabBar, like we used to do.

The TaBar had to be lifted to the parent compose to adapt the navigation when the TopBar was updated. Couldn't render the sheet above the tabor because of the parent composable structure. I can look for a fix in other branch to don't extend this PR too much

Originally posted by @jvsena42 in #485 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions