fix: reconnect custom channel peers after migration#784
Draft
fix: reconnect custom channel peers after migration#784
Conversation
Member
Author
|
Draft for testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #772
This PR reconnects custom channel peers after migrating from the React Native app by fetching the peers list from the RN remote backup on first node start.
Description
After migrating from RN Bitkit, custom Lightning channels (opened manually or via LNURL with non-LSP nodes) are restored from backup but the app doesn't reconnect to those channel counterparties. Without the peer connection, those channels are unusable.
The fix adds a one-time peer recovery step that runs after the node starts and trusted peers connect:
peers.jsonfrom the RN remote backup serverpersist: trueso ldk-node remembers them for future startsThis is a port of the iOS fix in synonymdev/bitkit-ios#436.
Preview
N/A - no UI changes.
QA Notes
1. Migration with custom channels
Migration peer recovery: fetched N peer(s) from remote backup2. No migration - no side effects
3. One-time execution