Merge pull request #73 from synonymdev/test/send2

Test/send

Author: piotr-iohk

test/specs/boost.e2e.ts

@@ -192,7 +192,7 @@ describe('@boost - Boost', () => {
     await tap('RecommendedFeeButton');
     await dragOnElement('GRAB', 'right', 0.95); // Swipe to confirm
     await waitForToast('BoostSuccessToast');
-    
+
     // check Activity
     await elementById('BoostingIcon').waitForDisplayed();
     await elementById('ActivityShort-0').waitForDisplayed();

test/specs/lightning.e2e.ts

@@ -166,7 +166,9 @@ describe('@lightning - Lightning', () => {
     await expect(totalBalance).toHaveText('11 000'); // 1k onchain + 10k lightning
     await expectTextWithin('ActivitySpending', '10 000');
 
-    await console.info('send lightning payment (lightning invoice with amount = 1000) and manually added tag');
+    await console.info(
+      'send lightning payment (lightning invoice with amount = 1000) and manually added tag'
+    );
     const value = '1000';
     const { paymentRequest: invoice4 } = await lnd.addInvoice({
       value: value,

test/specs/lnurl.e2e.ts

@@ -197,6 +197,7 @@ describe('@lnurl - LNURL', () => {
       await expectTextWithin('ActivityShort-0', 'Sent');
 
       // --- skip due to: https://github.com/synonymdev/bitkit-android/issues/417 ---//
+      //                  https://github.com/synonymdev/bitkit-ios/issues/277
       // await tap('ActivityShort-0');
       // await elementById('InvoiceComment').waitForDisplayed();
       // await expectTextWithin('InvoiceComment', 'test comment');

test/specs/send.e2e.ts

@@ -22,6 +22,8 @@ import {
   doNavigationClose,
   waitForToast,
   acceptAppNotificationAlert,
+  dismissBackgroundPaymentsTimedSheet,
+  acknowledgeReceivedPayment,
 } from '../helpers/actions';
 import { bitcoinURL, lndConfig } from '../helpers/constants';
 import { reinstallApp } from '../helpers/setup';
@@ -193,10 +195,13 @@ describe('@send - Send', () => {
     // console.info(JSON.stringify(dec, null, 2));
     const response = await lnd.sendPaymentSync({ paymentRequest: receive, amt: '10000' });
     console.info({ response });
-    await elementById('ReceivedTransaction').waitForDisplayed();
-    await tap('ReceivedTransactionButton');
-    await sleep(500);
-    await dismissQuickPayIntro();
+    await acknowledgeReceivedPayment();
+    if (driver.isIOS) {
+      await dismissBackgroundPaymentsTimedSheet({ triggerTimedSheet: driver.isIOS });
+      await dismissQuickPayIntro({ triggerTimedSheet: driver.isIOS });
+    } else {
+      await dismissQuickPayIntro();
+    }
 
     const totalBalance = await elementByIdWithin('TotalBalance-primary', 'MoneyText');
     await expect(totalBalance).toHaveText('110 000'); // 100k onchain + 10k lightning
@@ -363,10 +368,12 @@ describe('@send - Send', () => {
     await sleep(1000);
     await enterAddress(unified4, { acceptCameraPermission: false });
     // max amount (lightning)
-    await expectText('6 000', { strategy: 'contains' }); // current balance 8k - 1k reserve balance
+    // Android shows raw `maxSendLightningSats` (7k - 1k reserve = 6k).
+    // iOS subtracts an estimated routing fee which includes a hardcoded 2 sat buffer (see SendAmountView.calculateRoutingFee()).
+    await expectText(driver.isIOS ? '5 998' : '6 000', { strategy: 'contains' });
     await tap('AssetButton-switch');
     // max amount (onchain)
-    await expectText('6 000', { visible: false, strategy: 'contains' });
+    await expectText(driver.isIOS ? '5 998' : '6 000', { visible: false, strategy: 'contains' });
     await tap('AssetButton-switch');
     await tap('N1');
     await multiTap('N0', 3);
@@ -391,15 +398,21 @@ describe('@send - Send', () => {
     // max amount (lightning)
     await tap('AvailableAmount');
     await tap('ContinueAmount');
-    await expectText('5 000', { strategy: 'contains' });
+    await expectText(driver.isIOS ? '4 998' : '5 000', { strategy: 'contains' });
     // expect toast about reserve balance
     await expectText('Reserve Balance');
     await tap('NavigationBack');
     // max amount (onchain)
     await tap('AssetButton-switch');
     await tap('AvailableAmount');
+    if (driver.isIOS) {
+      // iOS runs an autopilot coin selection step on Continue; when the amount is the true "max"
+      // this can fail with a "Coin selection failed" toast. We only care that onchain max isn't
+      // clamped to the Lightning max, so back off the exact-max edge case.
+      await tap('NRemove');
+    }
     await tap('ContinueAmount');
-    await expectText('5 000', { visible: false, strategy: 'contains' });
+    await expectText(driver.isIOS ? '4 998' : '5 000', { visible: false, strategy: 'contains' });
     await tap('NavigationBack');
     await multiTap('NRemove', 6);
     await tap('N1');
@@ -464,9 +477,7 @@ describe('@send - Send', () => {
     await swipeFullScreen('down');
     const r = await lnd.sendPaymentSync({ paymentRequest: receive2, amt: '10000' });
     console.info({ r });
-    await elementById('ReceivedTransaction').waitForDisplayed();
-    await tap('ReceivedTransactionButton');
-    await sleep(500);
+    await acknowledgeReceivedPayment();
     await expectTextWithin('ActivitySpending', '14 000');
 
     const { paymentRequest: invoice9 } = await lnd.addInvoice({ value: '10000' });