Verify lnurl amt rounding min/max edges #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
added
Android
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LNURL payment test to verify proper handling of min/max amount boundaries with edge case values that require rounding from millisatoshis to satoshis. The test now uses non-round msat values (149500 and 200999) to ensure the application correctly rounds amounts and enforces boundaries.
Key Changes:
- Updates minSendable from 100000 msats (100 sats) to 149500 msats (rounds to 150 sats)
- Updates maxSendable from 200000 msats (200 sats) to 200999 msats (rounds to 200 sats)
- Adjusts test assertions to verify 149 sats is rejected as too low while 150 sats is accepted
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Dec 17, 2025
Merged
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel: