fix(ui): numberpad: remove spaces from raw input

Author: pwltr

Bitkit/ViewModels/AmountInputViewModel.swift

@@ -96,8 +96,12 @@ class AmountInputViewModel: ObservableObject {
         amountSats = newAmountSats
         displayText = formatDisplayTextFromAmount(newAmountSats, currency: currency)
         // Update raw input text based on the formatted display
+        // Remove formatting separators (spaces for modern Bitcoin, commas for fiat)
         if currency.primaryDisplay == .fiat {
             rawInputText = displayText.replacingOccurrences(of: ",", with: "")
+        } else if currency.displayUnit == .modern {
+            // Modern Bitcoin uses spaces as grouping separators
+            rawInputText = displayText.replacingOccurrences(of: " ", with: "")
         } else {
             rawInputText = displayText
         }
@@ -115,8 +119,12 @@ class AmountInputViewModel: ObservableObject {
         if amountSats > 0 {
             displayText = formatDisplayTextFromAmount(amountSats, currency: currency)
             // Update raw input text based on the formatted display
+            // Remove formatting separators (spaces for modern Bitcoin, commas for fiat)
             if currency.primaryDisplay == .fiat {
                 rawInputText = displayText.replacingOccurrences(of: ",", with: "")
+            } else if currency.displayUnit == .modern {
+                // Modern Bitcoin uses spaces as grouping separators
+                rawInputText = displayText.replacingOccurrences(of: " ", with: "")
             } else {
                 rawInputText = displayText
             }
@@ -135,8 +143,14 @@ class AmountInputViewModel: ObservableObject {
                 // First convert fiat to sats, then format for Bitcoin display
                 let cleanFiat = currentRawInput.replacingOccurrences(of: ",", with: "")
                 if let fiatValue = Double(cleanFiat), let sats = currency.convert(fiatAmount: fiatValue) {
-                    rawInputText = formatBitcoinFromSats(sats, isModern: currency.displayUnit == .modern)
-                    displayText = rawInputText
+                    let formatted = formatBitcoinFromSats(sats, isModern: currency.displayUnit == .modern)
+                    displayText = formatted
+                    // Remove spaces from rawInputText for modern Bitcoin
+                    if currency.displayUnit == .modern {
+                        rawInputText = formatted.replacingOccurrences(of: " ", with: "")
+                    } else {
+                        rawInputText = formatted
+                    }
                 }
             }
         }

BitkitTests/NumberPadTests.swift

@@ -179,6 +179,50 @@ final class NumberPadTests: XCTestCase {
         XCTAssertEqual(viewModel.amountSats, 0)
     }
 
+    func testDeleteAfterMaxAmountModernBitcoin() {
+        let viewModel = AmountInputViewModel()
+        let currency = mockCurrency(primaryDisplay: .bitcoin, displayUnit: .modern)
+
+        // Set max amount using updateFromSats (simulates tapping max button)
+        // This creates formatted text with spaces (e.g., "100 000 000")
+        viewModel.updateFromSats(100_000_000, currency: currency)
+        XCTAssertEqual(viewModel.displayText, "100 000 000")
+        XCTAssertEqual(viewModel.amountSats, 100_000_000)
+
+        // Delete should remove digits, not spaces
+        // After first delete, should be "10 000 000" (one digit removed)
+        viewModel.handleNumberPadInput("delete", currency: currency)
+        XCTAssertEqual(viewModel.displayText, "10 000 000")
+        XCTAssertEqual(viewModel.amountSats, 10_000_000)
+
+        // Delete again
+        viewModel.handleNumberPadInput("delete", currency: currency)
+        XCTAssertEqual(viewModel.displayText, "1 000 000")
+        XCTAssertEqual(viewModel.amountSats, 1_000_000)
+
+        // Delete again
+        viewModel.handleNumberPadInput("delete", currency: currency)
+        XCTAssertEqual(viewModel.displayText, "100 000")
+        XCTAssertEqual(viewModel.amountSats, 100_000)
+    }
+
+    func testDeleteAfterMaxAmountFiat() {
+        let viewModel = AmountInputViewModel()
+        let currency = mockCurrency(primaryDisplay: .fiat)
+
+        // Set max amount using updateFromSats (simulates tapping max button)
+        // This creates formatted text with commas (e.g., "1,000.00")
+        viewModel.updateFromSats(100_000_000, currency: currency)
+        // Note: The actual display text depends on currency conversion, but it should have commas
+        let initialDisplay = viewModel.displayText
+        XCTAssertTrue(initialDisplay.contains(",") || initialDisplay.isEmpty == false)
+
+        // Delete should remove digits, not commas
+        viewModel.handleNumberPadInput("delete", currency: currency)
+        // After delete, the amount should decrease
+        XCTAssertLessThan(viewModel.amountSats, 100_000_000)
+    }
+
     // MARK: - Leading Zero Tests
 
     func testLeadingZeroBehavior() {