feat: save app and ldk logs to same file

Author: ovitrif

Bitkit/Services/LightningService.swift

@@ -8,7 +8,6 @@ import LDKNode
 class LightningService {
     private var node: Node?
     var currentWalletIndex: Int = 0
-    private var currentLogFilePath: String?
 
     private let syncStatusChangedSubject = PassthroughSubject<UInt64, Never>()
 
@@ -83,12 +82,7 @@ class LightningService {
         config.includeUntrustedPendingInSpendable = true
 
         let builder = Builder.fromConfig(config: config)
-
-        Logger.info("LDK-node log path: \(ldkStoragePath)")
-
-        let logFilePath = generateLogFilePath()
-        currentLogFilePath = logFilePath
-        builder.setFilesystemLogger(logFilePath: logFilePath, maxLogLevel: Env.ldkLogLevel)
+        builder.setCustomLogger(logWriter: LdkLogWriter())
 
         let resolvedElectrumServerUrl = electrumServerUrl ?? Env.electrumServerUrl
 
@@ -604,11 +598,7 @@ class LightningService {
     }
 
     func dumpLdkLogs() {
-        guard let logFilePath = currentLogFilePath else {
-            Logger.error("No log file path available")
-            return
-        }
-
+        let logFilePath = Logger.sessionLogFile
         let fileURL = URL(fileURLWithPath: logFilePath)
 
         do {
@@ -644,32 +634,6 @@ class LightningService {
         return "Nodes: \(allNodes.count), Last Synced: \(lastRgsSyncString)"
     }
 
-    // MARK: Logging helpers
-
-    private func generateLogFilePath() -> String {
-        let dateFormatter = DateFormatter()
-        dateFormatter.dateFormat = "yyyy-MM-dd_HH-mm-ss"
-        dateFormatter.timeZone = TimeZone(abbreviation: "UTC")
-        let timestamp = dateFormatter.string(from: Date())
-
-        let baseDir = Env.logDirectory
-        let contextPrefix = Env.currentExecutionContext.filenamePrefix
-        let logFilePath = "\(baseDir)/ldk_\(contextPrefix)_\(timestamp).log"
-
-        // Create directory if it doesn't exist
-        let directory = URL(fileURLWithPath: baseDir)
-        if !FileManager.default.fileExists(atPath: directory.path) {
-            do {
-                try FileManager.default.createDirectory(at: directory, withIntermediateDirectories: true)
-            } catch {
-                Logger.error("Failed to create log directory: \(error)")
-            }
-        }
-
-        Logger.debug("Generated LDK log file path: \(logFilePath)")
-        return logFilePath
-    }
-
     // MARK: - Configuration Helpers
 
     private func configureGossipSource(builder: Builder, rgsServerUrl: String?) {

Bitkit/Utilities/Logger.swift

@@ -1,4 +1,7 @@
 import Foundation
+import LDKNode
+
+// MARK: - Logger
 
 class Logger {
     private init() {}
@@ -96,7 +99,7 @@ class Logger {
         }
     }
 
-    // Cleans up both bitkit and ldk log files
+    // Cleans up log files
     static func cleanUpOldLogFiles(maxTotalSizeMB: Int = 20) {
         queue.async {
             let baseDir = Env.logDirectory
@@ -148,3 +151,49 @@ class Logger {
         }
     }
 }
+
+// MARK: - LogLevel
+
+extension LogLevel: Comparable {
+    public static func < (lhs: LogLevel, rhs: LogLevel) -> Bool {
+        lhs.order < rhs.order
+    }
+
+    private var order: Int {
+        switch self {
+        case .gossip: return 1
+        case .trace: return 2
+        case .debug: return 3
+        case .info: return 4
+        case .warn: return 5
+        case .error: return 6
+        }
+    }
+}
+
+// MARK: - LdkLogWriter
+
+final class LdkLogWriter: LogWriter {
+    private let maxLogLevel: LogLevel
+
+    init(maxLogLevel: LogLevel = Env.ldkLogLevel) {
+        self.maxLogLevel = maxLogLevel
+    }
+
+    func log(record: LogRecord) {
+        guard record.level >= maxLogLevel else { return }
+
+        let context = "[LDK] [\(record.modulePath):\(record.line)]"
+
+        switch record.level {
+        case .gossip, .trace, .debug:
+            Logger.debug(record.args, context: context)
+        case .info:
+            Logger.info(record.args, context: context)
+        case .warn:
+            Logger.warn(record.args, context: context)
+        case .error:
+            Logger.error(record.args, context: context)
+        }
+    }
+}