refactor: rename LnurlAmountConversion to LightningAmountConversion

Author: piotr-iohk

…it/Utilities/LnurlAmountConversion.swift …tilities/LightningAmountConversion.swiftBitkit/Utilities/LnurlAmountConversion.swift renamed to Bitkit/Utilities/LightningAmountConversion.swift Bitkit/Utilities/LnurlAmountConversion.swift renamed to Bitkit/Utilities/LightningAmountConversion.swift

@@ -1,10 +1,10 @@
 import Foundation
 
-enum LnurlAmountConversion {
-    /// LNURL `minSendable` / `maxSendable` values are expressed in millisatoshis (msat).
+enum LightningAmountConversion {
+    /// Lightning amounts are commonly expressed in millisatoshis (msat).
     ///
     /// The UI and amount input operate in whole sats. When converting a minimum bound to sats we must round up:
-    /// `minSendable = 100500 msat` means the minimum payable amount is `101 sat` (not `100 sat`).
+    /// `100500 msat` means the minimum payable amount is `101 sat` (not `100 sat`).
     static func satsCeil(fromMsats msats: UInt64) -> UInt64 {
         let quotient = msats / Env.msatsPerSat
         let remainder = msats % Env.msatsPerSat

Bitkit/ViewModels/AppViewModel.swift

@@ -253,8 +253,8 @@ extension AppViewModel {
         }
 
         var normalizedData = data
-        normalizedData.minSendable = max(1, LnurlAmountConversion.satsCeil(fromMsats: normalizedData.minSendable))
-        normalizedData.maxSendable = max(normalizedData.minSendable, LnurlAmountConversion.satsFloor(fromMsats: normalizedData.maxSendable))
+        normalizedData.minSendable = max(1, LightningAmountConversion.satsCeil(fromMsats: normalizedData.minSendable))
+        normalizedData.maxSendable = max(normalizedData.minSendable, LightningAmountConversion.satsFloor(fromMsats: normalizedData.maxSendable))
 
         // Check if user has enough lightning balance to pay the minimum amount
         let lightningBalance = lightningService.balances?.totalLightningBalanceSats ?? 0
@@ -292,8 +292,8 @@ extension AppViewModel {
         }
 
         var normalizedData = data
-        let minSats = max(1, LnurlAmountConversion.satsCeil(fromMsats: minMsats))
-        let maxSats = max(minSats, LnurlAmountConversion.satsFloor(fromMsats: maxMsats))
+        let minSats = max(1, LightningAmountConversion.satsCeil(fromMsats: minMsats))
+        let maxSats = max(minSats, LightningAmountConversion.satsFloor(fromMsats: maxMsats))
         normalizedData.minWithdrawable = minSats
         normalizedData.maxWithdrawable = maxSats
 

BitkitTests/LightningAmountConversionTests.swift

@@ -0,0 +1,20 @@
+@testable import Bitkit
+import XCTest
+
+final class LightningAmountConversionTests: XCTestCase {
+    func testSatsCeilRoundsUpWhenNotDivisibleBy1000() {
+        XCTAssertEqual(LightningAmountConversion.satsCeil(fromMsats: 100_500), 101)
+        XCTAssertEqual(LightningAmountConversion.satsCeil(fromMsats: 1500), 2)
+    }
+
+    func testSatsCeilKeepsExactSatAmounts() {
+        XCTAssertEqual(LightningAmountConversion.satsCeil(fromMsats: 100_000), 100)
+        XCTAssertEqual(LightningAmountConversion.satsCeil(fromMsats: 0), 0)
+    }
+
+    func testSatsFloorRoundsDown() {
+        XCTAssertEqual(LightningAmountConversion.satsFloor(fromMsats: 100_999), 100)
+        XCTAssertEqual(LightningAmountConversion.satsFloor(fromMsats: 100_000), 100)
+        XCTAssertEqual(LightningAmountConversion.satsFloor(fromMsats: 0), 0)
+    }
+}