Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Jan 1, 2026

Description

This PR lets the user use existing blocktank channels even when geoblocked

Testing scenarions:

  • User with purchased channels before geo-blocking → Can still use them
  • User is geo-blocked with no channels → CJIT onboarding shown, cannot create new channels
  • User has ready channels (any type) → Can receive Lightning payments regardless of geo-blocking

Linked Issues/Tasks

Closes #244

Screenshot / Video

geoblocked-cjit.mp4
geoblocked-tranffer-not-displayed.mp4

@jvsena42 jvsena42 self-assigned this Jan 1, 2026
@jvsena42 jvsena42 requested a review from Copilot January 1, 2026 12:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where users with purchased Blocktank channels were incorrectly blocked from using them when geoblocked. The fix simplifies the logic by checking for any ready channels instead of distinguishing between LSP and non-LSP channels.

Key Changes

  • Replaced geoblocking logic that prevented usage of Blocktank channels with a simpler check for any ready channels
  • Unified the hasUsableChannels logic across receive and invoice creation flows
  • Removed unnecessary hasNonLspChannels() method calls in favor of checking isChannelReady status

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Bitkit/Views/Wallets/Receive/ReceiveQr.swift Simplified hasUsableChannels to check for any ready channels, updated CJIT onboarding logic to use the unified check, and modified geoblocking condition to use hasUsableChannels
Bitkit/ViewModels/WalletViewModel.swift Replaced complex geoblocking channel check with simple isChannelReady verification for invoice creation

@jvsena42 jvsena42 marked this pull request as draft January 1, 2026 12:45
@jvsena42 jvsena42 marked this pull request as ready for review January 1, 2026 12:58
@jvsena42 jvsena42 requested a review from Copilot January 1, 2026 12:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

@jvsena42 jvsena42 requested a review from pwltr January 1, 2026 13:54
@jvsena42
Copy link
Member Author

jvsena42 commented Jan 1, 2026

waiting staging nodes to run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't block purchased LN channels

2 participants