-
Notifications
You must be signed in to change notification settings - Fork 1
fix: don't block purchased channels when geoblocked #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where users with purchased Blocktank channels were incorrectly blocked from using them when geoblocked. The fix simplifies the logic by checking for any ready channels instead of distinguishing between LSP and non-LSP channels.
Key Changes
- Replaced geoblocking logic that prevented usage of Blocktank channels with a simpler check for any ready channels
- Unified the
hasUsableChannelslogic across receive and invoice creation flows - Removed unnecessary
hasNonLspChannels()method calls in favor of checkingisChannelReadystatus
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Bitkit/Views/Wallets/Receive/ReceiveQr.swift | Simplified hasUsableChannels to check for any ready channels, updated CJIT onboarding logic to use the unified check, and modified geoblocking condition to use hasUsableChannels |
| Bitkit/ViewModels/WalletViewModel.swift | Replaced complex geoblocking channel check with simple isChannelReady verification for invoice creation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
|
waiting staging nodes to run again |
Description
This PR lets the user use existing blocktank channels even when geoblocked
Testing scenarions:
Linked Issues/Tasks
Closes #244
Screenshot / Video
geoblocked-cjit.mp4
geoblocked-tranffer-not-displayed.mp4