refactor: remove TRUSTED_ZERO_CONF_PEERS from environment templates and related code

Author: pwltr

.env.development.template

@@ -17,9 +17,6 @@ ELECTRUM_REGTEST_TCP_PORT=18483
 ELECTRUM_REGTEST_SSL_PORT=18484
 ELECTRUM_REGTEST_PROTO=tcp
 
-# format: "<pubkey>,<pubkey>,..."
-TRUSTED_ZERO_CONF_PEERS="028a8910b0048630d4eb17af25668cdd7ea6f2d8ae20956e7a06e2ae46ebcb69fc,0296b2db342fcf87ea94d981757fdf4d3e545bd5cef4919f58b5d38dfdd73bf5c9,03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a,039b8b4dd1d88c2c5db374290cda397a8f5d79f312d6ea5d5bfdfc7c6ff363eae3,03342eac98d8c07ac8a4f303b2ad09a34b3350357730013d534d0537a4d1d8a14d,03816141f1dce7782ec32b66a300783b1d436b19777e7c686ed00115bd4b88ff4b"
-
 # Default Slashtags Web Relay
 WEB_RELAY=https://dht-relay.synonym.to/staging/web-relay
 

.env.production.template

@@ -17,9 +17,6 @@ ELECTRUM_REGTEST_TCP_PORT=18483
 ELECTRUM_REGTEST_SSL_PORT=18484
 ELECTRUM_REGTEST_PROTO=tcp
 
-# format: "<pubkey>,<pubkey>,..."
-TRUSTED_ZERO_CONF_PEERS="039b8b4dd1d88c2c5db374290cda397a8f5d79f312d6ea5d5bfdfc7c6ff363eae3,03816141f1dce7782ec32b66a300783b1d436b19777e7c686ed00115bd4b88ff4b,02a371038863605300d0b3fc9de0cf5ccb57728b7f8906535709a831b16e311187"
-
 # Default Slashtags Web Relay
 WEB_RELAY=https://webrelay.slashtags.to
 

.env.test.template

@@ -17,9 +17,6 @@ ELECTRUM_REGTEST_TCP_PORT=60001
 ELECTRUM_REGTEST_SSL_PORT=60002
 ELECTRUM_REGTEST_PROTO=tcp
 
-# format: "<pubkey>,<pubkey>,..."
-TRUSTED_ZERO_CONF_PEERS=""
-
 # Default Slashtags Web Relay
 WEB_RELAY=https://dht-relay.synonym.to/staging/web-relay
 

src/@types/env.d.ts

@@ -11,8 +11,6 @@ declare module '@env' {
 	export const ELECTRUM_REGTEST_TCP_PORT: number;
 	export const ELECTRUM_REGTEST_PROTO: string;
 
-	export const TRUSTED_ZERO_CONF_PEERS: string;
-
 	export const WEB_RELAY: string;
 	export const TREASURE_HUNT_HOST: string;
 	export const CHATWOOT_API: string;

src/constants/env.ts

@@ -16,7 +16,6 @@ import {
 	ENABLE_REDUX_IMMUTABLE_CHECK,
 	ENABLE_REDUX_LOGGER,
 	TREASURE_HUNT_HOST,
-	TRUSTED_ZERO_CONF_PEERS,
 	WEB_RELAY,
 } from '@env';
 import { isProtocol } from '../store/types/settings';
@@ -57,19 +56,14 @@ export const __BACKUPS_SERVER_PUBKEY__ = BACKUPS_SERVER_PUBKEY;
 
 export const __BLOCKTANK_HOST__ = BLOCKTANK_HOST;
 
+export const __DEFAULT_BITCOIN_NETWORK__ = DEFAULT_BITCOIN_NETWORK;
+
 export const __ELECTRUM_REGTEST_HOST__ = ELECTRUM_REGTEST_HOST;
 export const __ELECTRUM_REGTEST_SSL_PORT__ = ELECTRUM_REGTEST_SSL_PORT;
 export const __ELECTRUM_REGTEST_TCP_PORT__ = ELECTRUM_REGTEST_TCP_PORT;
 export const __ELECTRUM_REGTEST_PROTO__ = ELECTRUM_REGTEST_PROTO;
 
-export const __TREASURE_HUNT_HOST__ = TREASURE_HUNT_HOST;
-
-export const __TRUSTED_ZERO_CONF_PEERS__ = TRUSTED_ZERO_CONF_PEERS.split(
-	',',
-).map((nodeId) => nodeId.trim());
-
-export const __DEFAULT_BITCOIN_NETWORK__ = DEFAULT_BITCOIN_NETWORK;
-
-export const __E2E__ = E2E === 'true';
 export const __WEB_RELAY__ = WEB_RELAY;
+export const __TREASURE_HUNT_HOST__ = TREASURE_HUNT_HOST;
 export const __CHATWOOT_API__ = CHATWOOT_API;
+export const __E2E__ = E2E === 'true';

src/utils/lightning/index.ts

@@ -40,7 +40,6 @@ import Keychain from 'react-native-keychain';
 import {
 	__BACKUPS_SERVER_HOST__,
 	__BACKUPS_SERVER_PUBKEY__,
-	__TRUSTED_ZERO_CONF_PEERS__,
 } from '../../constants/env';
 import { sendNavigation } from '../../navigation/bottom-sheet/SendNavigation';
 import {
@@ -1712,9 +1711,7 @@ export const addTrustedPeers = async (): Promise<Result<string>> => {
 	const btInfo = await getBlocktankInfo(true);
 	const btNodeIds = btInfo.nodes.map((n) => n.pubkey);
 
-	await lm.setTrustedZeroConfPeerNodeIds(
-		Array.from(new Set([...btNodeIds, ...__TRUSTED_ZERO_CONF_PEERS__])),
-	);
+	await lm.setTrustedZeroConfPeerNodeIds(btNodeIds);
 	return ok('Trusted peers added.');
 };