fix: check mempool fees before starting LDK

Author: limpbrains

src/navigation/bottom-sheet/SendNavigation.tsx

@@ -117,7 +117,7 @@ const SendNavigation = (): ReactElement => {
 
 	const onOpen = async (): Promise<void> => {
 		if (!transaction?.lightningInvoice) {
-			await updateOnchainFeeEstimates({ selectedNetwork, forceUpdate: true });
+			await updateOnchainFeeEstimates({ forceUpdate: true });
 			if (!transaction?.inputs.length) {
 				await setupOnChainTransaction();
 			}

src/screens/Settings/AddressViewer/index.tsx

@@ -750,13 +750,8 @@ const AddressViewer = ({
 			// Switching networks requires us to reset LDK.
 			await setupLdk({ selectedWallet, selectedNetwork });
 			// Start wallet services with the newly selected network.
-			await startWalletServices({
-				selectedNetwork: config.selectedNetwork,
-			});
-			await updateOnchainFeeEstimates({
-				selectedNetwork: config.selectedNetwork,
-				forceUpdate: true,
-			});
+			await startWalletServices({ selectedNetwork: config.selectedNetwork });
+			await updateOnchainFeeEstimates({ forceUpdate: true });
 			updateActivityList();
 			await syncLedger();
 		}

src/store/actions/wallet.ts

@@ -663,7 +663,6 @@ export const setWalletData = async <K extends keyof IWalletData>(
 			case 'feeEstimates': {
 				const feeEstimates = data2 as IWalletData[typeof value];
 				updateOnchainFeeEstimates({
-					selectedNetwork: getNetworkFromBeignet(network),
 					feeEstimates,
 					forceUpdate: true,
 				});

src/store/utils/fees.ts

@@ -1,20 +1,14 @@
-import { ok, err, Result } from '@synonymdev/result';
+import { IOnchainFees } from 'beignet';
+import { Result, err, ok } from '@synonymdev/result';
 
+import { getOnChainWalletAsync } from '../../utils/wallet';
 import { dispatch, getFeesStore } from '../helpers';
 import { updateOnchainFees } from '../slices/fees';
-import { getFeeEstimates } from '../../utils/wallet/transactions';
-import { EAvailableNetwork } from '../../utils/networks';
-import { getOnChainWalletAsync, getSelectedNetwork } from '../../utils/wallet';
-import { IOnchainFees } from 'beignet';
-
-export const REFRESH_INTERVAL = 60 * 30; // in seconds, 30 minutes
 
 export const updateOnchainFeeEstimates = async ({
-	selectedNetwork = getSelectedNetwork(),
 	forceUpdate = false,
 	feeEstimates,
 }: {
-	selectedNetwork: EAvailableNetwork;
 	forceUpdate?: boolean;
 	feeEstimates?: IOnchainFees;
 }): Promise<Result<string>> => {
@@ -24,12 +18,7 @@ export const updateOnchainFeeEstimates = async ({
 	}
 
 	if (!feeEstimates) {
-		const timestamp = feesStore.onchain.timestamp;
-		const difference = Math.floor((Date.now() - timestamp) / 1000);
-		if (!forceUpdate && difference < REFRESH_INTERVAL) {
-			return ok('On-chain fee estimates are up to date.');
-		}
-		const feeEstimatesRes = await getFeeEstimates(selectedNetwork);
+		const feeEstimatesRes = await refreshOnchainFeeEstimates({ forceUpdate });
 		if (feeEstimatesRes.isErr()) {
 			return err(feeEstimatesRes.error);
 		}

src/utils/helpers.ts

@@ -5,6 +5,12 @@ import ReactNativeHapticFeedback from 'react-native-haptic-feedback';
 
 import { i18nTime } from '../utils/i18n';
 
+/**
+ * Returns the result of a promise, or an error if the promise takes too long to resolve.
+ * @param {number} ms The time to wait in milliseconds.
+ * @param {Promise<any>} promise The promise to resolve.
+ * @returns {Promise<T>}
+ */
 export const promiseTimeout = <T>(
 	ms: number,
 	promise: Promise<any>,

src/utils/lightning/index.ts

@@ -4,7 +4,7 @@ import * as bitcoin from 'bitcoinjs-lib';
 import ecc from '@bitcoinerlab/secp256k1';
 import RNFS from 'react-native-fs';
 import { err, ok, Result } from '@synonymdev/result';
-import { EPaymentType, TGetAddressHistory } from 'beignet';
+import { EPaymentType, IOnchainFees, TGetAddressHistory } from 'beignet';
 import lm, {
 	ldk,
 	defaultUserConfig,
@@ -234,7 +234,12 @@ const getScriptPubKeyHistory = async (
 };
 
 const getFees: TGetFees = async () => {
-	const fees = getFeesStore().onchain;
+	const res = await promiseTimeout<Result<IOnchainFees>>(
+		2000,
+		refreshOnchainFeeEstimates({}),
+	);
+	const fees = res.isOk() ? res.value : getFeesStore().onchain;
+
 	return {
 		//https://github.com/lightningdevkit/rust-lightning/blob/main/CHANGELOG.md#api-updates
 		onChainSweep: fees.fast,
@@ -335,6 +340,20 @@ export const setupLdk = async ({
 			return err(backupRes.error);
 		}
 
+		// force fetch fees if they are older than 20 minutes
+		let attempts = 0;
+		while (
+			Date.now() - getFeesStore().onchain.timestamp > 20 * 60 * 1000 &&
+			!getFeesStore().override
+		) {
+			if (attempts > 4) {
+				return err('Failed to fetch on-chain fees');
+			}
+			await refreshOnchainFeeEstimates({});
+			await sleep(100); // give Beignet time to propagate the new fees
+			attempts++;
+		}
+
 		const lmStart = await lm.start({
 			account: account.value,
 			getFees,

src/utils/wallet/transactions.ts

@@ -887,6 +887,7 @@ export const broadcastBoost = async ({
  */
 export const getFeeEstimates = async (
 	selectedNetwork: EAvailableNetwork = getSelectedNetwork(),
+	forceUpdate: boolean,
 ): Promise<Result<IOnchainFees>> => {
 	try {
 		if (__E2E__) {
@@ -904,11 +905,11 @@ export const getFeeEstimates = async (
 		}
 
 		const wallet = await getOnChainWalletAsync();
-		const feeRes = await wallet.getFeeEstimates();
-		if (!feeRes) {
-			return err('Unable to get fee estimates.');
+		const feeRes = await wallet.updateFeeEstimates(forceUpdate);
+		if (feeRes.isErr()) {
+			return err(feeRes.error);
 		}
-		return ok(feeRes);
+		return ok(feeRes.value);
 	} catch (e) {
 		return err(e);
 	}