Skip to content

Commit 47c6bad

Browse files
committed
feat: use gobley v0.2.0 from fixed fork
1 parent 3702cfa commit 47c6bad

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

bindings/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## Generating the Bindings
22

3+
## Build All Bindings
34
Run in the root dir:
45
```sh
56
RUSTFLAGS="--cfg no_download" cargo build && ./scripts/uniffi_bindgen_generate.sh && ./scripts/swift_create_xcframework_archive.sh && sh scripts/uniffi_bindgen_generate_kotlin_android.sh
@@ -11,7 +12,7 @@ Detailed instructions for publishing a new version of the bindings.
1112

1213
1. Update `Cargo.toml`
1314
2. Update `libraryVersion` in `bindings/kotlin/ldk-node-android/gradle.properties`
14-
3. Run the command to generate all bindings
15+
3. Run the above command to build all bindings
1516
4. Open a PR with the changes
1617
5. Create a new GitHub release with a new tag like `v0.1.0`, uploading the following files:
1718
- `bindings/swift/LDKNodeFFI.xcframework.zip`

scripts/uniffi_bindgen_generate_kotlin_android.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,9 @@ TARGET_DIR="target"
55
PROJECT_DIR="ldk-node-android"
66
ANDROID_LIB_DIR="$BINDINGS_DIR/$PROJECT_DIR"
77

8-
# Ensure gobley-uniffi-bindgen is installed from fork
9-
if ! command -v gobley-uniffi-bindgen &> /dev/null; then
10-
echo "Installing gobley-uniffi-bindgen fork..."
11-
cargo install --git https://github.com/ovitrif/gobley.git --branch main gobley-uniffi-bindgen
12-
fi
8+
# Install gobley-uniffi-bindgen from fork with patched version
9+
echo "Installing gobley-uniffi-bindgen fork..."
10+
cargo install --git https://github.com/ovitrif/gobley.git --branch fix-v0.2.0 gobley-uniffi-bindgen --force
1311
UNIFFI_BINDGEN_BIN="gobley-uniffi-bindgen"
1412

1513
export_variable_if_not_present() {

0 commit comments

Comments
 (0)