feat: add routing fee estimation #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add estimate_routing_fees methods to Bolt11Payment for calculating Lightning routing fees - estimate_routing_fees(): Calculate fees for regular invoices - estimate_routing_fees_using_amount(): Calculate fees for zero-amount invoices
ovitrif
approved these changes
Sep 4, 2025
ovitrif
reviewed
Sep 4, 2025
- Reverts electrum-client version change back to 0.24.0 - Rebuilds bindings
- Updates version to 0.6.2-rc.3 - Updates bindings accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds routing fee estimation methods to
Bolt11Paymentfor calculating Lightning routing fees:estimate_routing_fees(): Calculate fees for regular invoicesestimate_routing_fees_using_amount(): Calculate fees for zero-amount invoicesRouteNotFounderror variant for cases where routing fails