Merge pull request #9 from synonymdev/e2e-tests

E2e iOS tests

Author: coreyphillips

.github/scripts/test-ios.sh

@@ -0,0 +1,14 @@
+#!/bin/bash
+
+set -eo pipefail
+
+#Start metro server
+yarn start &
+P1=$!
+#perform tests
+yarn e2e:ios-test &
+P2=$!
+#wait for tests to finish
+wait $P2
+#kill metro server
+kill $P1

.github/workflows/e2e-ios.yml

@@ -0,0 +1,76 @@
+name: e2e-ios
+
+on:
+  pull_request:
+    branches:
+      - 'master'
+
+jobs:
+  e2e-test:
+    name: E2E iOS test
+    runs-on: macOS-latest
+    timeout-minutes: 35
+
+    steps:
+      - name: Check out Git repository
+        uses: actions/checkout@v2
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v1
+        with:
+          node-version: 14
+
+      - name: Cache lib node modules
+        uses: actions/cache@v3
+        id: lib-npmcache
+        with:
+          path: node_modules
+          key: node-modules-${{ hashFiles('**/yarn.lock') }}
+
+      - name: Install lib dependencies
+        if: steps.lib-npmcache.outputs.cache-hit != 'true'
+        run: yarn install
+
+      - name: Build lib
+        run: yarn build
+
+      - name: Cache app node modules
+        uses: actions/cache@v3
+        id: app-npmcache
+        with:
+          path: example/node_modules
+          key: node-modules-${{ hashFiles('**/yarn.lock') }}
+
+      - name: Rebuild detox
+        if: steps.app-npmcache.outputs.cache-hit == 'true'
+        working-directory: example
+        run: yarn detox clean-framework-cache && yarn detox build-framework-cache
+
+      - name: Install app dependencies
+        if: steps.app-npmcache.outputs.cache-hit != 'true'
+        working-directory: example
+        run: yarn install
+
+      - name: Cache Pods
+        uses: actions/cache@v3
+        id: podcache
+        with:
+          path: example/ios/Pods
+          key: pods-${{ hashFiles('**/Podfile.lock') }}
+
+      - name: Install pods and rn-nodify
+        working-directory: example
+        run: |
+          gem update cocoapods xcodeproj
+          yarn rn-setup
+
+      - name: Install brew dependencies
+        run: brew tap wix/brew && brew install applesimutils
+
+      - name: Build iOS app
+        working-directory: example
+        run: yarn e2e:ios-build
+
+      - name: Test iOS app
+        working-directory: example
+        run: sh ../.github/scripts/test-ios.sh

.github/workflows/lint-check.yml

@@ -24,9 +24,3 @@ jobs:
 
       - name: Lint check
         run: yarn lint:check
-
-      - name: Run linters
-        uses: tinovyatkin/action-eslint@v1
-        with:
-          repo-token: ${{secrets.GITHUB_TOKEN}}
-          check-name: eslint

.gitignore

@@ -8,3 +8,5 @@ android/build/
 android/local.properties
 android/.gradle/
 yarn-error.log
+example/.watchman*
+example/*.log

android/build.gradle

@@ -29,7 +29,7 @@ def getExtOrIntegerDefault(name) {
 android {
   compileSdkVersion getExtOrIntegerDefault('compileSdkVersion')
   defaultConfig {
-    minSdkVersion 16
+    minSdkVersion 21
     targetSdkVersion getExtOrIntegerDefault('targetSdkVersion')
     versionCode 1
     versionName "1.0"

example/.eslintrc.js

@@ -2,6 +2,9 @@ module.exports = {
 	root: true,
 	extends: '@react-native-community',
 	parser: '@typescript-eslint/parser',
+	env: {
+		jest: true,
+	},
 	plugins: ['@typescript-eslint'],
 	globals: {
 		localStorage: false,

example/App.tsx

@@ -56,6 +56,7 @@ const App = (): ReactElement => {
 			<ScrollView
 				contentInsetAdjustmentBehavior="automatic"
 				style={styles.scrollView}>
+				<Text style={styles.text}>react-native-ldk</Text>
 				<View style={styles.messageContainer}>
 					<Text style={styles.text}>{message}</Text>
 				</View>
@@ -264,6 +265,24 @@ const App = (): ReactElement => {
 							setMessage(ldkVersion.value.ldk);
 						}}
 					/>
+
+					<Button
+						title={'E2E test'}
+						onPress={async (): Promise<void> => {
+							//TODO add more functionality to test
+							const ldkVersion = await ldk.version();
+							if (ldkVersion.isErr()) {
+								return setMessage(ldkVersion.error.message);
+							}
+
+							const nodeIdRes = await ldk.nodeId();
+							if (nodeIdRes.isErr()) {
+								return setMessage(nodeIdRes.error.message);
+							}
+
+							return setMessage('e2e success');
+						}}
+					/>
 				</View>
 			</ScrollView>
 		</SafeAreaView>

example/android/app/build.gradle

@@ -143,6 +143,10 @@ android {
         multiDexEnabled true
         buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()
 
+        testBuildType System.getProperty('testBuildType', 'debug')  // This will later be used to control the test apk build type
+        testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
+        missingDimensionStrategy 'detox', 'full'
+
         if (isNewArchitectureEnabled()) {
             // We configure the NDK build only if you decide to opt-in for the New Architecture.
             externalNativeBuild {
@@ -240,6 +244,7 @@ android {
             signingConfig signingConfigs.debug
             minifyEnabled enableProguardInReleaseBuilds
             proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
+            proguardFile "${rootProject.projectDir}/../node_modules/detox/android/detox/proguard-rules-app.pro" // Detox
         }
     }
 
@@ -262,6 +267,8 @@ android {
 
 dependencies {
     implementation files("../../node_modules/@synonymdev/react-native-ldk/android/libs/LDK-release.aar")
+    androidTestImplementation(project(path: ":detox"))
+    implementation 'androidx.appcompat:appcompat:1.4.2'
     implementation fileTree(dir: "libs", include: ["*.jar"])
 
     //noinspection GradleDynamicVersion

example/android/app/src/androidTest/java/com/example/DetoxTest.java

@@ -0,0 +1,35 @@
+package com.example;
+
+import com.wix.detox.Detox;
+import com.wix.detox.config.DetoxConfig;
+
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import androidx.test.ext.junit.runners.AndroidJUnit4;
+import androidx.test.filters.LargeTest;
+import androidx.test.rule.ActivityTestRule;
+
+@RunWith(AndroidJUnit4.class)
+@LargeTest
+public class DetoxTest {
+    // Replace 'MainActivity' with the value of android:name entry in
+    // <activity> in AndroidManifest.xml
+    @Rule
+    public ActivityTestRule<MainActivity> mActivityRule = new ActivityTestRule<>(MainActivity.class, false, false);
+
+    @Test
+    public void runDetoxTests() {
+        // This is optional - in case you've decided to integrate TestButler
+        // See https://github.com/wix/Detox/blob/master/docs/Introduction.Android.md#8-test-butler-support-optional
+//        TestButlerProbe.assertReadyIfInstalled();
+
+        DetoxConfig detoxConfig = new DetoxConfig();
+        detoxConfig.idlePolicyConfig.masterTimeoutSec = 90;
+        detoxConfig.idlePolicyConfig.idleResourceTimeoutSec = 60;
+        detoxConfig.rnContextLoadTimeoutSec = (BuildConfig.DEBUG ? 180 : 60);
+
+        Detox.runTests(mActivityRule, detoxConfig);
+    }
+}

example/android/app/src/main/AndroidManifest.xml

@@ -9,7 +9,8 @@
       android:icon="@mipmap/ic_launcher"
       android:roundIcon="@mipmap/ic_launcher_round"
       android:allowBackup="false"
-      android:theme="@style/AppTheme">
+      android:theme="@style/AppTheme"
+      android:networkSecurityConfig="@xml/network_security_config">
       <activity
         android:name=".MainActivity"
         android:label="@string/app_name"