Add strict to tsconfig.json

wooorm · wooorm · commit 3993414185ef · 2021-07-23T13:40:30.000+02:00
diff --git a/lib/index.js b/lib/index.js
@@ -27,7 +27,7 @@ import {find, html, svg} from 'property-information'
 
 /**
  * @param {HastNode} node
- * @param {Context} [ctx]
+ * @param {Context} ctx
  */
 function transform(node, ctx) {
   switch (node.type) {
@@ -56,13 +56,13 @@ function transform(node, ctx) {
 function root(node, ctx) {
   const {doc, fragment, namespace: ctxNamespace} = ctx
   const {children = []} = node
-  const {length: childrenLength} = children
 
   let namespace = ctxNamespace
-  let rootIsDocument = childrenLength === 0
+  let rootIsDocument = children.length === 0
+  let index = -1
 
-  for (let i = 0; i < childrenLength; i += 1) {
-    const child = children[i]
+  while (++index < children.length) {
+    const child = children[index]
 
     if (child.type === 'element' && child.tagName === 'html') {
       const {properties = {}} = child
@@ -71,7 +71,7 @@ function root(node, ctx) {
       rootIsDocument = true
 
       // Take namespace of the first child.
-      if (typeof ctxNamespace === 'undefined') {
+      if (ctxNamespace === undefined) {
         namespace = String(properties.xmlns || '') || webNamespaces.html
       }
     }
@@ -82,7 +82,7 @@ function root(node, ctx) {
   let result
 
   if (rootIsDocument) {
-    result = doc.implementation.createDocument(namespace, '', null)
+    result = doc.implementation.createDocument(namespace || null, '', null)
   } else if (fragment) {
     result = doc.createDocumentFragment()
   } else {
@@ -192,6 +192,7 @@ function element(node, ctx) {
     }
 
     if (mustUseProperty) {
+      // @ts-expect-error: fine.
       result[property] = value
     }
 
diff --git a/package.json b/package.json
@@ -38,6 +38,7 @@
     "web-namespaces": "^2.0.0"
   },
   "devDependencies": {
+    "@types/glob": "^7.0.0",
     "@types/jsdom": "^16.0.0",
     "@types/tape": "^4.0.0",
     "@types/w3c-xmlserializer": "^2.0.0",
diff --git a/test/index.js b/test/index.js
@@ -19,7 +19,7 @@ globalThis.document = document
 
 test('hast-util-to-dom', (t) => {
   t.equal(
-    // @ts-ignore runtime.
+    // @ts-expect-error runtime.
     serializeNodeToHtmlString(toDom({type: 'root'})),
     '',
     'creates an empty root node'
@@ -43,7 +43,7 @@ test('hast-util-to-dom', (t) => {
       toDom({
         type: 'root',
         children: [
-          {type: 'doctype', name: 'html', public: null, system: null},
+          {type: 'doctype', name: 'html', public: undefined, system: undefined},
           {
             type: 'element',
             tagName: 'html',
@@ -73,15 +73,15 @@ test('hast-util-to-dom', (t) => {
   )
 
   t.equal(
-    // @ts-ignore runtime.
+    // @ts-expect-error runtime.
     serializeNodeToHtmlString(toDom({type: 'something-else'})),
     '<div></div>',
     'creates an unknown node in HTML'
   )
 
   t.equal(
     serializeNodeToHtmlString(
-      // @ts-ignore runtime.
+      // @ts-expect-error runtime.
       toDom({type: 'something-else'}, {namespace: webNamespaces.svg})
     ),
     '<g/>',
@@ -91,7 +91,7 @@ test('hast-util-to-dom', (t) => {
   t.equal(
     serializeNodeToHtmlString(
       toDom({
-        // @ts-ignore runtime.
+        // @ts-expect-error runtime.
         type: 'something-else',
         children: [{type: 'text', value: 'value'}]
       })
@@ -165,7 +165,7 @@ test('hast-util-to-dom', (t) => {
   )
 
   t.equal(
-    // @ts-ignore hast types out of date.
+    // @ts-expect-error hast types out of date.
     serializeNodeToHtmlString(toDom({type: 'doctype'})),
     '<!DOCTYPE html>',
     'creates a doctype node'
@@ -292,7 +292,7 @@ test('hast-util-to-dom', (t) => {
           type: 'root',
           children: [h('html', [h('title', 'foo'), h('h1', 'bar')])]
         },
-        // @ts-ignore Minimum of what we need.
+        // @ts-expect-error Minimum of what we need.
         {document: doc}
       )
     ),
diff --git a/tsconfig.json b/tsconfig.json
@@ -10,6 +10,7 @@
     "declaration": true,
     "emitDeclarationOnly": true,
     "allowSyntheticDefaultImports": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "strict": true
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`"declaration": true,`
`11`	`11`	`"emitDeclarationOnly": true,`
`12`	`12`	`"allowSyntheticDefaultImports": true,`
`13`		`- "skipLibCheck": true`
	`13`	`+ "skipLibCheck": true,`
	`14`	`+ "strict": true`
`14`	`15`	`}`
`15`	`16`	`}`