Skip to content

Commit 4909fbf

Browse files
authored
Fix MDX node types
The MDX node types are now imported from `mdast-util-mdx-expression` and `mdast-util-mdxjs-esm` instead of redefined in this package. Reviewed-by: Christian Murphy <[email protected]> Reviewed-by: Titus Wormer <[email protected]> Closes GH-4.
1 parent a62e408 commit 4909fbf

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

index.js

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,17 @@
2727
* @typedef {EstreeJsxOpeningElement['name']} EstreeJsxElementName
2828
* @typedef {EstreeJsxAttribute['name']} EstreeJsxAttributeName
2929
* @typedef {EstreeJsxElement['children'][number]} EstreeJsxChild
30-
* @typedef {Element['children'][number]} ElementChild
3130
*
32-
* @typedef {UnistNode & {type: 'mdxJsxAttributeValueExpression', value: string}} MDXJsxAttributeValueExpression
33-
* @typedef {UnistNode & {type: 'mdxJsxAttribute', name: string, value: (MDXJsxAttributeValueExpression|string)?}} MDXJsxAttribute
34-
* @typedef {UnistNode & {type: 'mdxJsxExpressionAttribute', value: string}} MDXJsxExpressionAttribute
35-
* @typedef {Parent & {name: string|null, attributes: Array.<MDXJsxExpressionAttribute|MDXJsxAttribute>}} MDXJsxElement
36-
* @typedef {MDXJsxElement & {type: 'mdxJsxFlowElement', children: Array.<MDXJsxFlowElement|ElementChild>}} MDXJsxFlowElement
37-
* @typedef {MDXJsxElement & {type: 'mdxJsxTextElement', children: Array.<MDXJsxTextElement|ElementChild>}} MDXJsxTextElement
31+
* @typedef {import('mdast-util-mdx-jsx').MDXJsxAttributeValueExpression} MDXJsxAttributeValueExpression
32+
* @typedef {import('mdast-util-mdx-jsx').MDXJsxAttribute} MDXJsxAttribute
33+
* @typedef {import('mdast-util-mdx-jsx').MDXJsxExpressionAttribute} MDXJsxExpressionAttribute
34+
* @typedef {import('mdast-util-mdx-jsx').MDXJsxFlowElement} MDXJsxFlowElement
35+
* @typedef {import('mdast-util-mdx-jsx').MDXJsxTextElement} MDXJsxTextElement
3836
*
39-
* @typedef {UnistNode & {value: string}} MDXExpression
40-
* @typedef {MDXExpression & {type: 'mdxFlowExpression'}} MDXFlowExpression
41-
* @typedef {MDXExpression & {type: 'mdxTextExpression'}} MDXTextExpression
37+
* @typedef {import('mdast-util-mdx-expression').MDXFlowExpression} MDXFlowExpression
38+
* @typedef {import('mdast-util-mdx-expression').MDXTextExpression} MDXTextExpression
4239
*
43-
* @typedef {UnistNode & {type: 'mdxjsEsm', value: string}} MDXEsm
40+
* @typedef {import('mdast-util-mdxjs-esm').MDXJSEsm} MDXJSEsm
4441
*
4542
* @typedef {ReturnType<find>} Info
4643
* @typedef {'html'|'svg'} Space
@@ -307,7 +304,7 @@ function element(node, context) {
307304
}
308305

309306
/**
310-
* @param {MDXEsm} node
307+
* @param {MDXJSEsm} node
311308
* @param {Context} context
312309
* @returns {void}
313310
*/
@@ -546,7 +543,7 @@ function text(node) {
546543
}
547544

548545
/**
549-
* @param {Parent} parent
546+
* @param {Parent|MDXJsxFlowElement|MDXJsxTextElement} parent
550547
* @param {Context} context
551548
* @returns {Array.<EstreeJsxChild>}
552549
*/

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
"estree-util-attach-comments": "^2.0.0",
4747
"estree-util-is-identifier-name": "^2.0.0",
4848
"hast-util-whitespace": "^2.0.0",
49+
"mdast-util-mdx-expression": "^1.0.0",
50+
"mdast-util-mdxjs-esm": "^1.0.0",
4951
"property-information": "^6.0.0",
5052
"space-separated-tokens": "^2.0.0",
5153
"style-to-object": "^0.3.0",

0 commit comments

Comments
 (0)