Skip to content

Commit 0a0434e

Browse files
authored
Fix typos and broken link in ui/README (kubeflow#1014)
Signed-off-by: manaswinidas <[email protected]>
1 parent 7f80686 commit 0a0434e

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,12 +154,12 @@ When shutting down the docker compose, you might want to clean-up the SQLite db
154154

155155
### Testing architecture
156156

157-
The following diagram illustrate testing strategy for the several components in Model Registry project:
157+
The following diagram illustrates testing strategy for the several components in Model Registry project:
158158

159159
![](/docs/Model%20Registry%20Testing%20areas.png)
160160

161161
Go layers components are tested with Unit Tests written in Go, as well as Integration Tests leveraging Testcontainers.
162-
This allows to verify the expected "Core layer" of logical data mapping developed implemented in Go, matches technical expectations.
162+
This allows to verify the expected "Core layer" of logical data mapping developed and implemented in Go, matches technical expectations.
163163

164164
Python client is also tested with Unit Tests and Integration Tests written in Python.
165165

@@ -175,13 +175,13 @@ To delete something, simply update its status.
175175
## Tips
176176
### Pull image rate limiting
177177

178-
Ocassionally you may encounter an 'ImagePullBackOff' error when deploying the Model Registry manifests. See example below for the `model-registry-db` container.
178+
Occasionally you may encounter an 'ImagePullBackOff' error when deploying the Model Registry manifests. See example below for the `model-registry-db` container.
179179

180180
```
181181
Failed to pull image “mysql:8.3.0”: rpc error: code = Unknown desc = fetching target platform image selected from image index: reading manifest sha256:f9097d95a4ba5451fff79f4110ea6d750ac17ca08840f1190a73320b84ca4c62 in docker.io/library/mysql: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
182182
```
183183

184-
This error is triggered by the rate limits from docker.io; in this example specifically about the image `mysql:8.3.0` (the expanded reference is `docker.io/library/mysql:8.3.0`). To mitigate against this error you could [authenticate using image pull secrets](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/) for _local development_; or replace the image used with alternative mirrored images, for instance with the following example:
184+
This error is triggered by the rate limits from docker.io; in this example specifically about the image `mysql:8.3.0` (the expanded reference is `docker.io/library/mysql:8.3.0`). To mitigate this error you could [authenticate using image pull secrets](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/) for _local development_; or replace the image used with alternative mirrored images, for instance with the following example:
185185
```
186186
manifests/kustomize/overlays/db/model-registry-db-deployment.yaml file.
187187

clients/ui/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[frontend requirements]: ./frontend/docs/dev-setup.md#requirements
22
[BFF requirements]: ./bff/README.md#pre-requisites
33
[Model registry UI]: ./docs/README.md
4-
[contributing guidelines]: ../CONTRIBUTING.md
4+
[contributing guidelines]: ./CONTRIBUTING.md
55

66
# Model Registry UI
77

docs/logical_model.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ curl --silent -X 'GET' \
225225
}
226226
```
227227

228-
A ML model from S3 bucket with all required location details except of credentials:
228+
A ML model from S3 bucket with all required location details except credentials:
229229

230230
```python
231231
model = registry.register_model(

docs/mr_kind_deploy_ingress.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,4 +90,4 @@ Run `curl http://model-registry.io:3080/api/model_registry/v1alpha3/registered_m
9090

9191
## Teardown
9292

93-
kind delete cluster
93+
`kind delete cluster`

0 commit comments

Comments
 (0)