Skip to content

Commit 126945b

Browse files
YuliaKrimermanYuliaKrimerman
authored
Added URL and Fixed Registry Button alignment (kubeflow#1281)
Signed-off-by: Yulia Krimerman <[email protected]>
1 parent f8905e9 commit 126945b

File tree

2 files changed

+81
-71
lines changed

2 files changed

+81
-71
lines changed

‎clients/ui/frontend/src/app/pages/modelRegistry/screens/ModelRegistrySelector.tsx‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,12 @@ import {
2222
KubeflowDocs,
2323
useThemeContext,
2424
SimpleSelect,
25+
InlineTruncatedClipboardCopy,
2526
} from 'mod-arch-shared';
2627
import { SimpleSelectOption } from 'mod-arch-shared/dist/components/SimpleSelect';
2728
import { ModelRegistrySelectorContext } from '~/app/context/ModelRegistrySelectorContext';
2829
import { ModelRegistry } from '~/app/types';
30+
import { getServerAddress } from './utils';
2931

3032
const MODEL_REGISTRY_FAVORITE_STORAGE_KEY = 'kubeflow.dashboard.model.registry.favorite';
3133

@@ -169,6 +171,14 @@ const ModelRegistrySelector: React.FC<ModelRegistrySelectorProps> = ({
169171
{selection.description || 'No description'}
170172
</DescriptionListDescription>
171173
</DescriptionListGroup>
174+
<DescriptionListGroup>
175+
<DescriptionListTerm>Server URL</DescriptionListTerm>
176+
<DescriptionListDescription>
177+
<InlineTruncatedClipboardCopy
178+
textToCopy={`https://${getServerAddress(selection)}`}
179+
/>
180+
</DescriptionListDescription>
181+
</DescriptionListGroup>
172182
</DescriptionList>
173183
}
174184
>

‎clients/ui/frontend/src/app/pages/modelRegistry/screens/RegisteredModels/RegisteredModelsTableToolbar.tsx‎

Lines changed: 71 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -41,78 +41,78 @@ const RegisteredModelsTableToolbar: React.FC<RegisteredModelsTableToolbarProps>
4141
<ToolbarContent>
4242
<ToolbarToggleGroup toggleIcon={<FilterIcon />} breakpoint="xl">
4343
{tableToggleGroupItems}
44-
<ToolbarItem>
45-
<Dropdown
46-
isOpen={isRegisterNewVersionOpen}
47-
onSelect={() => setIsRegisterNewVersionOpen(false)}
48-
onOpenChange={(isOpen) => setIsRegisterNewVersionOpen(isOpen)}
49-
toggle={(toggleRef) => (
50-
<MenuToggle
51-
isFullWidth
52-
variant="primary"
53-
ref={toggleRef}
54-
onClick={() => setIsRegisterNewVersionOpen(!isRegisterNewVersionOpen)}
55-
isExpanded={isRegisterNewVersionOpen}
56-
splitButtonItems={[
57-
<MenuToggleAction
58-
id="register-model-button"
59-
key="register-model-button"
60-
data-testid="register-model-button"
61-
aria-label="Register model"
62-
onClick={() => navigate(registerModelUrl(preferredModelRegistry?.name))}
63-
>
64-
Register model
65-
</MenuToggleAction>,
66-
]}
67-
aria-label="Register model toggle"
68-
data-testid="register-model-split-button"
69-
/>
70-
)}
71-
>
72-
<DropdownList>
73-
<DropdownItem
74-
id="register-new-version-button"
75-
aria-label="Register new version"
76-
key="register-new-version-button"
77-
onClick={() => {
78-
navigate(registerVersionUrl(preferredModelRegistry?.name));
79-
}}
80-
ref={tooltipRef}
81-
>
82-
Register new version
83-
</DropdownItem>
84-
</DropdownList>
85-
</Dropdown>
86-
</ToolbarItem>
87-
<ToolbarItem>
88-
<Dropdown
89-
isOpen={isArchivedModelKebabOpen}
90-
onSelect={() => setIsArchivedModelKebabOpen(false)}
91-
onOpenChange={(isOpen: boolean) => setIsArchivedModelKebabOpen(isOpen)}
92-
toggle={(tr: React.Ref<MenuToggleElement>) => (
93-
<MenuToggle
94-
data-testid="registered-models-table-kebab-action"
95-
ref={tr}
96-
variant="plain"
97-
onClick={() => setIsArchivedModelKebabOpen(!isArchivedModelKebabOpen)}
98-
isExpanded={isArchivedModelKebabOpen}
99-
aria-label="View archived models"
100-
>
101-
<EllipsisVIcon />
102-
</MenuToggle>
103-
)}
104-
shouldFocusToggleOnSelect
105-
>
106-
<DropdownList>
107-
<DropdownItem
108-
onClick={() => navigate(registeredModelArchiveUrl(preferredModelRegistry?.name))}
109-
>
110-
View archived models
111-
</DropdownItem>
112-
</DropdownList>
113-
</Dropdown>
114-
</ToolbarItem>
11544
</ToolbarToggleGroup>
45+
<ToolbarItem>
46+
<Dropdown
47+
isOpen={isRegisterNewVersionOpen}
48+
onSelect={() => setIsRegisterNewVersionOpen(false)}
49+
onOpenChange={(isOpen) => setIsRegisterNewVersionOpen(isOpen)}
50+
toggle={(toggleRef) => (
51+
<MenuToggle
52+
isFullWidth
53+
variant="primary"
54+
ref={toggleRef}
55+
onClick={() => setIsRegisterNewVersionOpen(!isRegisterNewVersionOpen)}
56+
isExpanded={isRegisterNewVersionOpen}
57+
splitButtonItems={[
58+
<MenuToggleAction
59+
id="register-model-button"
60+
key="register-model-button"
61+
data-testid="register-model-button"
62+
aria-label="Register model"
63+
onClick={() => navigate(registerModelUrl(preferredModelRegistry?.name))}
64+
>
65+
Register model
66+
</MenuToggleAction>,
67+
]}
68+
aria-label="Register model toggle"
69+
data-testid="register-model-split-button"
70+
/>
71+
)}
72+
>
73+
<DropdownList>
74+
<DropdownItem
75+
id="register-new-version-button"
76+
aria-label="Register new version"
77+
key="register-new-version-button"
78+
onClick={() => {
79+
navigate(registerVersionUrl(preferredModelRegistry?.name));
80+
}}
81+
ref={tooltipRef}
82+
>
83+
Register new version
84+
</DropdownItem>
85+
</DropdownList>
86+
</Dropdown>
87+
</ToolbarItem>
88+
<ToolbarItem>
89+
<Dropdown
90+
isOpen={isArchivedModelKebabOpen}
91+
onSelect={() => setIsArchivedModelKebabOpen(false)}
92+
onOpenChange={(isOpen: boolean) => setIsArchivedModelKebabOpen(isOpen)}
93+
toggle={(tr: React.Ref<MenuToggleElement>) => (
94+
<MenuToggle
95+
data-testid="registered-models-table-kebab-action"
96+
ref={tr}
97+
variant="plain"
98+
onClick={() => setIsArchivedModelKebabOpen(!isArchivedModelKebabOpen)}
99+
isExpanded={isArchivedModelKebabOpen}
100+
aria-label="View archived models"
101+
>
102+
<EllipsisVIcon />
103+
</MenuToggle>
104+
)}
105+
shouldFocusToggleOnSelect
106+
>
107+
<DropdownList>
108+
<DropdownItem
109+
onClick={() => navigate(registeredModelArchiveUrl(preferredModelRegistry?.name))}
110+
>
111+
View archived models
112+
</DropdownItem>
113+
</DropdownList>
114+
</Dropdown>
115+
</ToolbarItem>
116116
</ToolbarContent>
117117
</Toolbar>
118118
);

0 commit comments

Comments
 (0)